All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	netdev@vger.kernel.org
Cc: ast@kernel.org, Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH bpf] bpf: only test gso type on gso packets
Date: Thu, 7 Mar 2019 11:06:48 +0100	[thread overview]
Message-ID: <d2993173-b434-d87e-36fa-5a93b797698a@iogearbox.net> (raw)
In-Reply-To: <20190306193515.125072-1-willemdebruijn.kernel@gmail.com>

On 03/06/2019 08:35 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
> 
> BPF can adjust gso only for tcp bytestreams. Fail on other gso types.
> 
> But only on gso packets. It does not touch this field if !gso_size.
> 
> Fixes: b90efd225874 ("bpf: only adjust gso_size on bytestream protocols")
> Signed-off-by: Willem de Bruijn <willemb@google.com>

Good catch, applied, thanks!

> Stupid bug on my part. Found only when adding tests for the feature.
> Will try to upstream those once bpf-next opens.
> 
> On a related note, also working on a flag BPF_F_ADJ_ROOM_FIXED_GSO
> that will allow reenabling this field for UDP (and possibly avoiding
> the expensive skb_cow for the TCP common case).

Nice, looking forward!

      parent reply	other threads:[~2019-03-07 10:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 19:35 [PATCH bpf] bpf: only test gso type on gso packets Willem de Bruijn
2019-03-07  1:34 ` Y Song
2019-03-07 10:06 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2993173-b434-d87e-36fa-5a93b797698a@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.