From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B01D5C77B7A for ; Tue, 30 May 2023 13:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232622AbjE3NUy (ORCPT ); Tue, 30 May 2023 09:20:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231279AbjE3NUx (ORCPT ); Tue, 30 May 2023 09:20:53 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3959A1 for ; Tue, 30 May 2023 06:20:51 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-51496f57e59so3816846a12.2 for ; Tue, 30 May 2023 06:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685452850; x=1688044850; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ea2LdewWSYBlTGL1pC0uVnJLZZioO8cfJgJDEPtNoG8=; b=qvydoxNAZHcUiT+Wxla0aaBfxHooTFXK0IF/Trw7A2o/U95eS5pNGk7nya8DU3YaHN VqSVNL8jYNpuvaMHVgCheZfgdBYEivZuPcOXK2wo0noNfFepqoA8vw/wYg/dXBRkXiK5 jbgKSMCokog2ZTK6X5VD4tK1bCoKDOk/JemiAimkGQ92Rqh711M8pa9yyEVMT0g034dW iK2w9byBhHkDClsxWReyXeebR0jD2fus3SA/TKkJMPYK5qKVTLxO0H8330wH2m5nL3Ac hsN891MLZjnN9/8xa7GMqvdRtdKOcxFyZCz0pEfO8uMWCW4QU2SbvHV5gDvhphB3dzBB SU7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685452850; x=1688044850; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ea2LdewWSYBlTGL1pC0uVnJLZZioO8cfJgJDEPtNoG8=; b=NQfOF83v5leRT7p1amkLciKZ+gI4BShn8E7+vDv86WrY/V3mNhfxS4kf7OA0k+BSWP JW9NEsmpJ06nFu4g3nxX/u+17+oYUKxlAqg++hEvZyJqXa6ZzZ9NbMJ32q6mqs19C3dj MTdML4tpN+1d7UHUYhOYINMNwmLVAwrJA4DfdWxKNi+0erjjX9tdZUDzXCw5cis1TY3P WhUgLpABiUOUR4dABmlGjsUP6aezMy1Sb/1zzwPrAKXBVYiqvonky8+9N/xnzJKn5hD1 +vmQKEnQCahTGNcU9DONH16+lpWdMS0kRnfTKYxfehyJcxp4XjaZCYmR3JoR6b7VLuoW mRaw== X-Gm-Message-State: AC+VfDx/1+rIrFeU423GB1CMwnnMnqIZwSEyesMGUDvzPSuWAx0bTj6f Mks/wxa5KBiFMxr6s4ctdXO/zw== X-Google-Smtp-Source: ACHHUZ5Ec8mS0WQOTPmfsRcm8kG86wAB7r6cdlwRv8fyLj+55BTyGZ0d5j3fIeUVp34EMJ4rhBObtg== X-Received: by 2002:aa7:ce0c:0:b0:514:9422:37db with SMTP id d12-20020aa7ce0c000000b00514942237dbmr1488683edv.39.1685452850273; Tue, 30 May 2023 06:20:50 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id i12-20020aa7dd0c000000b005149c3fa632sm2798999edv.13.2023.05.30.06.20.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 06:20:49 -0700 (PDT) Message-ID: Date: Tue, 30 May 2023 15:20:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 5/5] ARM: Add Samsung Galaxy Express support Content-Language: en-US To: Rudraksha Gupta , Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: david@ixit.cz, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230524230459.120681-1-guptarud@gmail.com> <20230524230459.120681-5-guptarud@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230524230459.120681-5-guptarud@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 25/05/2023 01:04, Rudraksha Gupta wrote: > This adds a very basic device tree file for the Samsung Galaxy Express > SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and > USB. > > Signed-off-by: Rudraksha Gupta > --- > + > +&usb_hs1_phy { > + v3p3-supply = <&pm8921_l3>; > + v1p8-supply = <&pm8921_l4>; > +}; > + > +&usb1 { > + status = "okay"; > + dr_mode = "otg"; > +}; > + except what was said - drop stray blank line. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3B71C77B73 for ; Tue, 30 May 2023 13:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sdHv9wn6UWWArpwtCl2SB2wo4TINRgow1+Z5w/94e3s=; b=oaFFDkgiFpxTVz E67W6RYGlSEpw4dFk8HqPomap2KLfEdlgpvtCb1GgkgFb+PMWbItQfql1pJkHESzjoDeZWA08baSe NmRlt+JlSDDHgpjMnWrd6kfeXtghJjoQ4QW/QzYU01mZaWBQlrlodlrbavOoZu8+wMgw/GfOA8sOX iVQnEzssL/T804sUSUVp4wPgaJAffXEHF7cQBueZjFGyfLZqyB3PphtfNcBNKTDmLj4pjqsMIwFye PkWlMXiInCpuj9nrMoNabwSFYbxe3qxHVqR6PYNSj/Mw5EbHlR0A5N+80OLR+nhmh1AKKxM2lI2ex ZiNVyLbFkj9h44a1e/xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3zHS-00E1VX-0z; Tue, 30 May 2023 13:20:54 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3zHQ-00E1UU-1H for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 13:20:53 +0000 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5147f4bbfdaso5718738a12.0 for ; Tue, 30 May 2023 06:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685452850; x=1688044850; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ea2LdewWSYBlTGL1pC0uVnJLZZioO8cfJgJDEPtNoG8=; b=qvydoxNAZHcUiT+Wxla0aaBfxHooTFXK0IF/Trw7A2o/U95eS5pNGk7nya8DU3YaHN VqSVNL8jYNpuvaMHVgCheZfgdBYEivZuPcOXK2wo0noNfFepqoA8vw/wYg/dXBRkXiK5 jbgKSMCokog2ZTK6X5VD4tK1bCoKDOk/JemiAimkGQ92Rqh711M8pa9yyEVMT0g034dW iK2w9byBhHkDClsxWReyXeebR0jD2fus3SA/TKkJMPYK5qKVTLxO0H8330wH2m5nL3Ac hsN891MLZjnN9/8xa7GMqvdRtdKOcxFyZCz0pEfO8uMWCW4QU2SbvHV5gDvhphB3dzBB SU7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685452850; x=1688044850; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ea2LdewWSYBlTGL1pC0uVnJLZZioO8cfJgJDEPtNoG8=; b=WOvy0Z2MThWE2uLwTrymXhjT56fBw80Om2hLjZ25Mtk+MBiEX41lxS8jQzaGnnQM67 GBiNH8ALWi1tCXiq7nrrTZnB4hqHHKf4n3YxdIDXoyngGMVunQ7wG9Ao8Hg5/8bxfdQl O0pjEW5mLB2I2vfem+m3Uzo7ekGNEcfNsNGVQpFeQvRfpEvNWwCH7ikLl5V6E8csZWSt r8IIB9bE6ZBSw0KxDiKUNfvlxg+cEPHNY2QAblsuObmep77OyhNwxlPqlP2qIxgs4NRk JBseR9JQgagiv8BlPJzWUGDLfTKwdrMS7KjOZZJLeW/6Vu7ebCsp28eYIUE4UayGW6XI UUgg== X-Gm-Message-State: AC+VfDyTy+dTjjSQNP7g1FkJAxwF1vPr+DMwo0BZSTWno8PUnjjdC857 9FaEZb9q719hFTJY+IAQKU4NVg== X-Google-Smtp-Source: ACHHUZ5Ec8mS0WQOTPmfsRcm8kG86wAB7r6cdlwRv8fyLj+55BTyGZ0d5j3fIeUVp34EMJ4rhBObtg== X-Received: by 2002:aa7:ce0c:0:b0:514:9422:37db with SMTP id d12-20020aa7ce0c000000b00514942237dbmr1488683edv.39.1685452850273; Tue, 30 May 2023 06:20:50 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id i12-20020aa7dd0c000000b005149c3fa632sm2798999edv.13.2023.05.30.06.20.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 06:20:49 -0700 (PDT) Message-ID: Date: Tue, 30 May 2023 15:20:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 5/5] ARM: Add Samsung Galaxy Express support Content-Language: en-US To: Rudraksha Gupta , Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: david@ixit.cz, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230524230459.120681-1-guptarud@gmail.com> <20230524230459.120681-5-guptarud@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230524230459.120681-5-guptarud@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_062052_436335_6DF16EF1 X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/05/2023 01:04, Rudraksha Gupta wrote: > This adds a very basic device tree file for the Samsung Galaxy Express > SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and > USB. > > Signed-off-by: Rudraksha Gupta > --- > + > +&usb_hs1_phy { > + v3p3-supply = <&pm8921_l3>; > + v1p8-supply = <&pm8921_l4>; > +}; > + > +&usb1 { > + status = "okay"; > + dr_mode = "otg"; > +}; > + except what was said - drop stray blank line. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel