From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdKFGes (ORCPT ); Mon, 6 Nov 2017 01:34:48 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:30691 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbdKFGer (ORCPT ); Mon, 6 Nov 2017 01:34:47 -0500 Subject: Re: [PATCH] lost path_put in perf_fill_ns_link_info To: linux-kernel@vger.kernel.org, Hari Bathini Cc: Namhyung Kim , Jiri Olsa , Alexander Shishkin , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra References: From: Vasily Averin Message-ID: Date: Mon, 6 Nov 2017 09:34:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Hari, I did not found where your patch decreases mnt counter, it seems for me you have lost path_put in perf_fill_ns_link_info(). Thank you, Vasily Averin On 2017-11-06 09:22, Vasily Averin wrote: > Fixes: commit e422267322cd ("perf: Add PERF_RECORD_NAMESPACES to include namespaces related info") > Signed-off-by: Vasily Averin > --- > kernel/events/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 10cdb9c..ab5ac84 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -6756,6 +6756,7 @@ static void perf_fill_ns_link_info(struct perf_ns_link_info *ns_link_info, > ns_inode = ns_path.dentry->d_inode; > ns_link_info->dev = new_encode_dev(ns_inode->i_sb->s_dev); > ns_link_info->ino = ns_inode->i_ino; > + path_put(&ns_path); > } > } > >