All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: openbmc@lists.ozlabs.org
Cc: Joel Stanley <joel@jms.id.au>, Cyril Bur <cyril.bur@au1.ibm.com>
Subject: Re: [PATCH linux dev-4.7] mtd: spi-nor: add SECT_4K to mx25l25635e
Date: Fri, 21 Oct 2016 11:52:57 +0200	[thread overview]
Message-ID: <d2ad5ccb-90b0-b5fa-1d70-f0bd6757ee1e@kaod.org> (raw)
In-Reply-To: <1477039467-25076-1-git-send-email-clg@kaod.org>

On 10/21/2016 10:44 AM, Cédric Le Goater wrote:
> The current setting is to erase blocks (64KB) but the chip supports
> sector (4KB) erase and it is currently a problem to erase "partitions"
> which are smaller than the block size (64KB), the GUARD partition for
> instance.

There are few other macronixs that would need a similar change but 
this has an impact on existing jffs2 filesystems on the flash. I am 
not sure we will be able to merge this change in mainline.

C.


> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  drivers/mtd/spi-nor/spi-nor.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-openbmc-4.7.git/drivers/mtd/spi-nor/spi-nor.c
> ===================================================================
> --- linux-openbmc-4.7.git.orig/drivers/mtd/spi-nor/spi-nor.c
> +++ linux-openbmc-4.7.git/drivers/mtd/spi-nor/spi-nor.c
> @@ -855,7 +855,7 @@ static const struct flash_info spi_nor_i
>  	{ "mx25u6435f",  INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
>  	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>  	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
> -	{ "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
> +	{ "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, SECT_4K) },
>  	{ "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
>  	{ "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
>  	{ "mx66l1g45g",  INFO(0xc2201b, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_QUAD_READ) },
> 

  reply	other threads:[~2016-10-21  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  8:44 [PATCH linux dev-4.7] mtd: spi-nor: add SECT_4K to mx25l25635e Cédric Le Goater
2016-10-21  9:52 ` Cédric Le Goater [this message]
2016-10-25 12:11   ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2ad5ccb-90b0-b5fa-1d70-f0bd6757ee1e@kaod.org \
    --to=clg@kaod.org \
    --cc=cyril.bur@au1.ibm.com \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.