All of
 help / color / mirror / Atom feed
From: Vlastimil Babka <>
To: Vinayak Menon <>,,,,,,,,,,,
Subject: Re: [PATCH] mm: avoid taking zone lock in pagetypeinfo_showmixed
Date: Wed, 21 Jun 2017 14:24:22 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 06/21/2017 01:47 PM, Vinayak Menon wrote:
> pagetypeinfo_showmixedcount_print is found to take a lot of
> time to complete and it does this holding the zone lock and
> disabling interrupts. In some cases it is found to take more
> than a second (On a 2.4GHz,8Gb RAM,arm64 cpu). Avoid taking
> the zone lock similar to what is done by read_page_owner,
> which means possibility of inaccurate results.
> Signed-off-by: Vinayak Menon <>

Acked-by: Vlastimil Babka <>

walk_zones_in_node() becomes quite ugly though, multiple bool params are
not nice, and both are there for single special cases. Wonder if
replacing this with a new for_each_zone_node() helper would make this
better. OTOH it's now isolated only to vmstat.c.

To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to  For more info on Linux MM,
see: .
Don't email: <a href=mailto:""> </a>

      reply	other threads:[~2017-06-21 12:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 11:47 Vinayak Menon
2017-06-21 12:24 ` Vlastimil Babka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] mm: avoid taking zone lock in pagetypeinfo_showmixed' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.