From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC924C4332F for ; Sun, 26 Sep 2021 20:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC11961019 for ; Sun, 26 Sep 2021 20:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbhIZUvQ (ORCPT ); Sun, 26 Sep 2021 16:51:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbhIZUvO (ORCPT ); Sun, 26 Sep 2021 16:51:14 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2627CC061604 for ; Sun, 26 Sep 2021 13:49:38 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id c1so13866673pfp.10 for ; Sun, 26 Sep 2021 13:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=1Xi2zI3xz++jAU4KL461gSjO8O02r5P5HLSbGNQJnPI=; b=YNUKZmOzFiHeJ2mJa7gvVYN7uN2TvfskQSN1D5sRVykhEQSaJ9ruR/0/YcZL/v6m+1 ej1FfHbYG0ay7WCE+E3fA04decWx+gxNMJh/2AfKb1EJT5DQhro8je6KQpQGeHKkDbsI 2Vo6bqf1guqWezlCcy2Pu6ROHYsiuxXT4kAlFIb+PM88X+oLVX6srxEMUnpVmYtptPL8 WAOiHaRdS1eZovd/jq4qVEL92/LIrjngBpm8KGcaYFTn8I1F9IQaKEEHQjkczzN5zKka GwufIKM8VX78GbMlNVMgRK/KoB016OeVF3XuaLuGYvlJ152+ArnP4IkuG15uKtU0UehI POCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=1Xi2zI3xz++jAU4KL461gSjO8O02r5P5HLSbGNQJnPI=; b=dyjFNBFlFdxYwSNyBg1KaWZoaQlZlLVOHBsJIf1caPaALlT67/a8NDUyKiUIRbATZO xPWh8nL5Frkl1ApgE9y/hR9yTk6b0sSyg+ZOeOVPofG4+vuLrI6sxpiBXNuqYTi0Z+GI p2SIVTD5s9LRq9QHlzb/hYCZZg9NJ6hzwxkLqMPdhqsZly9LzwjiMJlDO0BJE6uf1SMy ReNs5BXliRFCjC1yw3QVwS1eeamLCAaZDbI0GttvSZaDq6u38sS5AtAw5MlVbarw5H3A 7jQM8aZFeligqsrd5yraZXP/KFHOMGymQugYK7YCZYVcUxsDgMFVl/0zOJ8pi++81BH3 OI1g== X-Gm-Message-State: AOAM5325rw/xVYKv4tEy5Jf5BdnJIRR73mB3IAaEBeY0diDOdqdgBXto WzJ/B5P+bIwo5tqqa86RsvmzRQ== X-Google-Smtp-Source: ABdhPJzndYH2uLj5kPrP3Kat7T50/IOEb8DNH7IWYo8ePwhsiil1vOxBGyaBm89cXY3NegHO0nVNfg== X-Received: by 2002:a63:4457:: with SMTP id t23mr583580pgk.354.1632689377421; Sun, 26 Sep 2021 13:49:37 -0700 (PDT) Received: from [2620:15c:17:3:4d45:c2:971a:f134] ([2620:15c:17:3:4d45:c2:971a:f134]) by smtp.gmail.com with ESMTPSA id q13sm6606060pfk.128.2021.09.26.13.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 13:49:36 -0700 (PDT) Date: Sun, 26 Sep 2021 13:49:35 -0700 (PDT) From: David Rientjes To: Stephen Kitt cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , James Morris , "Serge E . Hallyn" , linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Kees Cook Subject: Re: [PATCH] mm: Remove HARDENED_USERCOPY_FALLBACK In-Reply-To: <20210921061149.1091163-1-steve@sk2.org> Message-ID: References: <20210921061149.1091163-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Sep 2021, Stephen Kitt wrote: > This has served its purpose and is no longer used. All usercopy > violations appear to have been handled by now, any remaining > instances (or new bugs) will cause copies to be rejected. > > This isn't a direct revert of commit 2d891fbc3bb6 ("usercopy: Allow > strict enforcement of whitelists"); since usercopy_fallback is > effectively 0, the fallback handling is removed too. > > This also removes the usercopy_fallback module parameter on > slab_common. > > Link: https://github.com/KSPP/linux/issues/153 > Signed-off-by: Stephen Kitt > Suggested-by: Kees Cook Acked-by: David Rientjes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BEE2C433EF for ; Sun, 26 Sep 2021 20:49:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D238C60F5D for ; Sun, 26 Sep 2021 20:49:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D238C60F5D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5D6636B0071; Sun, 26 Sep 2021 16:49:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5854D6B0072; Sun, 26 Sep 2021 16:49:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42637900002; Sun, 26 Sep 2021 16:49:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 358CF6B0071 for ; Sun, 26 Sep 2021 16:49:39 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E99BB1807C266 for ; Sun, 26 Sep 2021 20:49:38 +0000 (UTC) X-FDA: 78630915636.23.9120923 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf03.hostedemail.com (Postfix) with ESMTP id AB45F30000AA for ; Sun, 26 Sep 2021 20:49:38 +0000 (UTC) Received: by mail-pf1-f175.google.com with SMTP id w14so13938066pfu.2 for ; Sun, 26 Sep 2021 13:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=1Xi2zI3xz++jAU4KL461gSjO8O02r5P5HLSbGNQJnPI=; b=YNUKZmOzFiHeJ2mJa7gvVYN7uN2TvfskQSN1D5sRVykhEQSaJ9ruR/0/YcZL/v6m+1 ej1FfHbYG0ay7WCE+E3fA04decWx+gxNMJh/2AfKb1EJT5DQhro8je6KQpQGeHKkDbsI 2Vo6bqf1guqWezlCcy2Pu6ROHYsiuxXT4kAlFIb+PM88X+oLVX6srxEMUnpVmYtptPL8 WAOiHaRdS1eZovd/jq4qVEL92/LIrjngBpm8KGcaYFTn8I1F9IQaKEEHQjkczzN5zKka GwufIKM8VX78GbMlNVMgRK/KoB016OeVF3XuaLuGYvlJ152+ArnP4IkuG15uKtU0UehI POCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=1Xi2zI3xz++jAU4KL461gSjO8O02r5P5HLSbGNQJnPI=; b=Vcw57BCsZqexJPgTY1ZRXecAEy5FVV9zF5FTvDSMEmjcoB1qz/KPgKK3DIJ4mAfp8o P2wF4HbgNLSnF8g8GP37//DzYCERJgaymr+OKBFj/NAFlE3LR8nArUBzCI2S56VERM8i 72Koc8RQv47f+Qd/WRxRTwAl9ZpryeVwW+FICXvJfHteVMGDgE9MsCyKIbBxRv9WGALG Mxesvr9ROp4s8fk1aRkwxbvVgN+p1laJCIdpWg67CHWxwfPeO85IW4IzM9qV72nfRgWH K57Utskd278tLWWPyu+iwlpc5ABe+wTkh8DJgAVDC6hw3jM2wpQe/xpOk/Cn07VOv5Vx a4qQ== X-Gm-Message-State: AOAM532OBvI8PWJdmw6UJPNsyLtEKI0YjvEhZ49VUEbTM42KfXnZzojE x+/PRukL/uQht41P3u7GhbsfrA== X-Google-Smtp-Source: ABdhPJzndYH2uLj5kPrP3Kat7T50/IOEb8DNH7IWYo8ePwhsiil1vOxBGyaBm89cXY3NegHO0nVNfg== X-Received: by 2002:a63:4457:: with SMTP id t23mr583580pgk.354.1632689377421; Sun, 26 Sep 2021 13:49:37 -0700 (PDT) Received: from [2620:15c:17:3:4d45:c2:971a:f134] ([2620:15c:17:3:4d45:c2:971a:f134]) by smtp.gmail.com with ESMTPSA id q13sm6606060pfk.128.2021.09.26.13.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 13:49:36 -0700 (PDT) Date: Sun, 26 Sep 2021 13:49:35 -0700 (PDT) From: David Rientjes To: Stephen Kitt cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , James Morris , "Serge E . Hallyn" , linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Kees Cook Subject: Re: [PATCH] mm: Remove HARDENED_USERCOPY_FALLBACK In-Reply-To: <20210921061149.1091163-1-steve@sk2.org> Message-ID: References: <20210921061149.1091163-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: AB45F30000AA X-Stat-Signature: 469a3ze6m8hfzw3en5eo4wm8w5n7ujj1 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=YNUKZmOz; spf=pass (imf03.hostedemail.com: domain of rientjes@google.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam06 X-HE-Tag: 1632689378-882765 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 21 Sep 2021, Stephen Kitt wrote: > This has served its purpose and is no longer used. All usercopy > violations appear to have been handled by now, any remaining > instances (or new bugs) will cause copies to be rejected. > > This isn't a direct revert of commit 2d891fbc3bb6 ("usercopy: Allow > strict enforcement of whitelists"); since usercopy_fallback is > effectively 0, the fallback handling is removed too. > > This also removes the usercopy_fallback module parameter on > slab_common. > > Link: https://github.com/KSPP/linux/issues/153 > Signed-off-by: Stephen Kitt > Suggested-by: Kees Cook Acked-by: David Rientjes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BD6C433EF for ; Sun, 26 Sep 2021 20:50:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBBF860F5D for ; Sun, 26 Sep 2021 20:50:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EBBF860F5D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HHdFW20Rkz307D for ; Mon, 27 Sep 2021 06:50:23 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=YNUKZmOz; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::533; helo=mail-pg1-x533.google.com; envelope-from=rientjes@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=YNUKZmOz; dkim-atps=neutral Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HHdDl5VB6z2xtM for ; Mon, 27 Sep 2021 06:49:41 +1000 (AEST) Received: by mail-pg1-x533.google.com with SMTP id x191so8861057pgd.9 for ; Sun, 26 Sep 2021 13:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=1Xi2zI3xz++jAU4KL461gSjO8O02r5P5HLSbGNQJnPI=; b=YNUKZmOzFiHeJ2mJa7gvVYN7uN2TvfskQSN1D5sRVykhEQSaJ9ruR/0/YcZL/v6m+1 ej1FfHbYG0ay7WCE+E3fA04decWx+gxNMJh/2AfKb1EJT5DQhro8je6KQpQGeHKkDbsI 2Vo6bqf1guqWezlCcy2Pu6ROHYsiuxXT4kAlFIb+PM88X+oLVX6srxEMUnpVmYtptPL8 WAOiHaRdS1eZovd/jq4qVEL92/LIrjngBpm8KGcaYFTn8I1F9IQaKEEHQjkczzN5zKka GwufIKM8VX78GbMlNVMgRK/KoB016OeVF3XuaLuGYvlJ152+ArnP4IkuG15uKtU0UehI POCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=1Xi2zI3xz++jAU4KL461gSjO8O02r5P5HLSbGNQJnPI=; b=xtRdPGM2P7znXZ6Pi+T68JT47C79jkn/2+35TokOhHKU0xCGZ8VloRl8qkUvzvltyZ Rc1UGGUaJJBXT+nI6Bc2QfSzQ2LAdPp8PQS1lm2jJYRftKRSWdySq6g6UFva2k7obr05 krxIXB9YyK/Mr21RzPPqhR9Yzyzk8cWOqokiR03a/KqEgjgxpxCLSaBymVY4mhzyyt/L wV2LhbtSWgUIsDoNd+aqLhUE5mop9+1hX+sWMvh5n4Vchwy+dBPZv0oSF0GHq+hTzT+K YDSRVYRM10yELEBCSjaIJu+naza0bP6j/qBsBsfdf/PyUaNYG+qU1eJPuyFAFJRLg8io P4yQ== X-Gm-Message-State: AOAM531QRP3G1S7b8czbDEWmIIKadREdmOMg0ZyHF1S5xsUKQ7+8/n4T ytRbYc/pMs82vqgA30RCfG1BzA== X-Google-Smtp-Source: ABdhPJzndYH2uLj5kPrP3Kat7T50/IOEb8DNH7IWYo8ePwhsiil1vOxBGyaBm89cXY3NegHO0nVNfg== X-Received: by 2002:a63:4457:: with SMTP id t23mr583580pgk.354.1632689377421; Sun, 26 Sep 2021 13:49:37 -0700 (PDT) Received: from [2620:15c:17:3:4d45:c2:971a:f134] ([2620:15c:17:3:4d45:c2:971a:f134]) by smtp.gmail.com with ESMTPSA id q13sm6606060pfk.128.2021.09.26.13.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 13:49:36 -0700 (PDT) Date: Sun, 26 Sep 2021 13:49:35 -0700 (PDT) From: David Rientjes To: Stephen Kitt Subject: Re: [PATCH] mm: Remove HARDENED_USERCOPY_FALLBACK In-Reply-To: <20210921061149.1091163-1-steve@sk2.org> Message-ID: References: <20210921061149.1091163-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Morton , Kees Cook , James Morris , linux-kernel@vger.kernel.org, Pekka Enberg , linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-hardening@vger.kernel.org, Christoph Lameter , linuxppc-dev@lists.ozlabs.org, Joonsoo Kim , Vlastimil Babka , "Serge E . Hallyn" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 21 Sep 2021, Stephen Kitt wrote: > This has served its purpose and is no longer used. All usercopy > violations appear to have been handled by now, any remaining > instances (or new bugs) will cause copies to be rejected. > > This isn't a direct revert of commit 2d891fbc3bb6 ("usercopy: Allow > strict enforcement of whitelists"); since usercopy_fallback is > effectively 0, the fallback handling is removed too. > > This also removes the usercopy_fallback module parameter on > slab_common. > > Link: https://github.com/KSPP/linux/issues/153 > Signed-off-by: Stephen Kitt > Suggested-by: Kees Cook Acked-by: David Rientjes