From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62798C4360F for ; Fri, 5 Apr 2019 07:55:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D99F217D4 for ; Fri, 5 Apr 2019 07:55:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="NQKWxhA+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730369AbfDEHzZ (ORCPT ); Fri, 5 Apr 2019 03:55:25 -0400 Received: from mout.web.de ([217.72.192.78]:51931 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbfDEHzY (ORCPT ); Fri, 5 Apr 2019 03:55:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1554450894; bh=hf9dEREKxEenkihgK8pKnqNTae64ydfo8H9aPfN1PAQ=; h=X-UI-Sender-Class:Cc:References:Subject:To:From:Date:In-Reply-To; b=NQKWxhA+zwG8uxeDk0VX+7cAvdCDYtnScuORwUygZkw4rYhWih8Zx97Bp2BVaqXMc PnTZ5VguU9q6/lQAYRCLXJ70cjHko+TkOesbZI0w0Tw74/DRgSFm/2NxaG3eGUCNuR IEXA/gLH+03U/x9qeygRPCtENBchsm5bIl38Pa38= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.135.156.119]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LmLc6-1gchx62xF4-00Zzwi; Fri, 05 Apr 2019 09:54:54 +0200 Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anirudha Sarangi , John Linn , Michal Simek , Yi Wang References: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> Subject: Re: [PATCH 1/3] net: xilinx: fix possible object reference leak To: Wen Yang , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Fri, 5 Apr 2019 09:54:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Provags-ID: V03:K1:uhJqR1yCCBFeVqpSILNxEQPi6Ns72Y2J9OoFw4Yb6rFJlZOcc6V 4FdJfoK2gPl+qR28M0fwirrMi+YlkypjrpwZR+wp01M7BRZ2ZLkE6c7R6JZnOcQukLAjHTV 2KMHbGhYK1co3f8yAjdo1UsUtpCmvaptZBhziMu28XSluurSa7/ltTL78zSoJi/HmQCzJYe mI4eXSnhDb8Opwn70es/w== X-UI-Out-Filterresults: notjunk:1;V03:K0:wkW3FtME1Ss=:omzqLgFjqP8NMDl6JrmiGJ g0N3xVHW9t4+EWUeRS5DQzodoj75AdKBxE+CfXLDA9VUx+XbrxNjDRRvxImS02kcZXeaZKasK QIg6p+rjJIGGSULDJ1FJuZEdwHa7R0Qp2OF1rkYXRDWTFFWKcwHY8Rp7FkC0kJ5l83Bm3pHBU etZA8mg51eiFXqRYxhz7O/6iuCsz2QVxVEq4fGljXW/i3WvkwHZ8Vl/+qx+dFBs60cFOLpGmS ZkYDoaAvmxjJfwLKqTQsI3EEyyFPSy0FVhL6i5fmspA8UfZNcjt5ezTXhMArIqEcLTvnMv4eF +tNFoIx+3q6702xT2vk8j5m6LnDIQd5bTuJj1Jm9wxXDwX544Y3lAClqRszmumwUNuQpd9Yz/ HJ2fsnywJPj049uSGyfUeEMhccDhn5KVo+AKZr59OouqYsuGRE4ZBndfuqQbjhZ5BMHMh6OqM g7UKTdZTK4dTcJ7fhuVJY2qT0A1aIK25oC7mbF/298VlH/aKAZLQbmK1QuOOZpqBFyDGEAg/v vbGRlImv7Srsfj9JxKZubiUDde5NSH8fTWfClxDYHQW6B68bFH/SIJtUO6xMEQY83SXBJKwaQ Bkm/7Czx1n0xg7oE/yyQXzRbtvPCSDJnGlZGZEV4hgKjErK3AlQNRtxdxtllIFv4LI4mBYgYp FbXLnqMOn38ur/S0LIqcO4h9Kk8iFcUbrh9ep4OOVmo+UhuHvh3xvCSBfB3/FFOVo2t1zNDA+ Qp42amvmeMC8U+v5A8wL+Q0APydXDEpb+jIOnbDwKL0lFsZUJ6c6fGK7pjG7SjcOqFlDtgVGd pOr8+NipwRdkSfh2AYSAKNDce7kOUvIHHad1CtUmytqEpxZhUE7OY4TyJ+sDCj/UX0IniyqRM xAjuDIoKHeqK74tkhqniiqMVVRIcKek4nqX51k2kgdP0Xj4WpQTUM9b1BwGW42Xrn+R1oQfKE EF9rRqafcow== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -1575,12 +1575,14 @@ static int axienet_probe(struct platform_device *pdev) > ret = of_address_to_resource(np, 0, &dmares); > if (ret) { > dev_err(&pdev->dev, "unable to get DMA resource\n"); > + of_node_put(np); > goto free_netdev; > } > lp->dma_regs = devm_ioremap_resource(&pdev->dev, &dmares); > if (IS_ERR(lp->dma_regs)) { > dev_err(&pdev->dev, "could not map DMA regs\n"); > ret = PTR_ERR(lp->dma_regs); > + of_node_put(np); > goto free_netdev; > } How do you think about to move these put calls to an additional jump target for the desired exception handling? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/xilinx/xilinx_axienet_main.c?id=fa3a419d2f674b431d38748cb58fb7da17ee8949#n1621 Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Fri, 05 Apr 2019 07:54:45 +0000 Subject: Re: [PATCH 1/3] net: xilinx: fix possible object reference leak Message-Id: List-Id: References: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> In-Reply-To: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Wen Yang , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Cc: Yi Wang , Michal Simek , linux-kernel@vger.kernel.org, Anirudha Sarangi , John Linn , linux-arm-kernel@lists.infradead.org > @@ -1575,12 +1575,14 @@ static int axienet_probe(struct platform_device = *pdev) > ret =3D of_address_to_resource(np, 0, &dmares); > if (ret) { > dev_err(&pdev->dev, "unable to get DMA resource\n"); > + of_node_put(np); > goto free_netdev; > } > lp->dma_regs =3D devm_ioremap_resource(&pdev->dev, &dmares); > if (IS_ERR(lp->dma_regs)) { > dev_err(&pdev->dev, "could not map DMA regs\n"); > ret =3D PTR_ERR(lp->dma_regs); > + of_node_put(np); > goto free_netdev; > } How do you think about to move these put calls to an additional jump target for the desired exception handling? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/dr= ivers/net/ethernet/xilinx/xilinx_axienet_main.c?id=FA3a419d2f674b431d38748c= b58fb7da17ee8949#n1621 Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B9FAC4360F for ; Fri, 5 Apr 2019 07:55:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 211FD217D4 for ; Fri, 5 Apr 2019 07:55:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sp8sXPor"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="NQKWxhA+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 211FD217D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:To:Subject:References:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DhQhK+Jtcf2VEX/llS3dwwxiiJT+QJESMg5+SlKZwwc=; b=Sp8sXPorfAgVT/ XUx74LCqfrqrVgEgxwGLgFE9VIdeba54/2f/KMgyiXoP7Rdprd5uBHqjj2EVJ0xrP2Msila0FHWcA oPmHqDN08jpw0qHKetQBhhBNtFwdQmXM4F39jRzhqtBFcVp8DU5BuLOeRD0dKk59uvfYuh/3sbgCo M5Wqnm3b7Xkb1D47Qn62kBdXJM6O6su09T8fNZ8ksouomHgpjuGVyleRM0IznyQl410oCLpYCJpOF C0WRb+PGLpj8NLK3tBmKyKwwo4CHepl+K7CW4dq4aAQlI8KbBUP7JWyrkqHm8rrGdzcHUE2w7NEXc krrBstu7dq3ExKR5j5Nw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCJh5-0000V5-M8; Fri, 05 Apr 2019 07:55:23 +0000 Received: from mout.web.de ([217.72.192.78]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCJh1-0000Uf-Ha for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2019 07:55:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1554450894; bh=hf9dEREKxEenkihgK8pKnqNTae64ydfo8H9aPfN1PAQ=; h=X-UI-Sender-Class:Cc:References:Subject:To:From:Date:In-Reply-To; b=NQKWxhA+zwG8uxeDk0VX+7cAvdCDYtnScuORwUygZkw4rYhWih8Zx97Bp2BVaqXMc PnTZ5VguU9q6/lQAYRCLXJ70cjHko+TkOesbZI0w0Tw74/DRgSFm/2NxaG3eGUCNuR IEXA/gLH+03U/x9qeygRPCtENBchsm5bIl38Pa38= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.135.156.119]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LmLc6-1gchx62xF4-00Zzwi; Fri, 05 Apr 2019 09:54:54 +0200 References: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> Subject: Re: [PATCH 1/3] net: xilinx: fix possible object reference leak To: Wen Yang , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Fri, 5 Apr 2019 09:54:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> Content-Language: en-US X-Provags-ID: V03:K1:uhJqR1yCCBFeVqpSILNxEQPi6Ns72Y2J9OoFw4Yb6rFJlZOcc6V 4FdJfoK2gPl+qR28M0fwirrMi+YlkypjrpwZR+wp01M7BRZ2ZLkE6c7R6JZnOcQukLAjHTV 2KMHbGhYK1co3f8yAjdo1UsUtpCmvaptZBhziMu28XSluurSa7/ltTL78zSoJi/HmQCzJYe mI4eXSnhDb8Opwn70es/w== X-UI-Out-Filterresults: notjunk:1;V03:K0:wkW3FtME1Ss=:omzqLgFjqP8NMDl6JrmiGJ g0N3xVHW9t4+EWUeRS5DQzodoj75AdKBxE+CfXLDA9VUx+XbrxNjDRRvxImS02kcZXeaZKasK QIg6p+rjJIGGSULDJ1FJuZEdwHa7R0Qp2OF1rkYXRDWTFFWKcwHY8Rp7FkC0kJ5l83Bm3pHBU etZA8mg51eiFXqRYxhz7O/6iuCsz2QVxVEq4fGljXW/i3WvkwHZ8Vl/+qx+dFBs60cFOLpGmS ZkYDoaAvmxjJfwLKqTQsI3EEyyFPSy0FVhL6i5fmspA8UfZNcjt5ezTXhMArIqEcLTvnMv4eF +tNFoIx+3q6702xT2vk8j5m6LnDIQd5bTuJj1Jm9wxXDwX544Y3lAClqRszmumwUNuQpd9Yz/ HJ2fsnywJPj049uSGyfUeEMhccDhn5KVo+AKZr59OouqYsuGRE4ZBndfuqQbjhZ5BMHMh6OqM g7UKTdZTK4dTcJ7fhuVJY2qT0A1aIK25oC7mbF/298VlH/aKAZLQbmK1QuOOZpqBFyDGEAg/v vbGRlImv7Srsfj9JxKZubiUDde5NSH8fTWfClxDYHQW6B68bFH/SIJtUO6xMEQY83SXBJKwaQ Bkm/7Czx1n0xg7oE/yyQXzRbtvPCSDJnGlZGZEV4hgKjErK3AlQNRtxdxtllIFv4LI4mBYgYp FbXLnqMOn38ur/S0LIqcO4h9Kk8iFcUbrh9ep4OOVmo+UhuHvh3xvCSBfB3/FFOVo2t1zNDA+ Qp42amvmeMC8U+v5A8wL+Q0APydXDEpb+jIOnbDwKL0lFsZUJ6c6fGK7pjG7SjcOqFlDtgVGd pOr8+NipwRdkSfh2AYSAKNDce7kOUvIHHad1CtUmytqEpxZhUE7OY4TyJ+sDCj/UX0IniyqRM xAjuDIoKHeqK74tkhqniiqMVVRIcKek4nqX51k2kgdP0Xj4WpQTUM9b1BwGW42Xrn+R1oQfKE EF9rRqafcow== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190405_005519_927429_0B803B00 X-CRM114-Status: UNSURE ( 8.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yi Wang , Michal Simek , linux-kernel@vger.kernel.org, Anirudha Sarangi , John Linn , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > @@ -1575,12 +1575,14 @@ static int axienet_probe(struct platform_device *pdev) > ret = of_address_to_resource(np, 0, &dmares); > if (ret) { > dev_err(&pdev->dev, "unable to get DMA resource\n"); > + of_node_put(np); > goto free_netdev; > } > lp->dma_regs = devm_ioremap_resource(&pdev->dev, &dmares); > if (IS_ERR(lp->dma_regs)) { > dev_err(&pdev->dev, "could not map DMA regs\n"); > ret = PTR_ERR(lp->dma_regs); > + of_node_put(np); > goto free_netdev; > } How do you think about to move these put calls to an additional jump target for the desired exception handling? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/xilinx/xilinx_axienet_main.c?id=fa3a419d2f674b431d38748cb58fb7da17ee8949#n1621 Regards, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel