From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v1 3/3] drm/tegra: dc: Silence RGB output deferred-probe error Date: Thu, 12 Mar 2020 17:03:56 +0300 Message-ID: References: <20200308223809.23549-1-digetx@gmail.com> <20200308223809.23549-3-digetx@gmail.com> <20200312093353.GB1199023@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200312093353.GB1199023@ulmo> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 12.03.2020 12:33, Thierry Reding пишет: > On Mon, Mar 09, 2020 at 01:38:09AM +0300, Dmitry Osipenko wrote: >> Driver fails to probe with -EPROBE_DEFER if display output isn't ready >> yet. This produces a bit noisy error message in KMSG during kernel's boot >> up on Tegra20 and Tegra30 because RGB output tends to be probed earlier >> than a corresponding voltage regulator driver. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/gpu/drm/tegra/dc.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c >> index 56d933e81797..d7f2c4654b6b 100644 >> --- a/drivers/gpu/drm/tegra/dc.c >> +++ b/drivers/gpu/drm/tegra/dc.c >> @@ -2571,7 +2571,11 @@ static int tegra_dc_probe(struct platform_device *pdev) >> >> err = tegra_dc_rgb_probe(dc); >> if (err < 0 && err != -ENODEV) { >> - dev_err(&pdev->dev, "failed to probe RGB output: %d\n", err); >> + if (err == -EPROBE_DEFER) >> + dev_dbg(&pdev->dev, "RGB output probe deferred\n"); >> + else >> + dev_err(&pdev->dev, "failed to probe RGB output: %d\n", >> + err); >> return err; >> } > > I'd prefer if we had just a single message and only differentiate on the > kernel message level, something more along these lines: > > if (err < 0 && err != -ENODEV) { > const char *level = KERN_ERR; > > if (err == -EPROBE_DEFER) > level = KERN_DEBUG; > > dev_printk(level, dc->dev, "failed to probe RGB output: %d\n", > err); > return err; > } > > Do you mind if I squash that into your patch? I don't mind, thanks :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83548C10DCE for ; Fri, 13 Mar 2020 08:00:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56317206E2 for ; Fri, 13 Mar 2020 08:00:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aYkSLnFF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56317206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 065986E283; Fri, 13 Mar 2020 08:00:37 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AE226E201 for ; Thu, 12 Mar 2020 14:03:59 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id g12so6586500ljj.3 for ; Thu, 12 Mar 2020 07:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qKTaqDytagD0O2wTlbTJF0/J9uHzNIR8oj4ra9daOM8=; b=aYkSLnFFgjnfOwrnv1bkZJXAllGNQlS1h6LL+vuczIMAuxlDl2vzOZOZLFaJOF0RYU ZnfUwBXFh7vUDzXX4pN6iG9h2dRbP7yHFjQxx4Mjr6894lhMr5dOVGhZ9ja/envyBRJL BNC9Dx3ZqJYdAYEfAUoT0ZwrMvEPT1Z5DBDAeoZfXldt3Ghez4olv5UyazN5BIXANt8C svsL/tnDl+SXMh7nyyDc3FID0Ze7xXuv2Ql5USUaHgHtiLvetPqSXJqtqyH8/qL1yQCu WZsP7G5juEDROdknu2q0lZc8MugXUtk8335LKZWhGwRgmkd4oZlorV1YYEqHb/Q2kPLm WKfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qKTaqDytagD0O2wTlbTJF0/J9uHzNIR8oj4ra9daOM8=; b=Vm3gnplSD6i8mobLHWyGF3vfw6yLgeDS2exeZOwnAoCtjQ26Yxa9QqMdwIgPP44ybB g/b3/UAtdMaH/d2GMa0FIwt4K3d+RxZs0fJw1vJISO06ZJMK/h3G9iJXxk9FVHRZwhS3 wfY+/pKZegDQn4GVQ6aEOkHG1S3mzh8ud58JgTbEJ3dGWQQzecQ7edpPYrbQpK8GBVGQ 8/F7gmXF+tzTnoqjy4uNWDpQjK6iTTRlI8FoTEhcr+UqLUpZqmGoxHM3Jvwr3YFjpD3j PqdrYwld0Jjvet4VMueVH0+XfiMq3wccxsG7ku3XacapwT4FSndfP0rXF50vOyu7i4/y TrKg== X-Gm-Message-State: ANhLgQ0bdr1IWmEJyQwwPIaNfiXTtfEXqTU4iBb5Y5z5IQ7DNgyI5vd+ dJfXZnF4DGpIONilgejUnag= X-Google-Smtp-Source: ADFU+vvCITbN/jgqfAHTW4GEJzjWjtUzEGnY8Gksa/EjYHKp9ufrbjJ1E03okV+xVPt7OOVh9jI1dA== X-Received: by 2002:a2e:9ac5:: with SMTP id p5mr5386486ljj.200.1584021837662; Thu, 12 Mar 2020 07:03:57 -0700 (PDT) Received: from [192.168.2.145] (94-29-39-224.dynamic.spd-mgts.ru. [94.29.39.224]) by smtp.googlemail.com with ESMTPSA id c22sm21261599lfi.41.2020.03.12.07.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2020 07:03:57 -0700 (PDT) Subject: Re: [PATCH v1 3/3] drm/tegra: dc: Silence RGB output deferred-probe error To: Thierry Reding References: <20200308223809.23549-1-digetx@gmail.com> <20200308223809.23549-3-digetx@gmail.com> <20200312093353.GB1199023@ulmo> From: Dmitry Osipenko Message-ID: Date: Thu, 12 Mar 2020 17:03:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200312093353.GB1199023@ulmo> Content-Language: en-US X-Mailman-Approved-At: Fri, 13 Mar 2020 08:00:36 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MTIuMDMuMjAyMCAxMjozMywgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKPiBPbiBNb24sIE1h ciAwOSwgMjAyMCBhdCAwMTozODowOUFNICswMzAwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+ IERyaXZlciBmYWlscyB0byBwcm9iZSB3aXRoIC1FUFJPQkVfREVGRVIgaWYgZGlzcGxheSBvdXRw dXQgaXNuJ3QgcmVhZHkKPj4geWV0LiBUaGlzIHByb2R1Y2VzIGEgYml0IG5vaXN5IGVycm9yIG1l c3NhZ2UgaW4gS01TRyBkdXJpbmcga2VybmVsJ3MgYm9vdAo+PiB1cCBvbiBUZWdyYTIwIGFuZCBU ZWdyYTMwIGJlY2F1c2UgUkdCIG91dHB1dCB0ZW5kcyB0byBiZSBwcm9iZWQgZWFybGllcgo+PiB0 aGFuIGEgY29ycmVzcG9uZGluZyB2b2x0YWdlIHJlZ3VsYXRvciBkcml2ZXIuCj4+Cj4+IFNpZ25l ZC1vZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPj4gLS0tCj4+ICBk cml2ZXJzL2dwdS9kcm0vdGVncmEvZGMuYyB8IDYgKysrKystCj4+ICAxIGZpbGUgY2hhbmdlZCwg NSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vdGVncmEvZGMuYyBiL2RyaXZlcnMvZ3B1L2RybS90ZWdyYS9kYy5jCj4+IGluZGV4 IDU2ZDkzM2U4MTc5Ny4uZDdmMmM0NjU0YjZiIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vdGVncmEvZGMuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdGVncmEvZGMuYwo+PiBAQCAt MjU3MSw3ICsyNTcxLDExIEBAIHN0YXRpYyBpbnQgdGVncmFfZGNfcHJvYmUoc3RydWN0IHBsYXRm b3JtX2RldmljZSAqcGRldikKPj4gIAo+PiAgCWVyciA9IHRlZ3JhX2RjX3JnYl9wcm9iZShkYyk7 Cj4+ICAJaWYgKGVyciA8IDAgJiYgZXJyICE9IC1FTk9ERVYpIHsKPj4gLQkJZGV2X2VycigmcGRl di0+ZGV2LCAiZmFpbGVkIHRvIHByb2JlIFJHQiBvdXRwdXQ6ICVkXG4iLCBlcnIpOwo+PiArCQlp ZiAoZXJyID09IC1FUFJPQkVfREVGRVIpCj4+ICsJCQlkZXZfZGJnKCZwZGV2LT5kZXYsICJSR0Ig b3V0cHV0IHByb2JlIGRlZmVycmVkXG4iKTsKPj4gKwkJZWxzZQo+PiArCQkJZGV2X2VycigmcGRl di0+ZGV2LCAiZmFpbGVkIHRvIHByb2JlIFJHQiBvdXRwdXQ6ICVkXG4iLAo+PiArCQkJCWVycik7 Cj4+ICAJCXJldHVybiBlcnI7Cj4+ICAJfQo+IAo+IEknZCBwcmVmZXIgaWYgd2UgaGFkIGp1c3Qg YSBzaW5nbGUgbWVzc2FnZSBhbmQgb25seSBkaWZmZXJlbnRpYXRlIG9uIHRoZQo+IGtlcm5lbCBt ZXNzYWdlIGxldmVsLCBzb21ldGhpbmcgbW9yZSBhbG9uZyB0aGVzZSBsaW5lczoKPiAKPiAJaWYg KGVyciA8IDAgJiYgZXJyICE9IC1FTk9ERVYpIHsKPiAJCWNvbnN0IGNoYXIgKmxldmVsID0gS0VS Tl9FUlI7Cj4gCj4gCQlpZiAoZXJyID09IC1FUFJPQkVfREVGRVIpCj4gCQkJbGV2ZWwgPSBLRVJO X0RFQlVHOwo+IAo+IAkJZGV2X3ByaW50ayhsZXZlbCwgZGMtPmRldiwgImZhaWxlZCB0byBwcm9i ZSBSR0Igb3V0cHV0OiAlZFxuIiwKPiAJCQkgICBlcnIpOwo+IAkJcmV0dXJuIGVycjsKPiAJfQo+ IAo+IERvIHlvdSBtaW5kIGlmIEkgc3F1YXNoIHRoYXQgaW50byB5b3VyIHBhdGNoPwoKSSBkb24n dCBtaW5kLCB0aGFua3MgOikKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==