From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH] memory: fix segfault on rte_mem_virt2memseg() call with invalid addr Date: Fri, 1 Jun 2018 11:50:12 +0100 Message-ID: References: <1527859375-160704-1-git-send-email-dariuszx.stojaczyk@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Dariusz Stojaczyk , dev@dpdk.org Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 75F715689 for ; Fri, 1 Jun 2018 12:50:15 +0200 (CEST) In-Reply-To: <1527859375-160704-1-git-send-email-dariuszx.stojaczyk@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Jun-18 2:22 PM, Dariusz Stojaczyk wrote: > When trying to use it with an address that's not > managed by DPDK it would segfault due to a missing > check. The doc says this function returns either > a pointer or NULL, so let it do so. > > Change-Id: Ib292f148914e67054f5d7b664077f19cba7000e4 > Signed-off-by: Dariusz Stojaczyk > --- Generally speaking, if the commit is a bugfix, reference to the original commit that introduces the issue should be part of the commit message. See DPDK contribution guidelines [1] and "git fixline" [2]. [1] http://dpdk.org/doc/guides/contributing/patches.html [2] http://dpdk.org/dev Change-Id: is probably a leftover from Gerrit, this shouldn't be part of the commit message. On the substance of the patch itself: Acked-by: Anatoly Burakov -- Thanks, Anatoly