Re: [PATCH] drm: Set depth and bpp for XRGB4444 family formats

[Fabien DESSENNE <fabien.dessenne@st.com>]

On 08/10/2016 12:35 PM, Daniel Vetter wrote:
> On Wed, Aug 10, 2016 at 11:21:56AM +0200, Fabien Dessenne wrote:
>> These pixel formats are supported by format_check() from drm_crtc.c, so
>> provide there depth and bpp.
>>
>> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> Why?
At least for consistency between format_check() and drm_fb_get_bpp_depth().

> Who's going to use this?
For the time being, I can see 9 drivers that make more or less use of 
this format (amd, atmel-hlcdc, exynos, fsl-dcu, imx, omapdrm, radeon, 
rcar-du, sti).
In top of that I am working on a new driver that actually needs this 
format, and that does not work without this patch.
> -Daniel
>
>> ---
>>   drivers/gpu/drm/drm_fourcc.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
>> index 0645c85..aa8c909 100644
>> --- a/drivers/gpu/drm/drm_fourcc.c
>> +++ b/drivers/gpu/drm/drm_fourcc.c
>> @@ -80,6 +80,17 @@ void drm_fb_get_bpp_depth(uint32_t format, unsigned int *depth,
>>   		*depth = 8;
>>   		*bpp = 8;
>>   		break;
>> +	case DRM_FORMAT_XRGB4444:
>> +	case DRM_FORMAT_XBGR4444:
>> +	case DRM_FORMAT_RGBX4444:
>> +	case DRM_FORMAT_BGRX4444:
>> +	case DRM_FORMAT_ARGB4444:
>> +	case DRM_FORMAT_ABGR4444:
>> +	case DRM_FORMAT_RGBA4444:
>> +	case DRM_FORMAT_BGRA4444:
>> +		*depth = 12;
>> +		*bpp = 16;
>> +		break;
>>   	case DRM_FORMAT_XRGB1555:
>>   	case DRM_FORMAT_XBGR1555:
>>   	case DRM_FORMAT_RGBX5551:
>> -- 
>> 1.9.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel