All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pádraig Brady" <P@draigBrady.com>
To: J William Piggott <elseifthen@gmx.com>, Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [V3 PULL] hwclock: remove date(1)
Date: Sat, 4 Mar 2017 17:12:47 -0800	[thread overview]
Message-ID: <d3087e72-f787-a7d0-6a2f-dfd0941a8ed9@draigBrady.com> (raw)
In-Reply-To: <a1415b5d-4046-3b34-5836-40ce1a835a41@gmx.com>

On 04/03/17 13:56, J William Piggott wrote:
> 
> Everyone,
>  Here's the latest branch for adding parse-date.
> 
> Karel,
> I have changed a few things since the last working branch I sent you.  I
> moved the API from parse-date.h to timeutils.h. Cleaned up the code some
> more and made more style conversion. Added documentation and fixed
> hwclock.8.in.
> 
> I've tested the parser pretty thoroughly now, including using odd input
> listed in bug fixes. It passed for all of them.
> 
> Here are examples of the problem related to the latest gnulib
> parse_datetime() commit; which was actually caused by changes in
> coreutils not gnulib.
> 
> BROKEN
> TZ="Europe/London" date -d 'TZ="Australia/Perth" 2016-08-15 07:00'
> Mon Aug 15 07:00:00 AWST 2016
> 
> CORRECT
> TZ="Europe/London" date -d 'TZ="Australia/Perth" 2016-08-15 07:00'
> Mon Aug 15 00:00:00 BST 2016

Sorry for jumping in here. Are you saying there are issues with
the current code in gnulib?

Note the TZ issue in date(1) was added in coreutils-8.26 with:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.25-15-gdf88fce
That was fixed with a minimal fix in coreutils-8.26 in Fedora.
coreutils-8.27 will be released in a few days with a different fix
that incorporated changes in parse_datetime in gnulib.

thanks,
Pádraig

  reply	other threads:[~2017-03-05  1:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-04 21:56 [V3 PULL] hwclock: remove date(1) J William Piggott
2017-03-05  1:12 ` Pádraig Brady [this message]
2017-03-05 14:09   ` J William Piggott
2017-03-14 13:17 ` Karel Zak
2017-03-23  0:43   ` J William Piggott
2017-03-23 11:41     ` Karel Zak
2017-03-23 14:37       ` J William Piggott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3087e72-f787-a7d0-6a2f-dfd0941a8ed9@draigBrady.com \
    --to=p@draigbrady.com \
    --cc=elseifthen@gmx.com \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.