From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Collin Walling <walling@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1] s390x/pci: Warn when adding PCI devices without the 'zpci' feature
Date: Tue, 22 Jan 2019 11:06:46 +0100 [thread overview]
Message-ID: <d31d1ba2-579a-eaa1-1e41-0745fd0291b9@redhat.com> (raw)
In-Reply-To: <cd0a559f-6a44-20b9-39ad-4368d08f79af@redhat.com>
On 22.01.19 10:50, Thomas Huth wrote:
> On 2019-01-22 10:41, David Hildenbrand wrote:
>> We decided to always create the PCI host bridge, even if 'zpci' is not
>> enabled (due to migration compatibility).
>
> Couldn't we disable the host bridge for newer machine types, and just
> create it on the old ones for migration compatibility?
I think we can with a compat property. However I somewhat dislike that
the error/warning will then be "no bus" vs. "zpci CPU feature not
enabled". Somebody who has no idea about that will think he somehow has
to create a PCI bus on the QEMU comandline.
... however
>
>> This however right now allows
>> to add zPCI/PCI devices to a VM although the guest will never actually see
>> them, confusing people that are using a simple CPU model that has no
>> 'zpci' enabled - "Why isn't this working" (David Hildenbrand)
>>
>> Let's check for 'zpci' and at least print a warning that this will not
>> work as expected. We could also bail out, however that might break
>> existing QEMU commandlines.
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>> hw/s390x/s390-pci-bus.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
>> index b86a8bdcd4..e7d4f49611 100644
>> --- a/hw/s390x/s390-pci-bus.c
>> +++ b/hw/s390x/s390-pci-bus.c
>> @@ -863,6 +863,11 @@ static void s390_pcihost_pre_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
>> {
>> S390pciState *s = S390_PCI_HOST_BRIDGE(hotplug_dev);
>>
>> + if (!s390_has_feat(S390_FEAT_ZPCI)) {
>> + warn_report("Adding PCI or zPCI devices without the 'zpci' CPU feature."
>> + " The guest will not be able to see/use these devices.");
>> + }
>
> I think it would be better to bail out. The hotplug clearly can not work
> in this case, and the warn report might go unnoticed, so blocking the
> hotplug process is likely better to get the attention of the user.
... we could also create the bus but bail out here in case the compat
property strikes (a.k.a. new QEMO machine type).
Thanks!
>
> Thomas
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-01-22 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 9:41 [Qemu-devel] [PATCH v1] s390x/pci: Warn when adding PCI devices without the 'zpci' feature David Hildenbrand
2019-01-22 9:50 ` Thomas Huth
2019-01-22 10:06 ` David Hildenbrand [this message]
2019-01-22 13:13 ` Cornelia Huck
2019-01-22 13:20 ` David Hildenbrand
2019-01-22 13:23 ` Cornelia Huck
2019-01-22 13:25 ` David Hildenbrand
2019-01-22 13:30 ` Cornelia Huck
2019-01-22 12:44 ` Cornelia Huck
2019-01-22 12:52 ` David Hildenbrand
2019-01-22 15:03 ` Christian Borntraeger
2019-01-22 15:11 ` David Hildenbrand
2019-01-24 14:56 ` Thomas Huth
2019-02-04 13:31 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2019-01-28 11:24 ` [Qemu-devel] " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d31d1ba2-579a-eaa1-1e41-0745fd0291b9@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.