From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76644C0044C for ; Mon, 29 Oct 2018 12:22:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46C112082B for ; Mon, 29 Oct 2018 12:22:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46C112082B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729209AbeJ2VLI (ORCPT ); Mon, 29 Oct 2018 17:11:08 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:39175 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729146AbeJ2VLI (ORCPT ); Mon, 29 Oct 2018 17:11:08 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 7D5E2464CC16B; Mon, 29 Oct 2018 20:22:36 +0800 (CST) Received: from [127.0.0.1] (10.142.63.192) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.408.0; Mon, 29 Oct 2018 20:22:29 +0800 CC: , , , , , , Greg Kroah-Hartman , Lucas Tsai , shufan_lee , John Stultz Subject: Re: [PATCH 08/10] usb: typec: Add support for usb role switch in rt1711h driver To: Heikki Krogerus References: <20181027095820.40056-1-chenyu56@huawei.com> <20181027095820.40056-9-chenyu56@huawei.com> <20181029115813.GA14534@kuha.fi.intel.com> From: Chen Yu Message-ID: Date: Mon, 29 Oct 2018 20:22:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20181029115813.GA14534@kuha.fi.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.142.63.192] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/10/29 19:58, Heikki Krogerus wrote: > On Sat, Oct 27, 2018 at 05:58:18PM +0800, Yu Chen wrote: >> This patch add struct device_connection to rt1711h driver to support >> find "usb-role-switch" in tcpm_register_port. >> >> Cc: Heikki Krogerus >> Cc: Greg Kroah-Hartman >> Cc: Lucas Tsai >> Cc: shufan_lee >> Cc: John Stultz >> Cc: Binghui Wang >> Signed-off-by: Yu Chen >> --- >> drivers/usb/typec/tcpm/tcpci_rt1711h.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c >> index 017389021b96..5f8b952612fe 100644 >> --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c >> +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c >> @@ -39,6 +39,7 @@ struct rt1711h_chip { >> struct tcpci_data data; >> struct tcpci *tcpci; >> struct device *dev; >> + struct device_connection dev_conn; >> }; >> >> static int rt1711h_read16(struct rt1711h_chip *chip, unsigned int reg, u16 *val) >> @@ -237,6 +238,7 @@ static int rt1711h_probe(struct i2c_client *client, >> { >> int ret; >> struct rt1711h_chip *chip; >> + const char *dev_conn_end; >> >> ret = rt1711h_check_revision(client); >> if (ret < 0) { >> @@ -254,6 +256,7 @@ static int rt1711h_probe(struct i2c_client *client, >> return PTR_ERR(chip->data.regmap); >> >> chip->dev = &client->dev; >> + dev_set_name(chip->dev, "rt1711h"); >> i2c_set_clientdata(client, chip); >> >> ret = rt1711h_sw_reset(chip); >> @@ -264,6 +267,15 @@ static int rt1711h_probe(struct i2c_client *client, >> if (ret < 0) >> return ret; >> >> + ret = device_property_read_string(chip->dev, "dev-conn-end", >> + &dev_conn_end); >> + if (!ret) { >> + chip->dev_conn.endpoint[0] = "rt1711h"; >> + chip->dev_conn.endpoint[1] = dev_conn_end; >> + chip->dev_conn.id = "usb-role-switch"; >> + device_connection_add(&chip->dev_conn); >> + } > That is wrong. You should not read name of a device from a property. > > Regardless of that, I don't think this patch is needed at all. You > need to describe this kind connection with OF device graph > (Documentation/devicetree/bindings/graph.txt). > > I've prepared a proposal how we should be able handle graphs in the > device connection API: > https://lkml.org/lkml/2018/10/24/613 I will fix this patch. Thanks! > > thanks, > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Yu Subject: Re: [PATCH 08/10] usb: typec: Add support for usb role switch in rt1711h driver Date: Mon, 29 Oct 2018 20:22:27 +0800 Message-ID: References: <20181027095820.40056-1-chenyu56@huawei.com> <20181027095820.40056-9-chenyu56@huawei.com> <20181029115813.GA14534@kuha.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181029115813.GA14534@kuha.fi.intel.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Heikki Krogerus Cc: wangbinghui@hisilicon.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, Greg Kroah-Hartman , Lucas Tsai , shufan_lee , John Stultz List-Id: devicetree@vger.kernel.org On 2018/10/29 19:58, Heikki Krogerus wrote: > On Sat, Oct 27, 2018 at 05:58:18PM +0800, Yu Chen wrote: >> This patch add struct device_connection to rt1711h driver to support >> find "usb-role-switch" in tcpm_register_port. >> >> Cc: Heikki Krogerus >> Cc: Greg Kroah-Hartman >> Cc: Lucas Tsai >> Cc: shufan_lee >> Cc: John Stultz >> Cc: Binghui Wang >> Signed-off-by: Yu Chen >> --- >> drivers/usb/typec/tcpm/tcpci_rt1711h.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c >> index 017389021b96..5f8b952612fe 100644 >> --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c >> +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c >> @@ -39,6 +39,7 @@ struct rt1711h_chip { >> struct tcpci_data data; >> struct tcpci *tcpci; >> struct device *dev; >> + struct device_connection dev_conn; >> }; >> >> static int rt1711h_read16(struct rt1711h_chip *chip, unsigned int reg, u16 *val) >> @@ -237,6 +238,7 @@ static int rt1711h_probe(struct i2c_client *client, >> { >> int ret; >> struct rt1711h_chip *chip; >> + const char *dev_conn_end; >> >> ret = rt1711h_check_revision(client); >> if (ret < 0) { >> @@ -254,6 +256,7 @@ static int rt1711h_probe(struct i2c_client *client, >> return PTR_ERR(chip->data.regmap); >> >> chip->dev = &client->dev; >> + dev_set_name(chip->dev, "rt1711h"); >> i2c_set_clientdata(client, chip); >> >> ret = rt1711h_sw_reset(chip); >> @@ -264,6 +267,15 @@ static int rt1711h_probe(struct i2c_client *client, >> if (ret < 0) >> return ret; >> >> + ret = device_property_read_string(chip->dev, "dev-conn-end", >> + &dev_conn_end); >> + if (!ret) { >> + chip->dev_conn.endpoint[0] = "rt1711h"; >> + chip->dev_conn.endpoint[1] = dev_conn_end; >> + chip->dev_conn.id = "usb-role-switch"; >> + device_connection_add(&chip->dev_conn); >> + } > That is wrong. You should not read name of a device from a property. > > Regardless of that, I don't think this patch is needed at all. You > need to describe this kind connection with OF device graph > (Documentation/devicetree/bindings/graph.txt). > > I've prepared a proposal how we should be able handle graphs in the > device connection API: > https://lkml.org/lkml/2018/10/24/613 I will fix this patch. Thanks! > > thanks, > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [08/10] usb: typec: Add support for usb role switch in rt1711h driver From: Yu Chen Message-Id: Date: Mon, 29 Oct 2018 20:22:27 +0800 To: Heikki Krogerus Cc: wangbinghui@hisilicon.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, Greg Kroah-Hartman , Lucas Tsai , shufan_lee , John Stultz List-ID: T24gMjAxOC8xMC8yOSAxOTo1OCwgSGVpa2tpIEtyb2dlcnVzIHdyb3RlOgo+IE9uIFNhdCwgT2N0 IDI3LCAyMDE4IGF0IDA1OjU4OjE4UE0gKzA4MDAsIFl1IENoZW4gd3JvdGU6Cj4+IFRoaXMgcGF0 Y2ggYWRkIHN0cnVjdCBkZXZpY2VfY29ubmVjdGlvbiB0byBydDE3MTFoIGRyaXZlciB0byBzdXBw b3J0Cj4+IGZpbmQgInVzYi1yb2xlLXN3aXRjaCIgaW4gdGNwbV9yZWdpc3Rlcl9wb3J0Lgo+Pgo+ PiBDYzogSGVpa2tpIEtyb2dlcnVzIDxoZWlra2kua3JvZ2VydXNAbGludXguaW50ZWwuY29tPgo+ PiBDYzogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPj4g Q2M6IEx1Y2FzIFRzYWkgPGx1Y2FzX3RzYWlAcmljaHRlay5jb20+Cj4+IENjOiBzaHVmYW5fbGVl IDxzaHVmYW5fbGVlQHJpY2h0ZWsuY29tPgo+PiBDYzogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6 QGxpbmFyby5vcmc+Cj4+IENjOiBCaW5naHVpIFdhbmcgPHdhbmdiaW5naHVpQGhpc2lsaWNvbi5j b20+Cj4+IFNpZ25lZC1vZmYtYnk6IFl1IENoZW4gPGNoZW55dTU2QGh1YXdlaS5jb20+Cj4+IC0t LQo+PiAgZHJpdmVycy91c2IvdHlwZWMvdGNwbS90Y3BjaV9ydDE3MTFoLmMgfCAxNSArKysrKysr KysrKysrKysKPj4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3VzYi90eXBlYy90Y3BtL3RjcGNpX3J0MTcxMWguYyBiL2RyaXZlcnMv dXNiL3R5cGVjL3RjcG0vdGNwY2lfcnQxNzExaC5jCj4+IGluZGV4IDAxNzM4OTAyMWI5Ni4uNWY4 Yjk1MjYxMmZlIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL3VzYi90eXBlYy90Y3BtL3RjcGNpX3J0 MTcxMWguYwo+PiArKysgYi9kcml2ZXJzL3VzYi90eXBlYy90Y3BtL3RjcGNpX3J0MTcxMWguYwo+ PiBAQCAtMzksNiArMzksNyBAQCBzdHJ1Y3QgcnQxNzExaF9jaGlwIHsKPj4gIAlzdHJ1Y3QgdGNw Y2lfZGF0YSBkYXRhOwo+PiAgCXN0cnVjdCB0Y3BjaSAqdGNwY2k7Cj4+ICAJc3RydWN0IGRldmlj ZSAqZGV2Owo+PiArCXN0cnVjdCBkZXZpY2VfY29ubmVjdGlvbiBkZXZfY29ubjsKPj4gIH07Cj4+ ICAKPj4gIHN0YXRpYyBpbnQgcnQxNzExaF9yZWFkMTYoc3RydWN0IHJ0MTcxMWhfY2hpcCAqY2hp cCwgdW5zaWduZWQgaW50IHJlZywgdTE2ICp2YWwpCj4+IEBAIC0yMzcsNiArMjM4LDcgQEAgc3Rh dGljIGludCBydDE3MTFoX3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCj4+ICB7Cj4+ ICAJaW50IHJldDsKPj4gIAlzdHJ1Y3QgcnQxNzExaF9jaGlwICpjaGlwOwo+PiArCWNvbnN0IGNo YXIgKmRldl9jb25uX2VuZDsKPj4gIAo+PiAgCXJldCA9IHJ0MTcxMWhfY2hlY2tfcmV2aXNpb24o Y2xpZW50KTsKPj4gIAlpZiAocmV0IDwgMCkgewo+PiBAQCAtMjU0LDYgKzI1Niw3IEBAIHN0YXRp YyBpbnQgcnQxNzExaF9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LAo+PiAgCQlyZXR1 cm4gUFRSX0VSUihjaGlwLT5kYXRhLnJlZ21hcCk7Cj4+ICAKPj4gIAljaGlwLT5kZXYgPSAmY2xp ZW50LT5kZXY7Cj4+ICsJZGV2X3NldF9uYW1lKGNoaXAtPmRldiwgInJ0MTcxMWgiKTsKPj4gIAlp MmNfc2V0X2NsaWVudGRhdGEoY2xpZW50LCBjaGlwKTsKPj4gIAo+PiAgCXJldCA9IHJ0MTcxMWhf c3dfcmVzZXQoY2hpcCk7Cj4+IEBAIC0yNjQsNiArMjY3LDE1IEBAIHN0YXRpYyBpbnQgcnQxNzEx aF9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LAo+PiAgCWlmIChyZXQgPCAwKQo+PiAg CQlyZXR1cm4gcmV0Owo+PiAgCj4+ICsJcmV0ID0gZGV2aWNlX3Byb3BlcnR5X3JlYWRfc3RyaW5n KGNoaXAtPmRldiwgImRldi1jb25uLWVuZCIsCj4+ICsJCQkmZGV2X2Nvbm5fZW5kKTsKPj4gKwlp ZiAoIXJldCkgewo+PiArCQljaGlwLT5kZXZfY29ubi5lbmRwb2ludFswXSA9ICJydDE3MTFoIjsK Pj4gKwkJY2hpcC0+ZGV2X2Nvbm4uZW5kcG9pbnRbMV0gPSBkZXZfY29ubl9lbmQ7Cj4+ICsJCWNo aXAtPmRldl9jb25uLmlkID0gInVzYi1yb2xlLXN3aXRjaCI7Cj4+ICsJCWRldmljZV9jb25uZWN0 aW9uX2FkZCgmY2hpcC0+ZGV2X2Nvbm4pOwo+PiArCX0KPiBUaGF0IGlzIHdyb25nLiBZb3Ugc2hv dWxkIG5vdCByZWFkIG5hbWUgb2YgYSBkZXZpY2UgZnJvbSBhIHByb3BlcnR5Lgo+Cj4gUmVnYXJk bGVzcyBvZiB0aGF0LCBJIGRvbid0IHRoaW5rIHRoaXMgcGF0Y2ggaXMgbmVlZGVkIGF0IGFsbC4g WW91Cj4gbmVlZCB0byBkZXNjcmliZSB0aGlzIGtpbmQgY29ubmVjdGlvbiB3aXRoIE9GIGRldmlj ZSBncmFwaAo+IChEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZ3JhcGgudHh0KS4K Pgo+IEkndmUgcHJlcGFyZWQgYSBwcm9wb3NhbCBob3cgd2Ugc2hvdWxkIGJlIGFibGUgaGFuZGxl IGdyYXBocyBpbiB0aGUKPiBkZXZpY2UgY29ubmVjdGlvbiBBUEk6Cj4gaHR0cHM6Ly9sa21sLm9y Zy9sa21sLzIwMTgvMTAvMjQvNjEzCkkgd2lsbCBmaXggdGhpcyBwYXRjaC4gVGhhbmtzIQo+Cj4g dGhhbmtzLAo+Cg==