* [PATCH] nl80211: fix a mistake in grammar
@ 2021-06-09 8:15 13145886936
2021-06-09 8:55 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: 13145886936 @ 2021-06-09 8:15 UTC (permalink / raw)
To: johannes, davem, kuba; +Cc: linux-wireless, netdev, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
Fix a mistake in grammar.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
net/wireless/nl80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index fc9286afe3c9..68dff0ca3190 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -8128,7 +8128,7 @@ int nl80211_parse_random_mac(struct nlattr **attrs,
memcpy(mac_addr, nla_data(attrs[NL80211_ATTR_MAC]), ETH_ALEN);
memcpy(mac_addr_mask, nla_data(attrs[NL80211_ATTR_MAC_MASK]), ETH_ALEN);
- /* don't allow or configure an mcast address */
+ /* don't allow or configure a mcast address */
if (!is_multicast_ether_addr(mac_addr_mask) ||
is_multicast_ether_addr(mac_addr))
return -EINVAL;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nl80211: fix a mistake in grammar
2021-06-09 8:15 [PATCH] nl80211: fix a mistake in grammar 13145886936
@ 2021-06-09 8:55 ` Johannes Berg
2021-06-09 15:01 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2021-06-09 8:55 UTC (permalink / raw)
To: 13145886936, davem, kuba
Cc: linux-wireless, netdev, linux-kernel, gushengxian
On Wed, 2021-06-09 at 01:15 -0700, 13145886936@163.com wrote:
>
> - /* don't allow or configure an mcast address */
> + /* don't allow or configure a mcast address */
Arguable? I'd say "an M-cast" address, and I guess that's why it's
written that way. Not sure how else you'd say it, unless you always
expand it to "multicast" when reading.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nl80211: fix a mistake in grammar
2021-06-09 8:55 ` Johannes Berg
@ 2021-06-09 15:01 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-06-09 15:01 UTC (permalink / raw)
To: Johannes Berg, 13145886936, davem, kuba
Cc: linux-wireless, netdev, linux-kernel, gushengxian
On 6/9/21 1:55 AM, Johannes Berg wrote:
> On Wed, 2021-06-09 at 01:15 -0700, 13145886936@163.com wrote:
>>
>> - /* don't allow or configure an mcast address */
>> + /* don't allow or configure a mcast address */
>
> Arguable? I'd say "an M-cast" address, and I guess that's why it's
> written that way. Not sure how else you'd say it, unless you always
> expand it to "multicast" when reading.
Agreed, it's ok as is.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-09 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 8:15 [PATCH] nl80211: fix a mistake in grammar 13145886936
2021-06-09 8:55 ` Johannes Berg
2021-06-09 15:01 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.