From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56D2C48B7; Fri, 18 Feb 2022 09:59:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F5D2C340E9; Fri, 18 Feb 2022 09:59:42 +0000 (UTC) Message-ID: Date: Fri, 18 Feb 2022 10:59:41 +0100 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [RFC v2 0/8] Move HEVC stateless controls out of staging Content-Language: en-US To: Benjamin Gaignard , mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, jonas@kwiboo.se, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com, jc@kynesim.co.uk References: <20220215110103.241297-1-benjamin.gaignard@collabora.com> From: Hans Verkuil In-Reply-To: <20220215110103.241297-1-benjamin.gaignard@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Benjamin, On 15/02/2022 12:00, Benjamin Gaignard wrote: > This series aims to make HEVC uapi stable and usable for hardware > decoder. HEVC uapi is used by 2 mainlined drivers (Cedrus and Hantro) > and 2 out of the tree drivers (rkvdec and RPI). > > The 3 first patches are from Hans to implement v4l2 dynamic control > feature which is need by patch 7 for V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET > definition. > > Patch 4 move the existing uapi to stable, including definitions renaming > and CID number change to fit with v4l2 naming. > > Patches 5 and 7 add fields needed for rkvdec and RPI decoders. > > Patches 6 is cleaning up the uapi of useless field. > Patches 8 change one field description and name to define offset by > bytes rather than by bits I have some housekeeping questions: I have several older HEVC-related patches from you, which of those are still valid? "[v4,0/9] Additional features for Hantro HEVC": https://patchwork.linuxtv.org/project/linux-media/cover/20210625141143.577998-1-benjamin.gaignard@collabora.com/ "media: hevc: fix pictures lists type": https://patchwork.linuxtv.org/project/linux-media/patch/20210823082949.237716-1-benjamin.gaignard@collabora.com/ "media: hantro: Trace hevc hw cycles performance register": https://patchwork.linuxtv.org/project/linux-media/patch/20210823135606.633052-1-benjamin.gaignard@collabora.com/ "media: hantro: Add support of compressed reference buffers" https://patchwork.linuxtv.org/project/linux-media/patch/20210823162916.824336-1-benjamin.gaignard@collabora.com/ Before moving the HEVC API out of staging I would prefer to have any remaining issues fixed. So one series that adds any remaining fixes (i.e. from the older patches mentioned above), and a second series on top that moves it out of staging. That way I can mark the older patches as Superseded, and we have a fresh series that we can discuss. Regards, Hans > > Benjamin > > Benjamin Gaignard (5): > media: uapi: Move HEVC stateless controls out of staging > media: uapi: Add fields needed for RKVDEC driver > media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params > media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET control > media: uapi: Change data_bit_offset definition > > Hans Verkuil (3): > videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY > v4l2-ctrls: add support for dynamically allocated arrays. > vivid: add dynamic array test control > > .../userspace-api/media/drivers/hantro.rst | 5 - > .../media/v4l/ext-ctrls-codec.rst | 58 ++-- > .../media/v4l/vidioc-queryctrl.rst | 8 + > .../media/test-drivers/vivid/vivid-ctrls.c | 15 ++ > drivers/media/v4l2-core/v4l2-ctrls-api.c | 103 ++++++-- > drivers/media/v4l2-core/v4l2-ctrls-core.c | 182 ++++++++++--- > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 32 +-- > drivers/media/v4l2-core/v4l2-ctrls-priv.h | 3 +- > drivers/media/v4l2-core/v4l2-ctrls-request.c | 13 +- > drivers/staging/media/hantro/hantro_drv.c | 27 +- > drivers/staging/media/hantro/hantro_hevc.c | 8 +- > drivers/staging/media/sunxi/cedrus/cedrus.c | 24 +- > .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +- > .../staging/media/sunxi/cedrus/cedrus_h265.c | 13 +- > include/linux/hantro-media.h | 17 ++ > include/media/hevc-ctrls.h | 250 ------------------ > include/media/v4l2-ctrls.h | 48 +++- > include/uapi/linux/v4l2-controls.h | 224 ++++++++++++++++ > include/uapi/linux/videodev2.h | 8 + > 19 files changed, 640 insertions(+), 408 deletions(-) > create mode 100644 include/linux/hantro-media.h > delete mode 100644 include/media/hevc-ctrls.h > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6041CC433EF for ; Fri, 18 Feb 2022 10:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XVAQyiwd9g7z4UtSKBUTROnMvK6Wi7y2WdDHrGIsgdk=; b=TjECrxjsShvryu SyrLqBjWz8oh0QWvOB17ZScQh64VbYK+zabCxmG8P5GLtn20YN92SfkGyuRQ/PtM/N3Zw5Ce4o16W ffYl0q/tzROd0ZD+7atFp3KkH+okAnYV4mx5aCsxggMHaPmNSC/SAz1OmAdxcWJ5jdyaz6aOvaXCw i6YBlVNj2o01bUt3oqdtNzNSG5fRw74cEmbVDaXat4AZxw9yLwA+lJ7rpcDQVNFSkTm2K4ivYVKUc X4IXqz+uocIJq54BaobwlwvIziwVhc0eG02aeEe1VqXrcKMLnDVtDfeaKQHPPsjh4OUY8gM8qMT13 5KgQWYJhHnXoLmTOYNEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nL03N-00Di1L-A7; Fri, 18 Feb 2022 09:59:53 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nL03I-00Dhzq-K1 for linux-arm-kernel@lists.infradead.org; Fri, 18 Feb 2022 09:59:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2E22DB825B2; Fri, 18 Feb 2022 09:59:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F5D2C340E9; Fri, 18 Feb 2022 09:59:42 +0000 (UTC) Message-ID: Date: Fri, 18 Feb 2022 10:59:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [RFC v2 0/8] Move HEVC stateless controls out of staging Content-Language: en-US To: Benjamin Gaignard , mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, jonas@kwiboo.se, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com, jc@kynesim.co.uk References: <20220215110103.241297-1-benjamin.gaignard@collabora.com> From: Hans Verkuil In-Reply-To: <20220215110103.241297-1-benjamin.gaignard@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220218_015948_991412_96ADD473 X-CRM114-Status: GOOD ( 21.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Benjamin, On 15/02/2022 12:00, Benjamin Gaignard wrote: > This series aims to make HEVC uapi stable and usable for hardware > decoder. HEVC uapi is used by 2 mainlined drivers (Cedrus and Hantro) > and 2 out of the tree drivers (rkvdec and RPI). > > The 3 first patches are from Hans to implement v4l2 dynamic control > feature which is need by patch 7 for V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET > definition. > > Patch 4 move the existing uapi to stable, including definitions renaming > and CID number change to fit with v4l2 naming. > > Patches 5 and 7 add fields needed for rkvdec and RPI decoders. > > Patches 6 is cleaning up the uapi of useless field. > Patches 8 change one field description and name to define offset by > bytes rather than by bits I have some housekeeping questions: I have several older HEVC-related patches from you, which of those are still valid? "[v4,0/9] Additional features for Hantro HEVC": https://patchwork.linuxtv.org/project/linux-media/cover/20210625141143.577998-1-benjamin.gaignard@collabora.com/ "media: hevc: fix pictures lists type": https://patchwork.linuxtv.org/project/linux-media/patch/20210823082949.237716-1-benjamin.gaignard@collabora.com/ "media: hantro: Trace hevc hw cycles performance register": https://patchwork.linuxtv.org/project/linux-media/patch/20210823135606.633052-1-benjamin.gaignard@collabora.com/ "media: hantro: Add support of compressed reference buffers" https://patchwork.linuxtv.org/project/linux-media/patch/20210823162916.824336-1-benjamin.gaignard@collabora.com/ Before moving the HEVC API out of staging I would prefer to have any remaining issues fixed. So one series that adds any remaining fixes (i.e. from the older patches mentioned above), and a second series on top that moves it out of staging. That way I can mark the older patches as Superseded, and we have a fresh series that we can discuss. Regards, Hans > > Benjamin > > Benjamin Gaignard (5): > media: uapi: Move HEVC stateless controls out of staging > media: uapi: Add fields needed for RKVDEC driver > media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params > media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET control > media: uapi: Change data_bit_offset definition > > Hans Verkuil (3): > videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY > v4l2-ctrls: add support for dynamically allocated arrays. > vivid: add dynamic array test control > > .../userspace-api/media/drivers/hantro.rst | 5 - > .../media/v4l/ext-ctrls-codec.rst | 58 ++-- > .../media/v4l/vidioc-queryctrl.rst | 8 + > .../media/test-drivers/vivid/vivid-ctrls.c | 15 ++ > drivers/media/v4l2-core/v4l2-ctrls-api.c | 103 ++++++-- > drivers/media/v4l2-core/v4l2-ctrls-core.c | 182 ++++++++++--- > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 32 +-- > drivers/media/v4l2-core/v4l2-ctrls-priv.h | 3 +- > drivers/media/v4l2-core/v4l2-ctrls-request.c | 13 +- > drivers/staging/media/hantro/hantro_drv.c | 27 +- > drivers/staging/media/hantro/hantro_hevc.c | 8 +- > drivers/staging/media/sunxi/cedrus/cedrus.c | 24 +- > .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +- > .../staging/media/sunxi/cedrus/cedrus_h265.c | 13 +- > include/linux/hantro-media.h | 17 ++ > include/media/hevc-ctrls.h | 250 ------------------ > include/media/v4l2-ctrls.h | 48 +++- > include/uapi/linux/v4l2-controls.h | 224 ++++++++++++++++ > include/uapi/linux/videodev2.h | 8 + > 19 files changed, 640 insertions(+), 408 deletions(-) > create mode 100644 include/linux/hantro-media.h > delete mode 100644 include/media/hevc-ctrls.h > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel