From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24BF0C433E6 for ; Sun, 7 Mar 2021 11:37:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC1D965109 for ; Sun, 7 Mar 2021 11:37:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230149AbhCGLgd (ORCPT ); Sun, 7 Mar 2021 06:36:33 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:49516 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbhCGLgS (ORCPT ); Sun, 7 Mar 2021 06:36:18 -0500 Received: from mail-ed1-f72.google.com ([209.85.208.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lIrgX-0001pK-8B for linux-kernel@vger.kernel.org; Sun, 07 Mar 2021 11:34:57 +0000 Received: by mail-ed1-f72.google.com with SMTP id r19so3166520edv.3 for ; Sun, 07 Mar 2021 03:34:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Op5mu56rLKVeXZ5BYHLLFs3XBf2gdeKehd8++u/6LDA=; b=Ae1lyzG7wcREDsqaVx/+1xFnP933KjMpUUR1Vc6JCs7FSI1wzK2cKDxJ3e837RfuLw 8av/qQIjI/eFatGeEDURnwNNJvjWa20eOLnduQlM4+mFvXGx1OTSfW0Ie8Fqt487DE6z A3sYP7aWRWjVYlT2knPTScfWvGb0h/j4Oq8pro5OoQropPdqwC0/zqsZ6PI3aFhDvDe5 OgRahP5dc6zAQIlE6eWJ8gjwlMoWZGKdsEGMP9KlYIGMMlA6bTejitqW3jthSpv1dbJ0 edpiJCIxhF/xs98+ie3sMVvC0d605plqvQoRUJUobDa0Kz2CHT0G5De1SPB9atT55XXv yGuw== X-Gm-Message-State: AOAM532oKo/p+yKzqM8sEw7nw6RPqU39TlEFD45Z4DsvNTT+UppT46kw PTt1sW9ghtl5uxrzAV/ECn3yFnI+Ibd/L8XFyZhTFt6x+qLDWAG/ReYp2GENeABcNfdJ9scYCYE H5IsaHsdThOqsT0Y83AO5/GrEbkxw+lXXiCUEoi5QwQ== X-Received: by 2002:a50:fa04:: with SMTP id b4mr17812458edq.293.1615116896809; Sun, 07 Mar 2021 03:34:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwN50SNAvRJvyv1TTGSoHps9ZM3d2RwZosjPBjKJrezHq2PpQu4f0MDG5tTUROmsW8Jne4o4A== X-Received: by 2002:a50:fa04:: with SMTP id b4mr17812435edq.293.1615116896694; Sun, 07 Mar 2021 03:34:56 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id g25sm5016167edp.95.2021.03.07.03.34.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Mar 2021 03:34:56 -0800 (PST) Subject: Re: [RFT PATCH v3 21/27] tty: serial: samsung_tty: IRQ rework To: Hector Martin , Andy Shevchenko Cc: linux-arm Mailing List , Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree , "open list:SERIAL DRIVERS" , Linux Documentation List , Linux Samsung SOC , Linux-Arch , Linux Kernel Mailing List References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-22-marcan@marcan.st> <535ff48e-160e-4ba4-23ac-54e478a2f3ee@marcan.st> <05ccc09f-ffea-71cd-4288-beed3020bd45@marcan.st> From: Krzysztof Kozlowski Message-ID: Date: Sun, 7 Mar 2021 12:34:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <05ccc09f-ffea-71cd-4288-beed3020bd45@marcan.st> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2021 17:29, Hector Martin wrote: > On 06/03/2021 01.20, Andy Shevchenko wrote: >>> I am just splitting an >>> existing function into two, where one takes the lock and the other does >>> the work. Do you mean using a different locking function? I'm not >>> entirely sure what you're suggesting. >> >> Yes, as a prerequisite >> >> spin_lock_irqsave -> spin_lock(). > > Krzysztof, is this something you want in this series? I was trying to > avoid logic changes to the non-Apple paths. I don't quite get the need for such change (the code will be still called in interrupt handler, right?), but assuming the "why?" is properly documented, it can be a separate patch here. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB121C433DB for ; Sun, 7 Mar 2021 11:37:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A61964E40 for ; Sun, 7 Mar 2021 11:37:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A61964E40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RZDOmLHClX9FXP8F+YPPAM1oUCBKkIDWSHffHA76VpU=; b=gLiK+/ahzpAPKJROdGmY5TE1h fdroSBDxXDCFFFJomZj56vjz9bjN6QuRKL0tRwCfTm4vwsXepNJa3cFhrut1jgkTNWcnIeGiwZxmM kS2o64arBB/cxcM0FM33FLN9hw2QGpoklGQhxg/8ke/pfFL6DM7dY+zeq3VZzOJQoi+kQTo7YUulx Z6tWdeGJsGt/IhN5iIgN1TcVvdANThJCq3CDRKp4b8IE+qJgbz37+G0oTldI5Y2OB7rXJQ11SxmUH QjIbQ2fEp1Vfvqtg9cXapPk3jhfVlpFxSIDxcrZE+2amaXRupGtxLmPsHKATU1lmqwG1xtfNmWrdJ MTGNV+84g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIrgd-009r6Y-Pp; Sun, 07 Mar 2021 11:35:03 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIrgY-009r52-Oj for linux-arm-kernel@lists.infradead.org; Sun, 07 Mar 2021 11:35:00 +0000 Received: from mail-ed1-f71.google.com ([209.85.208.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lIrgX-0001pA-40 for linux-arm-kernel@lists.infradead.org; Sun, 07 Mar 2021 11:34:57 +0000 Received: by mail-ed1-f71.google.com with SMTP id t27so3576199edi.2 for ; Sun, 07 Mar 2021 03:34:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Op5mu56rLKVeXZ5BYHLLFs3XBf2gdeKehd8++u/6LDA=; b=QzulnT/93dIdFRYa9g4/I/xOpRsmczTaP7ocb9Iz5wj2zuO0yEfeJD6549aCHyawQR LPyt40AWKEREMzQw823UUmXZA/Rmgv/4VgNWeJ6qwaW87qDOGgNAJVMVzCcypNbIu5MX AignglmvBFJrUTTH/Xz6Xgo8i9bS1ORWQP2lHEbsQ6FteMujTJ4pNUMwrWJQq2uWVhIf gcnkK7YDejGJnXlocyQ7v/jhf4EVonXsmKKNMk1J3OvhNstvhgDp2GJMYDPWqNameUIo vhCpFLh1qwI1sJ8CGFdz+KI4FkA9NsHD49pNPmAzEC8MGfAEie9x5d/9snXUyZOh9qb4 s2tQ== X-Gm-Message-State: AOAM533+c7E01HFkcMMnjzoXR0wQb8eWo22jZiZPplGk+F5gZPnaNPSj 5vkjLNPtP5qYbBL1W5IJ170q+wQIj6Z84cVOOr+VPynKwjH6d/IQoYgt6i7mA24c8L59ZTbzP6p ZPYcWrRQtwNbWN6NRDjOTM7xMeM/bEz/2DwUkd2lrOAY1C41WM/7c X-Received: by 2002:a50:fa04:: with SMTP id b4mr17812452edq.293.1615116896808; Sun, 07 Mar 2021 03:34:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwN50SNAvRJvyv1TTGSoHps9ZM3d2RwZosjPBjKJrezHq2PpQu4f0MDG5tTUROmsW8Jne4o4A== X-Received: by 2002:a50:fa04:: with SMTP id b4mr17812435edq.293.1615116896694; Sun, 07 Mar 2021 03:34:56 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id g25sm5016167edp.95.2021.03.07.03.34.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Mar 2021 03:34:56 -0800 (PST) Subject: Re: [RFT PATCH v3 21/27] tty: serial: samsung_tty: IRQ rework To: Hector Martin , Andy Shevchenko Cc: linux-arm Mailing List , Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree , "open list:SERIAL DRIVERS" , Linux Documentation List , Linux Samsung SOC , Linux-Arch , Linux Kernel Mailing List References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-22-marcan@marcan.st> <535ff48e-160e-4ba4-23ac-54e478a2f3ee@marcan.st> <05ccc09f-ffea-71cd-4288-beed3020bd45@marcan.st> From: Krzysztof Kozlowski Message-ID: Date: Sun, 7 Mar 2021 12:34:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <05ccc09f-ffea-71cd-4288-beed3020bd45@marcan.st> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210307_113458_927253_7007922B X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/03/2021 17:29, Hector Martin wrote: > On 06/03/2021 01.20, Andy Shevchenko wrote: >>> I am just splitting an >>> existing function into two, where one takes the lock and the other does >>> the work. Do you mean using a different locking function? I'm not >>> entirely sure what you're suggesting. >> >> Yes, as a prerequisite >> >> spin_lock_irqsave -> spin_lock(). > > Krzysztof, is this something you want in this series? I was trying to > avoid logic changes to the non-Apple paths. I don't quite get the need for such change (the code will be still called in interrupt handler, right?), but assuming the "why?" is properly documented, it can be a separate patch here. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel