All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rix <trix@redhat.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
	ndesaulniers@google.com, ricky_wu@realtek.com,
	kai.heng.feng@canonical.com, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH] misc: rtsx: Set setting_reg2 before use.
Date: Mon, 16 May 2022 10:06:06 -0700	[thread overview]
Message-ID: <d34498ad-0230-7c73-8f1f-9ca59fbf930f@redhat.com> (raw)
In-Reply-To: <YoJ0I/XPoj1B/+mm@dev-arch.thelio-3990X>


On 5/16/22 8:56 AM, Nathan Chancellor wrote:
> On Mon, May 16, 2022 at 09:00:47AM -0400, Tom Rix wrote:
>> The clang build fails with
>> rts5261.c:406:13: error: variable 'setting_reg2' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>>          } else if (efuse_valid == 0) {
>>                     ^~~~~~~~~~~~~~~~
>>
>> setting_reg2 is set in this block
>>    if (efuse_valid == 2 || efuse_valid == 3) {
>> ..
>>    } else if (efuse_valid == 0) {
>>      // default
>> ..
>>    }
>> But efuse_valid can also have a value of 1.
>> Change the 'else if' to 'else' to make the second block the default.
>>
>> Fixes: b1c5f3085149 ("misc: rtsx: add rts5261 efuse function")
>> Signed-off-by: Tom Rix <trix@redhat.com>
> I am not sure if this fix is correct from a functional standpoint (i.e.
> is treating efuse_valid == 1 the same as efuse_valid == 0 correct?) but
> it is better than not handling this value altogether. For what it's
> worth:

I looked at how the code used to work, this seemed better than 
initializing to NULL.

>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> As a side note, it is unfortunate that this change made it into -next
> when there was an outstanding report about this warning:

 From the clang side, this is a build break and my static analysis infra 
goes down.

These build breaks seem to happening every week, is there a precommit 
clang gating test that could be done for -next ?

Tom

>
> https://lore.kernel.org/202205100220.WyAyhKap-lkp@intel.com/
>
>> ---
>>   drivers/misc/cardreader/rts5261.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c
>> index 749cc5a46d13..f22634b14dc8 100644
>> --- a/drivers/misc/cardreader/rts5261.c
>> +++ b/drivers/misc/cardreader/rts5261.c
>> @@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr)
>>   			setting_reg1 = PCR_SETTING_REG4;
>>   			setting_reg2 = PCR_SETTING_REG5;
>>   		}
>> -	} else if (efuse_valid == 0) {
>> +	} else {
>>   		// default
>>   		setting_reg1 = PCR_SETTING_REG1;
>>   		setting_reg2 = PCR_SETTING_REG2;
>> -- 
>> 2.27.0
>>
> Cheers,
> Nathan
>


  reply	other threads:[~2022-05-16 17:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 13:00 [PATCH] misc: rtsx: Set setting_reg2 before use Tom Rix
2022-05-16 15:56 ` Nathan Chancellor
2022-05-16 17:06   ` Tom Rix [this message]
2022-05-16 21:22     ` Nick Desaulniers
2022-05-16 21:57       ` Nathan Chancellor
2022-05-17  1:53     ` Kai-Heng Feng
2022-05-17  8:10       ` Ricky WU
2022-05-19 20:57         ` Nathan Chancellor
2022-05-19 21:18           ` Tom Rix
2022-05-19 21:24             ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d34498ad-0230-7c73-8f1f-9ca59fbf930f@redhat.com \
    --to=trix@redhat.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=ricky_wu@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.