From: "Rafał Miłecki" <rafal@milecki.pl>
To: "Florian Fainelli" <f.fainelli@gmail.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB
Date: Mon, 14 Dec 2020 09:00:25 +0100 [thread overview]
Message-ID: <d3461875-cdbc-9fde-3ef3-7a7ba478d88a@milecki.pl> (raw)
In-Reply-To: <4d0bea20-1a3b-24d1-2d27-96f2f4fd48b9@gmail.com>
On 12.12.2020 04:26, Florian Fainelli wrote:
>> +
>> +static const struct bcm_pmb_pd_data bcm_pmb_bcm4908_data[] = {
>> + { .name = "pcie2", .id = BCM_PMB_PCIE2, .bus = 0, .device = 2, },
>> + { .name = "pcie0", .id = BCM_PMB_PCIE0, .bus = 1, .device = 14, },
>> + { .name = "pcie1", .id = BCM_PMB_PCIE1, .bus = 1, .device = 15, },
>> + { .name = "usb", .id = BCM_PMB_HOST_USB, .bus = 1, .device = 17, },
>
> Do you have to be more specific and spell out whether this is the host
> controller (xhci) or device (bdc)? If not, then this looks good to me.
I believe I have to and I believe I already do. I used BCM_PMB_HOST_USB
which clearly (I believe) points to the HOST controller.
In 6838 part of pmc_drv.h from Broadcom's SDK I found:
enum {
USB30_2X_Zone_Common,
USB30_2X_Zone_USB_Host,
USB30_2X_Zone_USB_Device,
};
and that's what makes me believe we need to specify HOST explicitly.
prev parent reply other threads:[~2020-12-14 11:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 21:59 [PATCH 0/2] Broadcom's PMB (Power Management Bus) support Rafał Miłecki
2020-12-11 21:59 ` [PATCH 1/2] dt-bindings: power: document Broadcom's PMB binding Rafał Miłecki
2020-12-11 21:59 ` [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB Rafał Miłecki
2020-12-11 22:02 ` Rafał Miłecki
2020-12-11 22:08 ` Florian Fainelli
2020-12-11 22:10 ` Rafał Miłecki
2020-12-14 12:24 ` Rafał Miłecki
2020-12-14 17:32 ` Florian Fainelli
2020-12-14 17:34 ` Rafał Miłecki
2020-12-12 3:26 ` Florian Fainelli
2020-12-14 8:00 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3461875-cdbc-9fde-3ef3-7a7ba478d88a@milecki.pl \
--to=rafal@milecki.pl \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.