From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A95C433EF for ; Thu, 30 Sep 2021 15:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BCA361267 for ; Thu, 30 Sep 2021 15:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346571AbhI3Pxd (ORCPT ); Thu, 30 Sep 2021 11:53:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:39432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346501AbhI3Pxc (ORCPT ); Thu, 30 Sep 2021 11:53:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9E6B66120D; Thu, 30 Sep 2021 15:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633017110; bh=FWQpFZPZBLpdmTrrwsbPqNU5OTmgWjPWJZMzALECrJc=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=AuVtTU/f9thasFp2vN5QBbvZNV2GJ+MhaZ3qs5j1IRRuwP6BMiINBhrdOaHazPWFB BYpDiTaFJryPX9Wct1XN58ZrRHvCZpClrMuICrjQp0sPuzEyv1Y8XKZrzMvd/Oh8tM kItNkco0yR/7fOBmzPLwsBf18TBnRgGFWN5F5TxANR3NuYAUXCLa3qL8C/rXVcC0FK gU2UsHs8GPYXjfo4xOZEvt2iHLZJXOV4Iw60hQJ5krJ+rL+WB0cA2NN/sHkStCE9xF YGlPrDdaI8atyqeaGflz6OyNwZocNmhu8SGHP5ZJFRc/TrlyvJrL72BbDn+IXVddVi elidoLRVNfewg== Message-ID: Subject: Re: [PATCH 3/5] drm/vc4: hdmi: Set a default HSM rate From: nicolas saenz julienne To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Florian Fainelli , Michael Stapelberg , Linus Torvalds Date: Thu, 30 Sep 2021 17:51:45 +0200 In-Reply-To: <20210922125419.4125779-4-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-4-maxime@cerno.tech> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote: > When the firmware doesn't setup the HSM rate (such as when booting > without an HDMI cable plugged in), its rate is 0 and thus any register > access results in a CPU stall, even though HSM is enabled. > > Let's enforce a minimum rate at boot to avoid this issue. > > Fixes: 4f6e3d66ac52 ("drm/vc4: Add runtime PM support to the HDMI encoder driver") > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Regards, Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD01C433EF for ; Thu, 30 Sep 2021 15:54:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A51D61411 for ; Thu, 30 Sep 2021 15:54:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5A51D61411 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zC+Sl6uTXAotBvf6RqPvxE2lcDO9mbOrV1oUjN9rTiI=; b=nBjqnGS+rUnVjU QdRSoBbwCURIRmbT/CiXpS29K+dOQ1YMWKZC65fmv2ShhKlholnjwpSyOTiEHjjMK4fyzzX5oPRGV tswyq2gu/ARSyBEYSFCJFKHbV1OHEQmeG2YmlQHyPTovsres2yZ1kwd+H/A/ROAAr3tTVzWTnMpmC 9633rEgCBw30aooMbdg8//K8lcZDonDKUyGv3FTIPQ1yMVnq3f3GQySr7NcvNnQztWM4h2Iq0yI6P pc3oGbLugRFjYByy2MNHsqA02gfcV92jboKZzvQPk6Hi/WPFtZLPDxDMTqL5HOS01YM6Q+tTPOIhf 4VcNhwNtSLWQyaZOqbnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVyLh-00F1HA-I4; Thu, 30 Sep 2021 15:51:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVyLe-00F1GY-HL; Thu, 30 Sep 2021 15:51:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9E6B66120D; Thu, 30 Sep 2021 15:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633017110; bh=FWQpFZPZBLpdmTrrwsbPqNU5OTmgWjPWJZMzALECrJc=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=AuVtTU/f9thasFp2vN5QBbvZNV2GJ+MhaZ3qs5j1IRRuwP6BMiINBhrdOaHazPWFB BYpDiTaFJryPX9Wct1XN58ZrRHvCZpClrMuICrjQp0sPuzEyv1Y8XKZrzMvd/Oh8tM kItNkco0yR/7fOBmzPLwsBf18TBnRgGFWN5F5TxANR3NuYAUXCLa3qL8C/rXVcC0FK gU2UsHs8GPYXjfo4xOZEvt2iHLZJXOV4Iw60hQJ5krJ+rL+WB0cA2NN/sHkStCE9xF YGlPrDdaI8atyqeaGflz6OyNwZocNmhu8SGHP5ZJFRc/TrlyvJrL72BbDn+IXVddVi elidoLRVNfewg== Message-ID: Subject: Re: [PATCH 3/5] drm/vc4: hdmi: Set a default HSM rate From: nicolas saenz julienne To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Florian Fainelli , Michael Stapelberg , Linus Torvalds Date: Thu, 30 Sep 2021 17:51:45 +0200 In-Reply-To: <20210922125419.4125779-4-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-4-maxime@cerno.tech> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_085150_619220_72957766 X-CRM114-Status: UNSURE ( 9.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote: > When the firmware doesn't setup the HSM rate (such as when booting > without an HDMI cable plugged in), its rate is 0 and thus any register > access results in a CPU stall, even though HSM is enabled. > > Let's enforce a minimum rate at boot to avoid this issue. > > Fixes: 4f6e3d66ac52 ("drm/vc4: Add runtime PM support to the HDMI encoder driver") > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Regards, Nicolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel