Re: [PATCH] drm/amd/powerply: fix power reading on Fiji

[Eric Huang <jinhuieric.huang-5C7GfCeVMHo@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 4640 bytes --]

Right. This is only for Fiji. We should use PPSMC_MSG_GetCurrPkgPwr on 
poaris.


Thanks,

Eric


On 2018-03-29 03:54 PM, Deucher, Alexander wrote:
>
> Thanks. Patch is:
>
> Acked-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
>
> Care to make a patch to use PPSMC_MSG_GetCurrPkgPwr on polaris boards 
> so we don't have to worry about the delay on them?
>
>
> Alex
>
> ------------------------------------------------------------------------
> *From:* Huang, JinHuiEric
> *Sent:* Thursday, March 29, 2018 3:40:22 PM
> *To:* Deucher, Alexander; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> *Subject:* Re: [PATCH] drm/amd/powerply: fix power reading on Fiji
>
> This reading method is shared with AGT tool only on Fiji, because SMU 
> FW doesn't support PPSMC_MSG_GetCurrPkgPwr message on Fiji. But since 
> polaris10, PPSMC_MSG_GetCurrPkgPwr has been supported. We also use 
> PPSMC_MSG_GetCurrPkgPwr on vega which SMU FW control sampling period. 
> Driver will not care about it.
>
>
> Eric
>
>
> On 2018-03-29 03:31 PM, Deucher, Alexander wrote:
>>
>> Do you know what the sampling period is on vega?  We should try and 
>> be consistent.  How about making this selectable via hwmon:
>>
>> power[1-*]_average_interval	Power use averaging interval.  A poll
>> 				notification is sent to this file if the
>> 				hardware changes the averaging interval.
>> 				Unit: milliseconds
>> 				RW
>>
>> power[1-*]_average_interval_max	Maximum power use averaging interval
>> 				Unit: milliseconds
>> 				RO
>>
>> power[1-*]_average_interval_min	Minimum power use averaging interval
>> 				Unit: milliseconds
>> 				RO
>>
>>
>> Then the user can select the interval they want.
>>
>>
>> Alex
>>
>> ------------------------------------------------------------------------
>> *From:* amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> 
>> <mailto:amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Eric 
>> Huang <JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org> <mailto:JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org>
>> *Sent:* Thursday, March 29, 2018 3:21:52 PM
>> *To:* amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org 
>> <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
>> *Cc:* Huang, JinHuiEric
>> *Subject:* [PATCH] drm/amd/powerply: fix power reading on Fiji
>> Power value is wrong reported by customer. It is a regression by
>>
>> commit a7c7bc4c0c47eaac77b8fa92f0672032df7f4254
>> Author: Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org> <mailto:Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
>> Date:   Mon Mar 27 15:32:59 2017 +0800
>>
>>     drm/amd/powerplay: reduce sample period time
>>
>>     for power readings.
>>
>>     Signed-off-by: Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org> <mailto:Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
>>     Reviewed-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org> 
>> <mailto:alexander.deucher-5C7GfCeVMHo@public.gmane.org>
>>     Signed-off-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org> 
>> <mailto:alexander.deucher-5C7GfCeVMHo@public.gmane.org>
>>
>> The theoretical sampling period is from 50ms to 4sec, original 2sec
>> is long but correct, and 20ms is too short. change it to more
>> reasonable 200ms.
>>
>> Signed-off-by: Eric Huang <JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org> 
>> <mailto:JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org>
>> ---
>>  drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c 
>> b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
>> index a03b7fe..7631d80 100644
>> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
>> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
>> @@ -3377,7 +3377,8 @@ static int smu7_get_gpu_power(struct pp_hwmgr 
>> *hwmgr,
>>                          "Failed to start pm status log!",
>>                          return -1);
>>
>> -       msleep_interruptible(20);
>> +       /* Sampling period from 50ms to 4sec */
>> +       msleep_interruptible(200);
>>
>> PP_ASSERT_WITH_CODE(!smum_send_msg_to_smc(hwmgr,
>>                          PPSMC_MSG_PmStatusLogSample),
>> -- 
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>


[-- Attachment #1.2: Type: text/html, Size: 9947 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx