From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47D16ECAAD5 for ; Mon, 12 Sep 2022 08:47:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9A54C84A26; Mon, 12 Sep 2022 10:47:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1662972443; bh=S7ObU8zJYUQcFOe0g+1MRcREq2b7uzV1eqnWwk1Ai+0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=OhH69PIFArPqq12w+xCH6q7zFg5/IdPV4hB/Asoa3ffhMkxmXnaF4h5v0jEwz0/Ie k5NolZmMu/huBRVmcna37F1VwAZomnzwjFowhIWayVCXF7v/Oy5CfxFFrsGzBmOK5Y h5CSokE6C9NWbFAVs/hK5EfsIHDOAedIuyd/pjheWWfvORB2KBNQsF+7LPQJxktrVB 4Iuy6VlSA9+DJ4Uj7R4yrrts02o3r7N8JlfJC6ItLyMPR32ZVmZdY8E5evfNFOMfXq Jpvp84aRR+5TL5B4afEHzWtRe04qzhI6+mMFSCg8sONQV+qG1gAS0QIfxVfdPi157Y md2/huC11Axog== Received: from [192.168.1.107] (82-131-156-25.pool.digikabel.hu [82.131.156.25]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hs@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id A81BA84A2C; Mon, 12 Sep 2022 10:47:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1662972439; bh=S7ObU8zJYUQcFOe0g+1MRcREq2b7uzV1eqnWwk1Ai+0=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=0D0zOCqdxiDiLKVOCWP+V3FjwZQsXBZeQoVL1PqRqp4aAE6GNgwSdbBqdiWb8VBcL qHilYMWFsU2Z0ZyoHlUWmAusNPYAhr1Fl5pM47AWYdeskYQ1v/D+b3aJnRMvs/cFt/ hOdcPWWMd8GFmiPKckdeNpJUtdf1BffISTZoPEqNv1mZnL+taegGhxKdHMgRKYq6EB xORf4iQuQmQ+J2oeu1SQN/sevQQL4PjRrj949isobK6KCaoORrCz6+1qZEOn5c4gn/ De9fxwxi8QAlc5Z9TkHK7IAL+Ai3QgLLCl3MCzOhPiFJFvtAgc20Hz6U/qPdObWVa5 HQNPoskuBA72Q== Subject: Re: [PATCH v4 1/4] i2c: stm32: fix comment and remove unused AUTOEND bit To: Alain Volmat , uboot-stm32@st-md-mailman.stormreply.com, u-boot@lists.denx.de Cc: patrice.chotard@foss.st.com, patrick.delaunay@foss.st.com, jorge@foundries.io, oleksandr.suvorov@foundries.io References: <20220912084201.1826979-1-alain.volmat@foss.st.com> <20220912084201.1826979-2-alain.volmat@foss.st.com> From: Heiko Schocher Message-ID: Date: Mon, 12 Sep 2022 10:47:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220912084201.1826979-2-alain.volmat@foss.st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hs@denx.de Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hello Alain, On 12.09.22 10:41, Alain Volmat wrote: > Comment within stm32_i2c_message_start is misleading, indicating > that AUTOEND bit is setted while it is actually cleared. > Moreover, the bit is actually never setted so there is no need > to clear it hence get rid of this bit clear and the bit macro > as well. > > Signed-off-by: Alain Volmat > Reviewed-by: Patrick Delaunay > --- > drivers/i2c/stm32f7_i2c.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de