From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314AbdHBSv5 (ORCPT ); Wed, 2 Aug 2017 14:51:57 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:39147 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbdHBSvz (ORCPT ); Wed, 2 Aug 2017 14:51:55 -0400 Subject: Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access To: David Lechner , dri-devel@lists.freedesktop.org Cc: David Airlie , linux-kernel@vger.kernel.org References: <1501618466-32191-1-git-send-email-david@lechnology.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Wed, 2 Aug 2017 20:51:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501618466-32191-1-git-send-email-david@lechnology.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 01.08.2017 22.14, skrev David Lechner: > If we return here and import_attach is true, then dma_buf_end_cpu_access() > will not be called balance dma_buf_begin_cpu_access(). > > Fix by setting ret instead of returning. > > Signed-off-by: David Lechner > --- Reviewed-by: Noralf Trønnes > drivers/gpu/drm/tinydrm/mipi-dbi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c > index c83eeb7..e10fa4b 100644 > --- a/drivers/gpu/drm/tinydrm/mipi-dbi.c > +++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c > @@ -183,7 +183,8 @@ static int mipi_dbi_buf_copy(void *dst, struct drm_framebuffer *fb, > dev_err_once(fb->dev->dev, "Format is not supported: %s\n", > drm_get_format_name(fb->format->format, > &format_name)); > - return -EINVAL; > + ret = -EINVAL; > + break; > } > > if (import_attach) From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access Date: Wed, 2 Aug 2017 20:51:37 +0200 Message-ID: References: <1501618466-32191-1-git-send-email-david@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D40589DBA for ; Wed, 2 Aug 2017 18:51:56 +0000 (UTC) In-Reply-To: <1501618466-32191-1-git-send-email-david@lechnology.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Lechner , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org CkRlbiAwMS4wOC4yMDE3IDIyLjE0LCBza3JldiBEYXZpZCBMZWNobmVyOgo+IElmIHdlIHJldHVy biBoZXJlIGFuZCBpbXBvcnRfYXR0YWNoIGlzIHRydWUsIHRoZW4gZG1hX2J1Zl9lbmRfY3B1X2Fj Y2VzcygpCj4gd2lsbCBub3QgYmUgY2FsbGVkIGJhbGFuY2UgZG1hX2J1Zl9iZWdpbl9jcHVfYWNj ZXNzKCkuCj4KPiBGaXggYnkgc2V0dGluZyByZXQgaW5zdGVhZCBvZiByZXR1cm5pbmcuCj4KPiBT aWduZWQtb2ZmLWJ5OiBEYXZpZCBMZWNobmVyIDxkYXZpZEBsZWNobm9sb2d5LmNvbT4KPiAtLS0K ClJldmlld2VkLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KCj4gICBk cml2ZXJzL2dwdS9kcm0vdGlueWRybS9taXBpLWRiaS5jIHwgMyArKy0KPiAgIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vdGlueWRybS9taXBpLWRiaS5jIGIvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0v bWlwaS1kYmkuYwo+IGluZGV4IGM4M2VlYjcuLmUxMGZhNGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL3Rpbnlkcm0vbWlwaS1kYmkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS90aW55 ZHJtL21pcGktZGJpLmMKPiBAQCAtMTgzLDcgKzE4Myw4IEBAIHN0YXRpYyBpbnQgbWlwaV9kYmlf YnVmX2NvcHkodm9pZCAqZHN0LCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiAgIAkJZGV2 X2Vycl9vbmNlKGZiLT5kZXYtPmRldiwgIkZvcm1hdCBpcyBub3Qgc3VwcG9ydGVkOiAlc1xuIiwK PiAgIAkJCSAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShmYi0+Zm9ybWF0LT5mb3JtYXQsCj4gICAJ CQkJCQkgJmZvcm1hdF9uYW1lKSk7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwkJcmV0ID0gLUVJ TlZBTDsKPiArCQlicmVhazsKPiAgIAl9Cj4gICAKPiAgIAlpZiAoaW1wb3J0X2F0dGFjaCkKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=