From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46D7CC433F5 for ; Tue, 15 Mar 2022 15:46:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0C4768399B; Tue, 15 Mar 2022 16:46:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=puri.sm Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A150583BF1; Tue, 15 Mar 2022 16:46:18 +0100 (CET) Received: from comms.puri.sm (comms.puri.sm [159.203.221.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 102DA8309E for ; Tue, 15 Mar 2022 16:46:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=puri.sm Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus.ainslie@puri.sm Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 203FADFD87; Tue, 15 Mar 2022 08:46:13 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HGeVNUtvTq-Y; Tue, 15 Mar 2022 08:46:12 -0700 (PDT) Message-ID: Date: Tue, 15 Mar 2022 08:46:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Heiko Thiery , Angus Ainslie Cc: u-boot@lists.denx.de, Marek Vasut , lukma@denx.de, seanga2@gmail.com, sbabic@denx.de, festevam@gmail.com, kernel@puri.sm, uboot-imx@nxp.com, peng.fan@nxp.com References: <20220315130820.1054186-1-angus@akkea.ca> <20220315130820.1054186-3-angus@akkea.ca> From: Angus Ainslie Subject: Re: [PATCH v4 2/4] clk: imx8mq: Add a clock driver for the imx8mq In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.39 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Heiko, On 2022-03-15 08:35, Heiko Thiery wrote: > Hi Angus and all, > > > > > Am Di., 15. März 2022 um 14:09 Uhr schrieb Angus Ainslie : > > This is a DM clock driver based off the imx8mm u-boot driver and > the linux > kernel driver. > > All of the PLLs and clocks are initialized so the subsystems below are > functional and tested. > > 1) USB host and peripheral > 2) ECSPI > 3) UART > 4) I2C all busses > 5) USDHC for eMMC support > 6) USB storage > 7) GPIO > 8) DRAM > > Snip > > when adding this patch and enabling CLK_IMX8MQ I see the following on > my board .. Any idea what I missed here? > > --- >8 --- > U-Boot SPL 2022.04-rc4-00008-g390d9bf9a1 (Mar 15 2022 - 16:26:59 +0100) > Trying to boot from SD card > > > U-Boot 2022.04-rc4-00008-g390d9bf9a1 (Mar 15 2022 - 16:26:59 +0100) > > CPU:   Freescale i.MX8MQ rev2.1 at 800 MHz > Reset cause: POR > Model: Kontron pITX-imx8m > DRAM:  alloc space exhausted > alloc space exhausted > alloc space exhausted > alloc space exhausted > alloc space exhausted > alloc space exhausted > alloc space exhausted > alloc space exhausted > alloc space exhausted > alloc space exhausted > alloc space exhausted > alloc space exhausted > 4 GiB My guess is that there was static code that was setting up the DRAM pll that isn't get executed now that there's a DM clock driver. I'd try enabling DEBUG in the clk-uclass and clk-composite drivers. Also look at what DRAM initialization code is not being run now. Our board doesn't have an DRAM specific initialization so there could be a bug in the DRAM setup. > clk_register: failed to get device (parent of ckil) > clk_register: failed to get device (parent of sys1_pll) > clk_register: failed to get device (parent of sys2_pll) > clk_register: failed to get device (parent of sys3_pll) These are warnings and shouldn't affect the functioning of the driver. > No serial driver found Are you using the DM serial driver ? Again this is not something that is running on our board. But I can try enabling it. Thanks Angus > resetting ... > > --- >8 --- > > -- > Heiko