From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BDBEC433E2 for ; Fri, 17 Jul 2020 18:20:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31AB4206F4 for ; Fri, 17 Jul 2020 18:20:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I2/IRW0w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31AB4206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwUyV-0004xG-Gc for qemu-devel@archiver.kernel.org; Fri, 17 Jul 2020 14:20:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwUxJ-0003sX-U8 for qemu-devel@nongnu.org; Fri, 17 Jul 2020 14:19:33 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:36668 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jwUxG-0003ze-Ll for qemu-devel@nongnu.org; Fri, 17 Jul 2020 14:19:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595009969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i3pl4yUwyQk1MQni83NnNYaatcSGz+oBwOsNmYVGYYY=; b=I2/IRW0wgp+KvTUsW5/6GuwJc5HDR5ndgt1GnbanSP/NwtIZShWHzxIA2cRYhJv1pqDH00 7zEaRiuh3TL7mlgx9fUznM47lGXDN/iDF2sV758avJHvHnAwufIvlZX6vYc0/qMaCtGMhn 3bwAodf9+3JBsiqrWH2qgyhM5XWfgd4= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-3b07xpm6PLmVrll2PfpPpQ-1; Fri, 17 Jul 2020 14:19:25 -0400 X-MC-Unique: 3b07xpm6PLmVrll2PfpPpQ-1 Received: by mail-ej1-f70.google.com with SMTP id a26so6285755ejr.7 for ; Fri, 17 Jul 2020 11:19:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=i3pl4yUwyQk1MQni83NnNYaatcSGz+oBwOsNmYVGYYY=; b=ZBaCvOnbHfZYab9UAZfXnvsxULnrDRMYpS832RE+vqPg5+IFx35vm8c8AC7PFOAJzt HVwGYFwkScaHeAxHmYc1jkRCPGXI4vyA0StmPVwhoO7aSaj7F4jU55q5BWdcWeTpj2+r 0tPHhAQU/RNri7sqA6qEvpgau+QTjxMTjzTmmbHSo3LdOIzTeQOW5RfxOHT0NrKg+9ha +4KUFK1CVxLkH7JwTtM0nligmERDiVulzE8hk6XuYNZ1e0sOwEZfkih4xJ/XbMKYmm/a Mk2ozRXGzt1JQxGcoJjJeEphtQ+WziZmfhFgbQ9H44NArxIUnVI+AgMcLcc0nOqJwe9G hsIQ== X-Gm-Message-State: AOAM531bmLeeLPb60O8i17Yl1kiWIOxBHQHa5+uQTCa641RC0pqPexQ6 mdvX4aG3CU9Ry/EHXzo3G1+04kwEtRqGUnzIguxFIOIiGXm/2JMtYUua4wDW681k2GqqUDGDBpY DT2wz2hKao33YjXc= X-Received: by 2002:a17:906:1f53:: with SMTP id d19mr9593920ejk.327.1595009964050; Fri, 17 Jul 2020 11:19:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRUY1UrErxzGz7D/Ae04nOgZxxmNMQVS5Sv6hZf7TbqJUPv3qlsFyGehXzPn4qjDJp/gvQcA== X-Received: by 2002:a17:906:1f53:: with SMTP id d19mr9593896ejk.327.1595009963833; Fri, 17 Jul 2020 11:19:23 -0700 (PDT) Received: from [192.168.1.37] (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id sa10sm8736243ejb.79.2020.07.17.11.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 11:19:23 -0700 (PDT) Subject: Re: [PATCH] target/i386: floatx80: avoid compound literals in static initializers To: qemu-devel@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20200716144251.23004-1-lersek@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Fri, 17 Jul 2020 20:19:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/17 01:33:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Aurelien Jarno , Paolo Bonzini , Laszlo Ersek , Joseph Myers , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/17/20 6:46 PM, Laszlo Ersek wrote: > On 07/17/20 11:26, Laszlo Ersek wrote: >> On 07/16/20 17:09, Philippe Mathieu-Daudé wrote: >>> On 7/16/20 4:42 PM, Laszlo Ersek wrote: >>>> Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an >>>> object that has static storage duration shall be constant expressions or >>>> string literals". >>>> >>>> The compound literal produced by the make_floatx80() macro is not such a >>>> constant expression, per 6.6p7-9. (An implementation may accept it, >>>> according to 6.6p10, but is not required to.) >>>> >>>> Therefore using "floatx80_zero" and make_floatx80() for initializing >>>> "f2xm1_table" and "fpatan_table" is not portable. And gcc-4.8 in RHEL-7.6 >>>> actually chokes on them: >>>> >>>>> target/i386/fpu_helper.c:871:5: error: initializer element is not constant >>>>> { make_floatx80(0xbfff, 0x8000000000000000ULL), >>>>> ^ >>> >>> This reminds me of: >>> >>> commit 6fa9ba09dbf4eb8b52bcb47d6820957f1b77ee0b >>> Author: Kamil Rytarowski >>> Date: Mon Sep 4 23:23:06 2017 +0200 >>> >>> target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init() >>> >>> GCC 4.7.2 on SunOS reports that the values assigned to array members >>> are not >>> real constants: >>> >>> target/m68k/fpu_helper.c:32:5: error: initializer element is not >>> constant >>> target/m68k/fpu_helper.c:32:5: error: (near initialization for >>> 'fpu_rom[0]') >>> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed >>> >>> Convert the array to make_floatx80_init() to fix it. >>> Replace floatx80_pi-like constants with make_floatx80_init() as they are >>> defined as make_floatx80(). >>> >>> Reviewed-by: Philippe Mathieu-Daudé >>> >>>> >>>> We've had the make_floatx80_init() macro for this purpose since commit >>>> 3bf7e40ab914 ("softfloat: fix for C99", 2012-03-17), so let's use that >>>> macro again. >>>> >>>> Fixes: eca30647fc07 >>>> Fixes: ff57bb7b6326 >>>> Link: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06566.html >>>> Link: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg04714.html >>>> Cc: Alex Bennée >>>> Cc: Aurelien Jarno >>>> Cc: Eduardo Habkost >>>> Cc: Joseph Myers >>>> Cc: Paolo Bonzini >>>> Cc: Peter Maydell >>>> Cc: Richard Henderson >>>> Signed-off-by: Laszlo Ersek >>>> --- >>>> >>>> Notes: >>>> I can see that there are test cases under "tests/tcg/i386", but I don't >>>> know how to run them. >>> >>> Yeah it is not easy to figure... >>> >>> Try 'make run-tcg-tests-i386-softmmu' >>> but you need docker :^) >> >> That worked, thanks! Even without Docker: I just had to add >> >> --cross-cc-i386=gcc >> >> to my ./configure flags. >> > > Also -- I meant to, but I forgot to put "for-5.1" in the subject prefix; > sorry about that. Alex, as Paolo is not available, can this go via your tree? > > Laszlo >