From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512AbdJ3NgW (ORCPT ); Mon, 30 Oct 2017 09:36:22 -0400 Received: from esa2.dell-outbound.iphmx.com ([68.232.149.220]:1713 "EHLO esa2.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477AbdJ3NgU (ORCPT ); Mon, 30 Oct 2017 09:36:20 -0400 From: X-LoopCount0: from 10.166.132.152 X-IronPort-AV: E=Sophos;i="5.44,320,1505797200"; d="scan'208";a="1051245698" X-DLP: DLP_GlobalPCIDSS To: CC: , , , , , , , , , , Subject: RE: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Thread-Topic: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Thread-Index: AQHTUXYbpufm8y/dNkC8FZIE88HgP6L8ZEow Date: Mon, 30 Oct 2017 13:36:16 +0000 Message-ID: References: <363404cf80b9060fca645b5e64bda8de75f59b56.1508515469.git.mario.limonciello@dell.com> <20171030115608.r2y7w33an47fkple@pali> In-Reply-To: <20171030115608.r2y7w33an47fkple@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9UDaQGj031737 > > Hint: you can move this check out of j-loop as condition is independent > of it. That's true, thanks. > > Also how many tokens are there? Is not quadratic solution too slow? > ~< 250 on most machines is what I've seen. To me that that's a small enough number that this is quick. It only happens at initialization. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: RE: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Date: Mon, 30 Oct 2017 13:36:16 +0000 Message-ID: References: <363404cf80b9060fca645b5e64bda8de75f59b56.1508515469.git.mario.limonciello@dell.com> <20171030115608.r2y7w33an47fkple@pali> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from esa2.dell-outbound.iphmx.com ([68.232.149.220]:1713 "EHLO esa2.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477AbdJ3NgU (ORCPT ); Mon, 30 Oct 2017 09:36:20 -0400 In-Reply-To: <20171030115608.r2y7w33an47fkple@pali> Content-Language: en-US Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: pali.rohar@gmail.com Cc: dvhart@infradead.org, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, luto@kernel.org, quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de, greg@kroah.com, gnomes@lxorguk.ukuu.org.uk PiANCj4gSGludDogeW91IGNhbiBtb3ZlIHRoaXMgY2hlY2sgb3V0IG9mIGotbG9vcCBhcyBjb25k aXRpb24gaXMgaW5kZXBlbmRlbnQNCj4gb2YgaXQuDQoNClRoYXQncyB0cnVlLCB0aGFua3MuDQoN Cj4gDQo+IEFsc28gaG93IG1hbnkgdG9rZW5zIGFyZSB0aGVyZT8gSXMgbm90IHF1YWRyYXRpYyBz b2x1dGlvbiB0b28gc2xvdz8NCj4gDQoNCn48IDI1MCBvbiBtb3N0IG1hY2hpbmVzIGlzIHdoYXQg SSd2ZSBzZWVuLiAgVG8gbWUgdGhhdCB0aGF0J3MgYSBzbWFsbA0KZW5vdWdoIG51bWJlciB0aGF0 IHRoaXMgaXMgcXVpY2suICBJdCBvbmx5IGhhcHBlbnMgYXQgaW5pdGlhbGl6YXRpb24uDQo=