All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: cfontana@suse.de, f4bug@amsat.org, ehabkost@redhat.com
Subject: Re: [PATCH v2 02/50] target/i386: Split out check_cpl0
Date: Tue, 18 May 2021 11:10:43 +0200	[thread overview]
Message-ID: <d3731dbd-a699-4497-6d21-c4bc171fb558@redhat.com> (raw)
In-Reply-To: <20210514151342.384376-3-richard.henderson@linaro.org>

On 14/05/21 17:12, Richard Henderson wrote:
> Split out the check for CPL != 0 and the raising of #GP.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

> ---
>   target/i386/tcg/translate.c | 79 ++++++++++++++-----------------------
>   1 file changed, 30 insertions(+), 49 deletions(-)
> 
> diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
> index 2672e08197..61b30117a3 100644
> --- a/target/i386/tcg/translate.c
> +++ b/target/i386/tcg/translate.c
> @@ -1282,6 +1282,16 @@ static void gen_exception_gpf(DisasContext *s)
>       gen_exception(s, EXCP0D_GPF, s->pc_start - s->cs_base);
>   }
>   
> +/* Check for cpl == 0; if not, raise #GP and return false. */
> +static bool check_cpl0(DisasContext *s)
> +{
> +    if (s->cpl == 0) {
> +        return true;
> +    }
> +    gen_exception_gpf(s);
> +    return false;
> +}
> +
>   /* if d == OR_TMP0, it means memory operand (address in A0) */
>   static void gen_op(DisasContext *s1, int op, MemOp ot, int d)
>   {
> @@ -7199,9 +7209,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>           break;
>       case 0x130: /* wrmsr */
>       case 0x132: /* rdmsr */
> -        if (s->cpl != 0) {
> -            gen_exception_gpf(s);
> -        } else {
> +        if (check_cpl0(s)) {
>               gen_update_cc_op(s);
>               gen_jmp_im(s, pc_start - s->cs_base);
>               if (b & 2) {
> @@ -7283,9 +7291,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>           gen_helper_cpuid(cpu_env);
>           break;
>       case 0xf4: /* hlt */
> -        if (s->cpl != 0) {
> -            gen_exception_gpf(s);
> -        } else {
> +        if (check_cpl0(s)) {
>               gen_update_cc_op(s);
>               gen_jmp_im(s, pc_start - s->cs_base);
>               gen_helper_hlt(cpu_env, tcg_const_i32(s->pc - pc_start));
> @@ -7309,9 +7315,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>           case 2: /* lldt */
>               if (!s->pe || s->vm86)
>                   goto illegal_op;
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> -            } else {
> +            if (check_cpl0(s)) {
>                   gen_svm_check_intercept(s, pc_start, SVM_EXIT_LDTR_WRITE);
>                   gen_ldst_modrm(env, s, modrm, MO_16, OR_TMP0, 0);
>                   tcg_gen_trunc_tl_i32(s->tmp2_i32, s->T0);
> @@ -7330,9 +7334,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>           case 3: /* ltr */
>               if (!s->pe || s->vm86)
>                   goto illegal_op;
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> -            } else {
> +            if (check_cpl0(s)) {
>                   gen_svm_check_intercept(s, pc_start, SVM_EXIT_TR_WRITE);
>                   gen_ldst_modrm(env, s, modrm, MO_16, OR_TMP0, 0);
>                   tcg_gen_trunc_tl_i32(s->tmp2_i32, s->T0);
> @@ -7446,8 +7448,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>                                    | PREFIX_REPZ | PREFIX_REPNZ))) {
>                   goto illegal_op;
>               }
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               tcg_gen_concat_tl_i64(s->tmp1_i64, cpu_regs[R_EAX],
> @@ -7463,8 +7464,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>               if (!(s->flags & HF_SVME_MASK) || !s->pe) {
>                   goto illegal_op;
>               }
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_update_cc_op(s);
> @@ -7488,8 +7488,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>               if (!(s->flags & HF_SVME_MASK) || !s->pe) {
>                   goto illegal_op;
>               }
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_update_cc_op(s);
> @@ -7501,8 +7500,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>               if (!(s->flags & HF_SVME_MASK) || !s->pe) {
>                   goto illegal_op;
>               }
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_update_cc_op(s);
> @@ -7516,8 +7514,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>                   || !s->pe) {
>                   goto illegal_op;
>               }
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_update_cc_op(s);
> @@ -7530,8 +7527,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>               if (!(s->flags & HF_SVME_MASK) || !s->pe) {
>                   goto illegal_op;
>               }
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_update_cc_op(s);
> @@ -7554,8 +7550,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>               if (!(s->flags & HF_SVME_MASK) || !s->pe) {
>                   goto illegal_op;
>               }
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_update_cc_op(s);
> @@ -7564,8 +7559,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>               break;
>   
>           CASE_MODRM_MEM_OP(2): /* lgdt */
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_svm_check_intercept(s, pc_start, SVM_EXIT_GDTR_WRITE);
> @@ -7581,8 +7575,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>               break;
>   
>           CASE_MODRM_MEM_OP(3): /* lidt */
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_svm_check_intercept(s, pc_start, SVM_EXIT_IDTR_WRITE);
> @@ -7627,8 +7620,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>               gen_helper_wrpkru(cpu_env, s->tmp2_i32, s->tmp1_i64);
>               break;
>           CASE_MODRM_OP(6): /* lmsw */
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_svm_check_intercept(s, pc_start, SVM_EXIT_WRITE_CR0);
> @@ -7639,8 +7631,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>               break;
>   
>           CASE_MODRM_MEM_OP(7): /* invlpg */
> -            if (s->cpl != 0) {
> -                gen_exception_gpf(s);
> +            if (!check_cpl0(s)) {
>                   break;
>               }
>               gen_update_cc_op(s);
> @@ -7654,9 +7645,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>           case 0xf8: /* swapgs */
>   #ifdef TARGET_X86_64
>               if (CODE64(s)) {
> -                if (s->cpl != 0) {
> -                    gen_exception_gpf(s);
> -                } else {
> +                if (check_cpl0(s)) {
>                       tcg_gen_mov_tl(s->T0, cpu_seg_base[R_GS]);
>                       tcg_gen_ld_tl(cpu_seg_base[R_GS], cpu_env,
>                                     offsetof(CPUX86State, kernelgsbase));
> @@ -7690,9 +7679,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>   
>       case 0x108: /* invd */
>       case 0x109: /* wbinvd */
> -        if (s->cpl != 0) {
> -            gen_exception_gpf(s);
> -        } else {
> +        if (check_cpl0(s)) {
>               gen_svm_check_intercept(s, pc_start, (b & 2) ? SVM_EXIT_INVD : SVM_EXIT_WBINVD);
>               /* nothing to do */
>           }
> @@ -8014,9 +8001,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>           break;
>       case 0x120: /* mov reg, crN */
>       case 0x122: /* mov crN, reg */
> -        if (s->cpl != 0) {
> -            gen_exception_gpf(s);
> -        } else {
> +        if (check_cpl0(s)) {
>               modrm = x86_ldub_code(env, s);
>               /* Ignore the mod bits (assume (modrm&0xc0)==0xc0).
>                * AMD documentation (24594.pdf) and testing of
> @@ -8068,9 +8053,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>           break;
>       case 0x121: /* mov reg, drN */
>       case 0x123: /* mov drN, reg */
> -        if (s->cpl != 0) {
> -            gen_exception_gpf(s);
> -        } else {
> +        if (check_cpl0(s)) {
>   #ifndef CONFIG_USER_ONLY
>               modrm = x86_ldub_code(env, s);
>               /* Ignore the mod bits (assume (modrm&0xc0)==0xc0).
> @@ -8104,9 +8087,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
>           }
>           break;
>       case 0x106: /* clts */
> -        if (s->cpl != 0) {
> -            gen_exception_gpf(s);
> -        } else {
> +        if (check_cpl0(s)) {
>               gen_svm_check_intercept(s, pc_start, SVM_EXIT_WRITE_CR0);
>               gen_helper_clts(cpu_env);
>               /* abort block because static cpu state changed */
> 



  reply	other threads:[~2021-05-18  9:29 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 15:12 [PATCH v2 00/50] target/i386 translate cleanups Richard Henderson
2021-05-14 15:12 ` [PATCH v2 01/50] target/i386: Split out gen_exception_gpf Richard Henderson
2021-05-18  9:08   ` Paolo Bonzini
2021-05-14 15:12 ` [PATCH v2 02/50] target/i386: Split out check_cpl0 Richard Henderson
2021-05-18  9:10   ` Paolo Bonzini [this message]
2021-05-14 15:12 ` [PATCH v2 03/50] target/i386: Unify code paths for IRET Richard Henderson
2021-05-18  9:11   ` Paolo Bonzini
2021-05-14 15:12 ` [PATCH v2 04/50] target/i386: Split out check_vm86_iopl Richard Henderson
2021-05-18  9:48   ` Paolo Bonzini
2021-05-14 15:12 ` [PATCH v2 05/50] target/i386: Split out check_iopl Richard Henderson
2021-05-18  9:14   ` Paolo Bonzini
2021-05-14 15:12 ` [PATCH v2 06/50] target/i386: Assert PE is set for user-only Richard Henderson
2021-05-18  9:15   ` Paolo Bonzini
2021-05-14 15:12 ` [PATCH v2 07/50] target/i386: Assert CPL is 3 " Richard Henderson
2021-05-18  9:17   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 08/50] target/i386: Assert IOPL is 0 " Richard Henderson
2021-05-18  9:18   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 09/50] target/i386: Assert !VM86 for x86_64 user-only Richard Henderson
2021-05-18  9:19   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 10/50] target/i386: Assert CODE32 " Richard Henderson
2021-05-18  9:20   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 11/50] target/i386: Assert SS32 " Richard Henderson
2021-05-18  9:20   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 12/50] target/i386: Assert CODE64 " Richard Henderson
2021-05-18  9:21   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 13/50] target/i386: Assert LMA " Richard Henderson
2021-05-18  9:21   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 14/50] target/i386: Assert !ADDSEG " Richard Henderson
2021-05-18  9:23   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 15/50] target/i386: Introduce REX_PREFIX Richard Henderson
2021-05-18  9:26   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 16/50] target/i386: Tidy REX_B, REX_X definition Richard Henderson
2021-05-18  9:28   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 17/50] target/i386: Move rex_r into DisasContext Richard Henderson
2021-05-18  9:28   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 18/50] target/i386: Move rex_w " Richard Henderson
2021-05-18  9:30   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 19/50] target/i386: Remove DisasContext.f_st as unused Richard Henderson
2021-05-18  9:30   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 20/50] target/i386: Reduce DisasContext.flags to uint32_t Richard Henderson
2021-05-18  9:30   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 21/50] target/i386: Reduce DisasContext.override to int8_t Richard Henderson
2021-05-18  9:31   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 22/50] target/i386: Reduce DisasContext.prefix to uint8_t Richard Henderson
2021-05-18  9:31   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 23/50] target/i386: Reduce DisasContext.vex_[lv] " Richard Henderson
2021-05-18  9:32   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 24/50] target/i386: Reduce DisasContext popl_esp_hack and rip_offset " Richard Henderson
2021-05-18  9:34   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 25/50] target/i386: Leave TF in DisasContext.flags Richard Henderson
2021-05-18  9:36   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 26/50] target/i386: Reduce DisasContext jmp_opt, repz_opt to bool Richard Henderson
2021-05-18  9:36   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 27/50] target/i386: Fix the comment for repz_opt Richard Henderson
2021-05-18  9:48   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 28/50] target/i386: Reorder DisasContext members Richard Henderson
2021-05-18  9:49   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 29/50] target/i386: Add stub generator for helper_set_dr Richard Henderson
2021-05-18  9:49   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 30/50] target/i386: Assert !SVME for user-only Richard Henderson
2021-05-18  9:51   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 31/50] target/i386: Assert !GUEST " Richard Henderson
2021-05-18  9:51   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 32/50] target/i386: Implement skinit in translate.c Richard Henderson
2021-05-18  9:51   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 33/50] target/i386: Eliminate SVM helpers for user-only Richard Henderson
2021-05-18  9:52   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 34/50] target/i386: Mark some helpers as noreturn Richard Henderson
2021-05-18  9:56   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 35/50] target/i386: Simplify gen_debug usage Richard Henderson
2021-05-18  9:56   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 36/50] target/i386: Tidy svm_check_intercept from tcg Richard Henderson
2021-05-18  9:57   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 37/50] target/i386: Remove pc_start argument to gen_svm_check_intercept Richard Henderson
2021-05-18  9:58   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 38/50] target/i386: Remove user stub for cpu_vmexit Richard Henderson
2021-05-18  9:58   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 39/50] target/i386: Cleanup read_crN, write_crN, lmsw Richard Henderson
2021-05-18 10:30   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 40/50] target/i386: Pass env to do_pause and do_hlt Richard Henderson
2021-05-18  9:59   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 41/50] target/i386: Move invlpg, hlt, monitor, mwait to sysemu Richard Henderson
2021-05-18 10:00   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 42/50] target/i386: Unify invlpg, invlpga Richard Henderson
2021-05-18 10:00   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 43/50] target/i386: Inline user cpu_svm_check_intercept_param Richard Henderson
2021-05-18 10:01   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 44/50] target/i386: Eliminate user stubs for read/write_crN, rd/wrmsr Richard Henderson
2021-05-18 10:01   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 45/50] target/i386: Exit tb after wrmsr Richard Henderson
2021-05-18 10:02   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 46/50] target/i386: Tidy gen_check_io Richard Henderson
2021-05-18 10:18   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 47/50] target/i386: Pass in port to gen_check_io Richard Henderson
2021-05-18 10:20   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 48/50] target/i386: Create helper_check_io Richard Henderson
2021-05-18 10:21   ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 49/50] target/i386: Move helper_check_io to sysemu Richard Henderson
2021-05-14 17:45   ` Richard Henderson
2021-05-18 10:22     ` Paolo Bonzini
2021-05-14 15:13 ` [PATCH v2 50/50] target/i386: Remove user-only i/o stubs Richard Henderson
2021-05-18 10:23   ` Paolo Bonzini
2021-05-14 16:09 ` [PATCH v2 00/50] target/i386 translate cleanups no-reply
2021-05-18 10:31 ` Paolo Bonzini
2021-05-18 10:59   ` Richard Henderson
2021-05-18 12:33     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3731dbd-a699-4497-6d21-c4bc171fb558@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=cfontana@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --subject='Re: [PATCH v2 02/50] target/i386: Split out check_cpl0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.