From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753951AbeBPIJb (ORCPT ); Fri, 16 Feb 2018 03:09:31 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:55287 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922AbeBPIJ3 (ORCPT ); Fri, 16 Feb 2018 03:09:29 -0500 Subject: Re: [PATCH v2 08/16] mmc: sdhci-omap: Add support to override f_max and iodelay from pdata To: Tony Lindgren , Ulf Hansson References: <20180205125029.21570-1-kishon@ti.com> <20180205125029.21570-9-kishon@ti.com> <20180214172455.GO6364@atomide.com> CC: Adrian Hunter , Rob Herring , Mark Rutland , Russell King , "linux-mmc@vger.kernel.org" , , Linux Kernel Mailing List , linux-omap , From: Kishon Vijay Abraham I Message-ID: Date: Fri, 16 Feb 2018 13:38:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20180214172455.GO6364@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday 14 February 2018 10:54 PM, Tony Lindgren wrote: > * Ulf Hansson [180214 09:53]: >> On 5 February 2018 at 13:50, Kishon Vijay Abraham I wrote: >>> DRA74x EVM Rev H EVM comes with revision 2.0 silicon. However, earlier >>> versions of EVM can come with either revision 1.1 or revision 1.0 of >>> silicon. >>> >>> The device-tree file is written to support rev 2.0 of silicon. >>> pdata-quirks are used to then override the settings needed for >>> PG 1.1 silicon. >>> >>> PG 1.1 silicon has limitations w.r.t frequencies at which MMC1/2/3 >>> can operate as well as different IOdelay numbers. >> >> I fail to understand the need for platform data. Why can't DT be used >> for the older revisions as well? It was decided to have dt file for a single soc revision. So the default dts corresponds to rev 2.0. > > Maybe the silicon revision is not available via soc_device_match()? hmm.. looks like we can get rid of pdata if we use soc_device_match. Thanks for the hint. Regards Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v2 08/16] mmc: sdhci-omap: Add support to override f_max and iodelay from pdata Date: Fri, 16 Feb 2018 13:38:51 +0530 Message-ID: References: <20180205125029.21570-1-kishon@ti.com> <20180205125029.21570-9-kishon@ti.com> <20180214172455.GO6364@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180214172455.GO6364@atomide.com> Sender: linux-mmc-owner@vger.kernel.org To: Tony Lindgren , Ulf Hansson Cc: Adrian Hunter , Rob Herring , Mark Rutland , Russell King , "linux-mmc@vger.kernel.org" , devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-omap , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi, On Wednesday 14 February 2018 10:54 PM, Tony Lindgren wrote: > * Ulf Hansson [180214 09:53]: >> On 5 February 2018 at 13:50, Kishon Vijay Abraham I wrote: >>> DRA74x EVM Rev H EVM comes with revision 2.0 silicon. However, earlier >>> versions of EVM can come with either revision 1.1 or revision 1.0 of >>> silicon. >>> >>> The device-tree file is written to support rev 2.0 of silicon. >>> pdata-quirks are used to then override the settings needed for >>> PG 1.1 silicon. >>> >>> PG 1.1 silicon has limitations w.r.t frequencies at which MMC1/2/3 >>> can operate as well as different IOdelay numbers. >> >> I fail to understand the need for platform data. Why can't DT be used >> for the older revisions as well? It was decided to have dt file for a single soc revision. So the default dts corresponds to rev 2.0. > > Maybe the silicon revision is not available via soc_device_match()? hmm.. looks like we can get rid of pdata if we use soc_device_match. Thanks for the hint. Regards Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Fri, 16 Feb 2018 13:38:51 +0530 Subject: [PATCH v2 08/16] mmc: sdhci-omap: Add support to override f_max and iodelay from pdata In-Reply-To: <20180214172455.GO6364@atomide.com> References: <20180205125029.21570-1-kishon@ti.com> <20180205125029.21570-9-kishon@ti.com> <20180214172455.GO6364@atomide.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Wednesday 14 February 2018 10:54 PM, Tony Lindgren wrote: > * Ulf Hansson [180214 09:53]: >> On 5 February 2018 at 13:50, Kishon Vijay Abraham I wrote: >>> DRA74x EVM Rev H EVM comes with revision 2.0 silicon. However, earlier >>> versions of EVM can come with either revision 1.1 or revision 1.0 of >>> silicon. >>> >>> The device-tree file is written to support rev 2.0 of silicon. >>> pdata-quirks are used to then override the settings needed for >>> PG 1.1 silicon. >>> >>> PG 1.1 silicon has limitations w.r.t frequencies at which MMC1/2/3 >>> can operate as well as different IOdelay numbers. >> >> I fail to understand the need for platform data. Why can't DT be used >> for the older revisions as well? It was decided to have dt file for a single soc revision. So the default dts corresponds to rev 2.0. > > Maybe the silicon revision is not available via soc_device_match()? hmm.. looks like we can get rid of pdata if we use soc_device_match. Thanks for the hint. Regards Kishon