From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD91C433ED for ; Tue, 11 May 2021 15:32:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08FE86112F for ; Tue, 11 May 2021 15:32:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08FE86112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E9C256EA61; Tue, 11 May 2021 15:32:13 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1994E6EA61; Tue, 11 May 2021 15:32:12 +0000 (UTC) IronPort-SDR: 6zpk4QnNmYZj0U2YnyCzope1H1rn8YufpHjyFEuEqxZdMELnlMrNS1RvvqziUZGDFUuVj/Lyur 1nSgrOsrebVw== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="199523566" X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="199523566" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 08:32:05 -0700 IronPort-SDR: 8sfC+Z6+bnyqO83x/6R1oWRvX/IGrNUOhbpXAlaXMgOzFX68AkJIbi7GQ8o6xDiTSIWxw0XLDZ JcnJsiNpEgqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="434601130" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga008.fm.intel.com with ESMTP; 11 May 2021 08:32:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 11 May 2021 08:32:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 11 May 2021 08:32:03 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2106.013; Tue, 11 May 2021 08:32:03 -0700 From: "Bloomfield, Jon" To: Martin Peres , Daniel Vetter Subject: RE: [RFC PATCH 00/97] Basic GuC submission support in the i915 Thread-Topic: [RFC PATCH 00/97] Basic GuC submission support in the i915 Thread-Index: AQHXQqmdeMs8Pc67x0q3ztXPF3PEcarb3OcAgABkeICAAPbxAIAALCSAgAEEnAD///Xm4A== Date: Tue, 11 May 2021 15:26:59 +0000 Deferred-Delivery: Tue, 11 May 2021 15:25:07 +0000 Message-ID: References: <20210506191451.77768-1-matthew.brost@intel.com> <17953669798.2817.c6988b7ea6112e3e892765a0d4287e0c@jlekstrand.net> <546e4ee4-9aa4-1967-cdcb-a561cac582ef@free.fr> <08c22bc8-aa35-43d2-ad4c-7f489dfc585b@free.fr> In-Reply-To: <08c22bc8-aa35-43d2-ad4c-7f489dfc585b@free.fr> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.22.254.132] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Brost, Matthew" , "Ursulin, Tvrtko" , intel-gfx , dri-devel , "Ekstrand, Jason" , "Ceraolo Spurio, Daniele" , Jason Ekstrand , "Vetter, Daniel" , "Harrison, John C" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBNYXJ0aW4gUGVyZXMgPG1hcnRp bi5wZXJlc0BmcmVlLmZyPg0KPiBTZW50OiBUdWVzZGF5LCBNYXkgMTEsIDIwMjEgMTowNiBBTQ0K PiBUbzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPg0KPiBDYzogSmFzb24gRWtzdHJh bmQgPGphc29uQGpsZWtzdHJhbmQubmV0PjsgQnJvc3QsIE1hdHRoZXcNCj4gPG1hdHRoZXcuYnJv c3RAaW50ZWwuY29tPjsgaW50ZWwtZ2Z4IDxpbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn PjsNCj4gZHJpLWRldmVsIDxkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnPjsgVXJzdWxp biwgVHZydGtvDQo+IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+OyBFa3N0cmFuZCwgSmFzb24g PGphc29uLmVrc3RyYW5kQGludGVsLmNvbT47DQo+IENlcmFvbG8gU3B1cmlvLCBEYW5pZWxlIDxk YW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPjsgQmxvb21maWVsZCwgSm9uDQo+IDxqb24u Ymxvb21maWVsZEBpbnRlbC5jb20+OyBWZXR0ZXIsIERhbmllbCA8ZGFuaWVsLnZldHRlckBpbnRl bC5jb20+Ow0KPiBIYXJyaXNvbiwgSm9obiBDIDxqb2huLmMuaGFycmlzb25AaW50ZWwuY29tPg0K PiBTdWJqZWN0OiBSZTogW1JGQyBQQVRDSCAwMC85N10gQmFzaWMgR3VDIHN1Ym1pc3Npb24gc3Vw cG9ydCBpbiB0aGUgaTkxNQ0KPiANCj4gT24gMTAvMDUvMjAyMSAxOTozMywgRGFuaWVsIFZldHRl ciB3cm90ZToNCj4gPiBPbiBNb24sIE1heSAxMCwgMjAyMSBhdCAzOjU1IFBNIE1hcnRpbiBQZXJl cyA8bWFydGluLnBlcmVzQGZyZWUuZnI+DQo+IHdyb3RlOg0KPiA+Pg0KPiA+PiBPbiAxMC8wNS8y MDIxIDAyOjExLCBKYXNvbiBFa3N0cmFuZCB3cm90ZToNCj4gPj4+IE9uIE1heSA5LCAyMDIxIDEy OjEyOjM2IE1hcnRpbiBQZXJlcyA8bWFydGluLnBlcmVzQGZyZWUuZnI+IHdyb3RlOg0KPiA+Pj4N Cj4gPj4+PiBIaSwNCj4gPj4+Pg0KPiA+Pj4+IE9uIDA2LzA1LzIwMjEgMjI6MTMsIE1hdHRoZXcg QnJvc3Qgd3JvdGU6DQo+ID4+Pj4+IEJhc2ljIEd1QyBzdWJtaXNzaW9uIHN1cHBvcnQuIFRoaXMg aXMgdGhlIGZpcnN0IGJ1bGxldCBwb2ludCBpbiB0aGUNCj4gPj4+Pj4gdXBzdHJlYW1pbmcgcGxh biBjb3ZlcmVkIGluIHRoZSBmb2xsb3dpbmcgUkZDIFsxXS4NCj4gPj4+Pj4NCj4gPj4+Pj4gQXQg YSB2ZXJ5IGhpZ2ggbGV2ZWwgdGhlIEd1QyBpcyBhIHBpZWNlIG9mIGZpcm13YXJlIHdoaWNoIHNp dHMgYmV0d2Vlbg0KPiA+Pj4+PiB0aGUgaTkxNSBhbmQgdGhlIEdQVS4gSXQgb2ZmbG9hZHMgc29t ZSBvZiB0aGUgc2NoZWR1bGluZyBvZiBjb250ZXh0cw0KPiA+Pj4+PiBmcm9tIHRoZSBpOTE1IGFu ZCBwcm9ncmFtcyB0aGUgR1BVIHRvIHN1Ym1pdCBjb250ZXh0cy4gVGhlIGk5MTUNCj4gPj4+Pj4g Y29tbXVuaWNhdGVzIHdpdGggdGhlIEd1QyBhbmQgdGhlIEd1QyBjb21tdW5pY2F0ZXMgd2l0aCB0 aGUNCj4gR1BVLg0KPiA+Pj4+DQo+ID4+Pj4gTWF5IEkgYXNrIHdoYXQgd2lsbCBHdUMgY29tbWFu ZCBzdWJtaXNzaW9uIGRvIHRoYXQgZXhlY2xpc3QNCj4gd29uJ3QvY2FuJ3QNCj4gPj4+PiBkbz8g QW5kIHdoYXQgd291bGQgYmUgdGhlIGltcGFjdCBvbiB1c2Vycz8gRXZlbiBmb3JnZXR0aW5nIHRo ZQ0KPiB0cm91YmxlZA0KPiA+Pj4+IGhpc3Rvcnkgb2YgR3VDIChpbnN0YWJpbGl0eSwgcGVyZm9y bWFuY2UgcmVncmVzc2lvbiwgcG9vciBsZXZlbCBvZiB1c2VyDQo+ID4+Pj4gc3VwcG9ydCwgNisg eWVhcnMgb2YgdHJ5aW5nIHRvIHVwc3RyZWFtIGl0Li4uKSwgYWRkaW5nIHRoaXMgbXVjaCBjb2Rl DQo+ID4+Pj4gYW5kIGRvdWJsaW5nIHRoZSBhbW91bnQgb2YgdmFsaWRhdGlvbiBuZWVkZWQgc2hv dWxkIGNvbWUgd2l0aCBhDQo+ID4+Pj4gcmF0aW9uYWxlIG1ha2luZyBpdCBmZWVsIHdvcnRoIGl0 Li4uIGFuZCBJIGFtIG5vdCBzZWVpbmcgaGVyZS4gV291bGQgeW91DQo+ID4+Pj4gbWluZCBwcm92 aWRpbmcgdGhlIHJhdGlvbmFsZSBiZWhpbmQgdGhpcyB3b3JrPw0KPiA+Pj4+DQo+ID4+Pj4+DQo+ ID4+Pj4+IEd1QyBzdWJtaXNzaW9uIHdpbGwgYmUgZGlzYWJsZWQgYnkgZGVmYXVsdCBvbiBhbGwg Y3VycmVudCB1cHN0cmVhbQ0KPiA+Pj4+PiBwbGF0Zm9ybXMgYmVoaW5kIGEgbW9kdWxlIHBhcmFt ZXRlciAtIGVuYWJsZV9ndWMuIEEgdmFsdWUgb2YgMyB3aWxsDQo+ID4+Pj4+IGVuYWJsZSBzdWJt aXNzaW9uIGFuZCBIdUMgbG9hZGluZyB2aWEgdGhlIEd1Qy4gR3VDIHN1Ym1pc3Npb24NCj4gc2hv dWxkDQo+ID4+Pj4+IHdvcmsgb24gYWxsIGdlbjExKyBwbGF0Zm9ybXMgYXNzdW1pbmcgdGhlIEd1 QyBmaXJtd2FyZSBpcyBwcmVzZW50Lg0KPiA+Pj4+DQo+ID4+Pj4gV2hhdCBpcyB0aGUgcGxhbiBo ZXJlIHdoZW4gaXQgY29tZXMgdG8ga2VlcGluZyBzdXBwb3J0IGZvciBleGVjbGlzdD8gSQ0KPiA+ Pj4+IGFtIGFmcmFpZCB0aGF0IGxhbmRpbmcgR3VDIHN1cHBvcnQgaW4gTGludXggaXMgdGhlIGZp cnN0IHN0ZXAgdG93YXJkcw0KPiA+Pj4+IGtpbGxpbmcgdGhlIGV4ZWNsaXN0LCB3aGljaCB3b3Vs ZCBmb3JjZSB1c2VycyB0byB1c2UgcHJvcHJpZXRhcnkNCj4gPj4+PiBmaXJtd2FyZXMgdGhhdCBl dmVuIG1vc3QgSW50ZWwgZW5naW5lZXJzIGhhdmUgbGl0dGxlIGluZmx1ZW5jZSBvdmVyLg0KPiA+ Pj4+IEluZGVlZCwgaWYgImRybS9pOTE1L2d1YzogRGlzYWJsZSBzZW1hcGhvcmVzIHdoZW4gdXNp bmcgR3VDDQo+IHNjaGVkdWxpbmciDQo+ID4+Pj4gd2hpY2ggc3RhdGVzICJEaXNhYmxlIHNlbWFw aG9yZXMgd2hlbiB1c2luZyBHdUMgc2NoZWR1bGluZyBhcw0KPiBzZW1hcGhvcmVzDQo+ID4+Pj4g YXJlIGJyb2tlbiBpbiB0aGUgY3VycmVudCBHdUMgZmlybXdhcmUuIiBpcyBhbnl0aGluZyB0byBn byBieSwgaXQgbWVhbnMNCj4gPj4+PiB0aGF0IGV2ZW4gSW50ZWwgZGV2ZWxvcGVycyBzZWVtIHRv IHByZWZlciB3b3JraW5nIGFyb3VuZCB0aGUgR3VDDQo+ID4+Pj4gZmlybXdhcmUsIHJhdGhlciB0 aGFuIGZpeGluZyBpdC4NCj4gPj4+DQo+ID4+PiBZZXMsIGxhbmRpbmcgR3VDIHN1cHBvcnQgbWF5 IGJlIHRoZSBmaXJzdCBzdGVwIGluIHJlbW92aW5nIGV4ZWNsaXN0DQo+ID4+PiBzdXBwb3J0LiBU aGUgaW5ldml0YWJsZSByZWFsaXR5IGlzIHRoYXQgR1BVIHNjaGVkdWxpbmcgaXMgY29taW5nIGFu ZA0KPiA+Pj4gbGlrZWx5IHRvIGJlIHRoZXJlIG9ubHkgcGF0aCBpbiB0aGUgbm90LXRvby1kaXN0 YW50IGZ1dHVyZS4gKFNlZSBhbHNvDQo+ID4+PiB0aGUgb25nb2luZyB0aHJlYWQgd2l0aCBBTUQg YWJvdXQgZmVuY2VzLikgSSdtIG5vdCBnb2luZyB0byBwYXNzDQo+ID4+PiBqdWRnZW1lbnQgb24g d2hldGhlciBvciBub3QgdGhpcyBpcyBhIGdvb2QgdGhpbmcuICBJJ20ganVzdCByZWFkaW5nIHRo ZQ0KPiA+Pj4gd2luZHMgYW5kLCBpbiBteSB2aWV3LCB0aGlzIGlzIHdoZXJlIHRoaW5ncyBhcmUg aGVhZGVkIGZvciBnb29kIG9yIGlsbC4NCj4gPj4+DQo+ID4+PiBJbiBhbnN3ZXIgdG8gdGhlIHF1 ZXN0aW9uIGFib3ZlLCB0aGUgYW5zd2VyIHRvICJ3aGF0IGRvIHdlIGdhaW4gZnJvbQ0KPiA+Pj4g R3VDPyIgbWF5IHNvb24gYmUsICJ5b3UgZ2V0IHRvIHVzZSB5b3VyIEdQVS4iICBXZSdyZSBub3Qg dGhlcmUgeWV0DQo+IGFuZCwNCj4gPj4+IGFnYWluLCBJJ20gbm90IG5lY2Vzc2FyaWx5IGFkdm9j YXRpbmcgZm9yIGl0LCBidXQgdGhhdCBpcyBsaWtlbHkgd2hlcmUNCj4gPj4+IHRoaW5ncyBhcmUg aGVhZGVkLg0KPiA+Pg0KPiA+PiBUaGlzIHdpbGwgYmUgYSBzYWQgZGF5LCBlc3BlY2lhbGx5IHNp bmNlIGl0IHNlZW1zIGZ1bmRhbWVudGFsbHkgb3Bwb3NlZA0KPiA+PiB3aXRoIGFueSBsb25nLXRl cm0gc3VwcG9ydCwgb24gdG9wIG9mIHRha2luZyBhd2F5IHVzZXIgZnJlZWRvbSB0bw0KPiA+PiBm aXgvdHdlYWsgdGhlaXIgc3lzdGVtIHdoZW4gSW50ZWwgd29uJ3QuDQo+ID4+DQo+ID4+PiBBIGZp cm13YXJlLWJhc2VkIHN1Ym1pc3Npb24gbW9kZWwgaXNuJ3QgYSBiYWQgZGVzaWduIElNTyBhbmQs IGFzaWRlDQo+IGZyb20NCj4gPj4+IHRoZSBmaXJtd2FyZSBmcmVlZG9tIGlzc3VlcywgSSB0aGlu ayB0aGVyZSBhcmUgYWN0dWFsIGFkdmFudGFnZXMgdG8gdGhlDQo+ID4+PiBtb2RlbC4gSW1tZWRp YXRlbHksIGl0J2xsIHVubG9jayBhIGZldyBmZWF0dXJlcyBsaWtlIHBhcmFsbGVsIHN1Ym1pc3Np b24NCj4gPj4+IChtb3JlIG9uIHRoYXQgaW4gYSBiaXQpIGFuZCBsb25nLXJ1bm5pbmcgY29tcHV0 ZSBiZWNhdXNlIHRoZXkncmUNCj4gPj4+IGltcGxlbWVudGVkIGluIEd1QyBhbmQgdGhlIHdvcmsg dG8gaW1wbGVtZW50IHRoZW0gcHJvcGVybHkgaW4gdGhlDQo+ID4+PiBleGVjbGlzdCBzY2hlZHVs ZXIgaXMgaGlnaGx5IG5vbi10cml2aWFsLiBMb25nZXIgdGVybSwgaXQgbWF5IChubw0KPiA+Pj4g Z3VhcmFudGVlcykgdW5sb2NrIHNvbWUgcGVyZm9ybWFuY2UgYnkgZ2V0dGluZyB0aGUga2VybmVs IG91dCBvZiB0aGUNCj4gd2F5Lg0KPiA+Pg0KPiA+PiBPaCwgSSBkZWZpbml0ZWx5IGFncmVlIHdp dGggZmlybXdhcmUtYmFzZWQgc3VibWlzc2lvbiBtb2RlbCBub3QgYmVpbmcgYQ0KPiA+PiBiYWQg ZGVzaWduLiBJIHdhcyBldmVuIGNoZWVyaW5nIGZvciBpdCBpbiAyMDE1LiBFeHBlcmllbmNlIHdp dGggaXQgbWFkZQ0KPiA+PiBtZSByZWdyZXQgdGhhdCBkZWVwbHkgc2luY2UgOnMNCj4gPj4NCj4g Pj4gQnV0IHdpdGggdGhlIERSTSBzY2hlZHVsZXIgYmVpbmcgcmVzcG9uc2libGUgZm9yIG1vc3Qg dGhpbmdzLCBJIGZhaWwgdG8NCj4gPj4gc2VlIHdoYXQgd2UgY291bGQgb2ZmbG9hZCBpbiB0aGUg R3VDIGV4Y2VwdCBjb250ZXh0IHN3aXRjaGluZyAobGlrZQ0KPiA+PiBldmVyeSBvdGhlciBtYW51 ZmFjdHVyZXIpLiBUaGUgcHJvYmxlbSBpcywgdGhlIEd1QyBkb2VzIHdheSBtb3JlIHRoYW4NCj4g Pj4ganVzdCBzd2l0Y2hpbmcgcmVnaXN0ZXJzIGluIGJ1bGssIGFuZCBpZiB0aGUgbnVtYmVyIG9m IHJldmlzaW9ucyBvZiB0aGUNCj4gPj4gR3VDIGlzIGFueXRoaW5nIHRvIGdvIGJ5LCBpdCBpcyB3 YXkgdG9vIGNvbXBsZXggZm9yIG1lIHRvIGZlZWwNCj4gPj4gY29tZm9ydGFibGUgd2l0aCBpdC4N Cj4gPg0KPiA+IFdlIG5lZWQgdG8gZmxlc2ggb3V0IHRoYXQgcGFydCBvZiB0aGUgcGxhbiBtb3Jl LCBidXQgd2UncmUgbm90IGdvaW5nDQo+ID4gdG8gdXNlIGRybSBzY2hlZHVsZXIgZm9yIGV2ZXJ5 dGhpbmcuIEl0J3Mgb25seSB0byBoYW5kbGUgdGhlIGRtYS1mZW5jZQ0KPiA+IGxlZ2FjeSBzaWRl IG9mIHRoaW5ncywgd2hpY2ggbWVhbnM6DQo+ID4gLSB0aW1lb3V0IGhhbmRsaW5nIGZvciBiYXRj aGVzIHRoYXQgdGFrZSB0b28gbG9uZw0KPiA+IC0gZG1hX2ZlbmNlIGRlcGVuZGVuY3kgc29ydGlu Zy9oYW5kbGluZw0KPiA+IC0gYm9vc3Rpbmcgb2YgY29udGV4dCBmcm9tIGRpc3BsYXkgZmxpcHMg KGN1cnJlbnRseSBtaXNzaW5nLCBuZWVkcyB0bw0KPiA+IGJlIHBvcnRlZCBmcm9tIGRybS9pOTE1 KQ0KPiA+DQo+ID4gVGhlIGFjdHVhbCByb3VuZC1yb2Jpbi9wcmVlbXB0L3ByaW9yaXR5IGhhbmRs aW5nIGlzIHN0aWxsIGxlZnQgdG8gdGhlDQo+ID4gYmFja2VuZCwgaW4gdGhpcyBjYXNlIGhlcmUg dGhlIGZ3LiBTbyB0aGVyZSdzIGxhcmdlIGNodW5rcyBvZg0KPiA+IGNvZGUvZnVuY3Rpb25hbGl0 eSB3aGVyZSBkcm0vc2NoZWR1bGVyIHdvbnQgYmUgaW52b2x2ZWQgaW4sIGFuZCBsaWtlDQo+ID4g SmFzb24gc2F5czogVGhlIGh3IGRpcmVjdGlvbiB3aW5kcyBkZWZpbml0ZWx5IGJsb3cgaW4gdGhl IGRpcmVjdGlvbg0KPiA+IHRoYXQgdGhpcyBpcyBhbGwgaGFuZGxlZCBpbiBody4NCj4gDQo+IFRo ZSBwbGFuIG1ha2VzIHNlbnNlIGZvciBhIFNSSU9WLWVuYWJsZSBHUFUsIHllcy4NCj4gDQo+IEhv d2V2ZXIsIGlmIHRoZSBHdUMgaXMgYWN0dWFsbHkgaGVscGluZyBpOTE1LCB0aGVuIHdoeSBub3Qg b3BlbiBzb3VyY2UNCj4gaXQgYW5kIGRyb3AgYWxsIHRoZSBpc3N1ZXMgcmVsYXRlZCB0byBpdHMg c3RhYmlsaXR5PyBXb3VsZG4ndCBpdCBiZSB0aGUNCj4gcGVyZmVjdCBzb2x1dGlvbiwgYXMgaXQg d291bGQgYWxsb3cgZHJvcHBpbmcgZXhlY2xpc3Qgc3VwcG9ydCBmb3IgbmV3ZXINCj4gSFcsIGFu ZCBpdCB3b3VsZCBlbGltaW5hdGUgdGhlIGNvbmNlcm5zIGFib3V0IG1haW50ZW5hbmNlIG9mIHN0 YWJsZQ0KPiByZWxlYXNlcyBvZiBMaW51eD8NCg0KVGhhdCB0aGUgbWFqb3IgdmVyc2lvbiBvZiB0 aGUgRlcgaXMgaGlnaCBpcyBub3QgZHVlIHRvIGJ1Z3MgLSBCdWdzIGRvbid0IHRyaWdnZXIgbWFq b3IgdmVyc2lvbiBidW1wcyBhbnl3YXkuIE9ubHkgaW50ZXJmYWNlIGNoYW5nZXMgaW5jcmVtZW50 IHRoZSBtYWpvciB2ZXJzaW9uLCBhbmQgd2UgZG8gYWRkIGZlYXR1cmVzLCB0byBrZWVwIGl0IHJl bGV2YW50IHRvIHRoZSBldm9sdmluZyBoYXJkd2FyZSBhbmQgT1MgbGFuZHNjYXBlLiBXaGVuIG9u bHkgV2luZG93cyB1c2VkIEd1QyB0aGVyZSB3YXMgbm8gcmVhc29uIG5vdCB0byBtaW5pbWl6ZSBp bnRlcmZhY2UgY3JlZXAgLSBHdUMgYW5kIEtNRCBhcmUgcmVsZWFzZWQgYXMgYW4gYXRvbWljIGJ1 bmRsZSBvbiBXaW5kb3dzLiBXaXRoIExpbnV4LCB0aGlzIGlzIG5vIGxvbmdlciB0aGUgY2FzZSwg YW5kIGhhcyBub3QgYmVlbiBmb3Igc29tZSB0aW1lLg0KDQpXZSBoYXZlIGJlZW4gdXNpbmcgR3VD IGFzIHRoZSBzb2xlIG1lY2hhbmlzbSBmb3Igc3VibWlzc2lvbiBvbiBXaW5kb3dzIHNpbmNlIEdl bjgsIGFuZCBpdCBoYXMgcHJvdmVuIHZlcnkgcmVsaWFibGUuIFRoaXMgaXMgaW4gbGFyZ2UgcGFy dCBiZWNhdXNlIGl0IGlzIHNpbXBsZSwgYW5kIGRlc2lnbmVkIGZyb20gZGF5IDEgYXMgYSBjb2hl c2l2ZSBzb2x1dGlvbiBhbG9uZ3NpZGUgdGhlIGhhcmR3YXJlLg0KDQpXaWxsIHRoZXJlIGJlIGJ1 Z3MgaW4gdGhlIGZ1dHVyZT8gT2YgY291cnNlLiBJdCdzIGEgbmV3IGk5MTUgYmFja2VuZC4gVGhl cmUgYXJlIGJ1Z3MgaW4gdGhlIGV4ZWNsaXN0IGJhY2tlbmQgdG9vLCBhbmQgdGhlIHJ1bmxpc3Qg YmFja2VuZCwgYW5kIHRoZSBtYWpvcml0eSBvZiByZWFsLXdvcmxkIHNvZnR3YXJlIGV2ZXIgd3Jp dHRlbi4gQnV0IHRoZSBpOTE1IEd1QyBiYWNrZW5kIGlzIHdheSBzaW1wbGVyIHRoYW4gZXhlY2xp c3QsIG11Y2ggZWFzaWVyIHRvIHVuZGVyc3RhbmQsIGFuZCB0aGVyZWZvcmUgbXVjaCBlYXNpZXIg dG8gbWFpbnRhaW4uIEl0J3MgYSBuZXQgd2luIGZvciBpOTE1IGFuZCBMaW51eC4NCg0KSm9uDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D984C433B4 for ; Tue, 11 May 2021 15:32:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADA6A6112F for ; Tue, 11 May 2021 15:32:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADA6A6112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D7126EA62; Tue, 11 May 2021 15:32:14 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1994E6EA61; Tue, 11 May 2021 15:32:12 +0000 (UTC) IronPort-SDR: 6zpk4QnNmYZj0U2YnyCzope1H1rn8YufpHjyFEuEqxZdMELnlMrNS1RvvqziUZGDFUuVj/Lyur 1nSgrOsrebVw== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="199523566" X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="199523566" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 08:32:05 -0700 IronPort-SDR: 8sfC+Z6+bnyqO83x/6R1oWRvX/IGrNUOhbpXAlaXMgOzFX68AkJIbi7GQ8o6xDiTSIWxw0XLDZ JcnJsiNpEgqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="434601130" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga008.fm.intel.com with ESMTP; 11 May 2021 08:32:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 11 May 2021 08:32:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 11 May 2021 08:32:03 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2106.013; Tue, 11 May 2021 08:32:03 -0700 From: "Bloomfield, Jon" To: Martin Peres , Daniel Vetter Thread-Topic: [RFC PATCH 00/97] Basic GuC submission support in the i915 Thread-Index: AQHXQqmdeMs8Pc67x0q3ztXPF3PEcarb3OcAgABkeICAAPbxAIAALCSAgAEEnAD///Xm4A== Date: Tue, 11 May 2021 15:26:59 +0000 Deferred-Delivery: Tue, 11 May 2021 15:25:07 +0000 Message-ID: References: <20210506191451.77768-1-matthew.brost@intel.com> <17953669798.2817.c6988b7ea6112e3e892765a0d4287e0c@jlekstrand.net> <546e4ee4-9aa4-1967-cdcb-a561cac582ef@free.fr> <08c22bc8-aa35-43d2-ad4c-7f489dfc585b@free.fr> In-Reply-To: <08c22bc8-aa35-43d2-ad4c-7f489dfc585b@free.fr> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.22.254.132] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [RFC PATCH 00/97] Basic GuC submission support in the i915 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , dri-devel , "Ekstrand, Jason" , "Vetter, Daniel" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > -----Original Message----- > From: Martin Peres > Sent: Tuesday, May 11, 2021 1:06 AM > To: Daniel Vetter > Cc: Jason Ekstrand ; Brost, Matthew > ; intel-gfx ; > dri-devel ; Ursulin, Tvrtko > ; Ekstrand, Jason ; > Ceraolo Spurio, Daniele ; Bloomfield, Jon > ; Vetter, Daniel ; > Harrison, John C > Subject: Re: [RFC PATCH 00/97] Basic GuC submission support in the i915 > > On 10/05/2021 19:33, Daniel Vetter wrote: > > On Mon, May 10, 2021 at 3:55 PM Martin Peres > wrote: > >> > >> On 10/05/2021 02:11, Jason Ekstrand wrote: > >>> On May 9, 2021 12:12:36 Martin Peres wrote: > >>> > >>>> Hi, > >>>> > >>>> On 06/05/2021 22:13, Matthew Brost wrote: > >>>>> Basic GuC submission support. This is the first bullet point in the > >>>>> upstreaming plan covered in the following RFC [1]. > >>>>> > >>>>> At a very high level the GuC is a piece of firmware which sits between > >>>>> the i915 and the GPU. It offloads some of the scheduling of contexts > >>>>> from the i915 and programs the GPU to submit contexts. The i915 > >>>>> communicates with the GuC and the GuC communicates with the > GPU. > >>>> > >>>> May I ask what will GuC command submission do that execlist > won't/can't > >>>> do? And what would be the impact on users? Even forgetting the > troubled > >>>> history of GuC (instability, performance regression, poor level of user > >>>> support, 6+ years of trying to upstream it...), adding this much code > >>>> and doubling the amount of validation needed should come with a > >>>> rationale making it feel worth it... and I am not seeing here. Would you > >>>> mind providing the rationale behind this work? > >>>> > >>>>> > >>>>> GuC submission will be disabled by default on all current upstream > >>>>> platforms behind a module parameter - enable_guc. A value of 3 will > >>>>> enable submission and HuC loading via the GuC. GuC submission > should > >>>>> work on all gen11+ platforms assuming the GuC firmware is present. > >>>> > >>>> What is the plan here when it comes to keeping support for execlist? I > >>>> am afraid that landing GuC support in Linux is the first step towards > >>>> killing the execlist, which would force users to use proprietary > >>>> firmwares that even most Intel engineers have little influence over. > >>>> Indeed, if "drm/i915/guc: Disable semaphores when using GuC > scheduling" > >>>> which states "Disable semaphores when using GuC scheduling as > semaphores > >>>> are broken in the current GuC firmware." is anything to go by, it means > >>>> that even Intel developers seem to prefer working around the GuC > >>>> firmware, rather than fixing it. > >>> > >>> Yes, landing GuC support may be the first step in removing execlist > >>> support. The inevitable reality is that GPU scheduling is coming and > >>> likely to be there only path in the not-too-distant future. (See also > >>> the ongoing thread with AMD about fences.) I'm not going to pass > >>> judgement on whether or not this is a good thing. I'm just reading the > >>> winds and, in my view, this is where things are headed for good or ill. > >>> > >>> In answer to the question above, the answer to "what do we gain from > >>> GuC?" may soon be, "you get to use your GPU." We're not there yet > and, > >>> again, I'm not necessarily advocating for it, but that is likely where > >>> things are headed. > >> > >> This will be a sad day, especially since it seems fundamentally opposed > >> with any long-term support, on top of taking away user freedom to > >> fix/tweak their system when Intel won't. > >> > >>> A firmware-based submission model isn't a bad design IMO and, aside > from > >>> the firmware freedom issues, I think there are actual advantages to the > >>> model. Immediately, it'll unlock a few features like parallel submission > >>> (more on that in a bit) and long-running compute because they're > >>> implemented in GuC and the work to implement them properly in the > >>> execlist scheduler is highly non-trivial. Longer term, it may (no > >>> guarantees) unlock some performance by getting the kernel out of the > way. > >> > >> Oh, I definitely agree with firmware-based submission model not being a > >> bad design. I was even cheering for it in 2015. Experience with it made > >> me regret that deeply since :s > >> > >> But with the DRM scheduler being responsible for most things, I fail to > >> see what we could offload in the GuC except context switching (like > >> every other manufacturer). The problem is, the GuC does way more than > >> just switching registers in bulk, and if the number of revisions of the > >> GuC is anything to go by, it is way too complex for me to feel > >> comfortable with it. > > > > We need to flesh out that part of the plan more, but we're not going > > to use drm scheduler for everything. It's only to handle the dma-fence > > legacy side of things, which means: > > - timeout handling for batches that take too long > > - dma_fence dependency sorting/handling > > - boosting of context from display flips (currently missing, needs to > > be ported from drm/i915) > > > > The actual round-robin/preempt/priority handling is still left to the > > backend, in this case here the fw. So there's large chunks of > > code/functionality where drm/scheduler wont be involved in, and like > > Jason says: The hw direction winds definitely blow in the direction > > that this is all handled in hw. > > The plan makes sense for a SRIOV-enable GPU, yes. > > However, if the GuC is actually helping i915, then why not open source > it and drop all the issues related to its stability? Wouldn't it be the > perfect solution, as it would allow dropping execlist support for newer > HW, and it would eliminate the concerns about maintenance of stable > releases of Linux? That the major version of the FW is high is not due to bugs - Bugs don't trigger major version bumps anyway. Only interface changes increment the major version, and we do add features, to keep it relevant to the evolving hardware and OS landscape. When only Windows used GuC there was no reason not to minimize interface creep - GuC and KMD are released as an atomic bundle on Windows. With Linux, this is no longer the case, and has not been for some time. We have been using GuC as the sole mechanism for submission on Windows since Gen8, and it has proven very reliable. This is in large part because it is simple, and designed from day 1 as a cohesive solution alongside the hardware. Will there be bugs in the future? Of course. It's a new i915 backend. There are bugs in the execlist backend too, and the runlist backend, and the majority of real-world software ever written. But the i915 GuC backend is way simpler than execlist, much easier to understand, and therefore much easier to maintain. It's a net win for i915 and Linux. Jon _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx