From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FF0C07E99 for ; Mon, 5 Jul 2021 05:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAF83613E2 for ; Mon, 5 Jul 2021 05:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229788AbhGEFOE (ORCPT ); Mon, 5 Jul 2021 01:14:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58913 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbhGEFOD (ORCPT ); Mon, 5 Jul 2021 01:14:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625461886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Budpf1Mgf5nAGlE4gIILC+M5chaMjcLyULIkUSMyGOQ=; b=RzVE/WHoljTfRladME/XfA6xPnsyDV8PuFoiCCdewkvruhUz5OZluiKejIONh7Fs03ITJ5 qg/XY1JDx8sCF80nRrahWxUfRmGPh/QjDsV1i/rxiCWdC7XZsOENQbi96F+Q69cJVZOBxw FHXXcGLI5nEChKOz9gDsOZ/utQviW98= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-HijqptyeNduG1VZtuxdtIw-1; Mon, 05 Jul 2021 01:11:24 -0400 X-MC-Unique: HijqptyeNduG1VZtuxdtIw-1 Received: by mail-pg1-f197.google.com with SMTP id k9-20020a63d1090000b029021091ebb84cso12813717pgg.3 for ; Sun, 04 Jul 2021 22:11:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Budpf1Mgf5nAGlE4gIILC+M5chaMjcLyULIkUSMyGOQ=; b=b+Wl3iv2DQkBB/qKvxDhyVaKg4Pe4sxNPQsKJPdAiHLpat9aUn6Cz6REdTyyPII03y KTiVD+nf9QswYimEdcX9CmYueYnot9ezd1GZw8Wsx9QWFqKprNkcIwTuwi1Ih4EUBg0A kYIb0lBbT4SZauc2v/ehUzr8dfRcOT/U/CHyrH2IrtbAyPp0I+YpT0tcrNYxHjySvEgN uCMJE+6iCX8JhxSytQMMh7HLyebVF+5zJ+tkJoojezhMlHlfyJrRoFUwb+IsxyO4So+a +Oupyj5y18BZcPGvqjCxPIy/UycVYVEHRhzqLfKPvRLGkor8XPw4vbi2nORvHhm/Xrv8 TrfQ== X-Gm-Message-State: AOAM532PH81uL/t0/81Y5hFNKjRC846k8vDBhBJry5FLZzEqoOLNW4pa FsFpc6Slg7V6iut7qCIoQXJyegJHv/O2NGhd9H8hnCY2O1hF3CXg466flN0AZVJ1CsH04F2HdtB Ebh/vzm9qJj/KAhLiRWqJ3m2IcKFlekk5KsS4UQkOZxnaBVhfrmVbW1Z+BgfW1Y7ANtr8oUHD/9 RX X-Received: by 2002:a17:902:650d:b029:129:6334:8c4a with SMTP id b13-20020a170902650db029012963348c4amr9272388plk.20.1625461883671; Sun, 04 Jul 2021 22:11:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJCFGroygE7vEijZr/eaDJsT7meM9aLfG/XFfEYs3JYtEA2L8QESskXuh0Yg60Cy5TejmAqA== X-Received: by 2002:a17:902:650d:b029:129:6334:8c4a with SMTP id b13-20020a170902650db029012963348c4amr9272365plk.20.1625461883324; Sun, 04 Jul 2021 22:11:23 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id r10sm12442127pga.48.2021.07.04.22.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jul 2021 22:11:22 -0700 (PDT) Subject: Re: [RFC PATCH] vhost-vdpa: mark vhost device invalid to reflect vdpa device unregistration From: Jason Wang To: gautam.dawar@xilinx.com Cc: martinh@xilinx.com, hanand@xilinx.com, gdawar@xilinx.com, "Michael S. Tsirkin" , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210704205205.6132-1-gdawar@xilinx.com> <3d02b8f5-0a6b-e8d1-533d-8503da3fcc4e@redhat.com> Message-ID: Date: Mon, 5 Jul 2021 13:11:18 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3d02b8f5-0a6b-e8d1-533d-8503da3fcc4e@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/7/5 上午11:48, Jason Wang 写道: > > 在 2021/7/5 上午4:52, gautam.dawar@xilinx.com 写道: >>       vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); >> @@ -1091,11 +1122,13 @@ static void vhost_vdpa_remove(struct >> vdpa_device *vdpa) >>           opened = atomic_cmpxchg(&v->opened, 0, 1); >>           if (!opened) >>               break; >> -        wait_for_completion_timeout(&v->completion, >> -                        msecs_to_jiffies(1000)); >> -        dev_warn_once(&v->dev, >> -                  "%s waiting for/dev/%s to be closed\n", >> -                  __func__, dev_name(&v->dev)); >> +        if (!wait_for_completion_timeout(&v->completion, >> +                        msecs_to_jiffies(1000))) { >> +            dev_warn(&v->dev, >> +                 "%s/dev/%s in use, continue..\n", >> +                 __func__, dev_name(&v->dev)); >> +            break; >> +        } >>       } while (1); >>         put_device(&v->dev); >> +    v->dev_invalid = true; > > > Besides the mapping handling mentioned by Michael. I think this can > lead use-after-free. put_device may release the memory. > > Another fundamental issue, vDPA is the parent of vhost-vDPA device. > I'm not sure the device core can allow the parent to go away first. Or this probably means you need couple the fd loosely with the vhost-vDPA device. Thanks > > Thanks > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CABC07E98 for ; Mon, 5 Jul 2021 05:11:31 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2B09613E2 for ; Mon, 5 Jul 2021 05:11:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2B09613E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6AD5260591; Mon, 5 Jul 2021 05:11:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZnvK1vf3HkIQ; Mon, 5 Jul 2021 05:11:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0AE3D60586; Mon, 5 Jul 2021 05:11:28 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D1DDEC001A; Mon, 5 Jul 2021 05:11:28 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 80886C000E for ; Mon, 5 Jul 2021 05:11:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5211D83A1C for ; Mon, 5 Jul 2021 05:11:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sX9Jqua5fkZw for ; Mon, 5 Jul 2021 05:11:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9F77E839DD for ; Mon, 5 Jul 2021 05:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625461885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Budpf1Mgf5nAGlE4gIILC+M5chaMjcLyULIkUSMyGOQ=; b=eEeHdGLHUR8XuithS7p8ZYAmuf9+sKjwgMcyn4rvr3+AxTdfssLTIkPGQVCsXxzXpm4knH +De/D3SdunPJ1qb5eywBeVzLpPrvipbWZ+xZht0+syS/Xzx6HplKtz1BcFQH4EZqaJ8mN3 O6cYrXYFeeS3Rnb6uckDBOq+vaRUVPI= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-6iJkBZ5GNPuWuoxLUAhPnw-1; Mon, 05 Jul 2021 01:11:24 -0400 X-MC-Unique: 6iJkBZ5GNPuWuoxLUAhPnw-1 Received: by mail-pg1-f199.google.com with SMTP id n21-20020a6563d50000b029022866cd1f17so7035140pgv.10 for ; Sun, 04 Jul 2021 22:11:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Budpf1Mgf5nAGlE4gIILC+M5chaMjcLyULIkUSMyGOQ=; b=HLUFK3SjiWELUW8+QsvDHblYwxXjCJfwK4VmqUu0+EpcoGqQ63q0QVeUsugvFn1RGs CsdgpEZH6PSXdITD42MTb9mvoY0Jf3j2rO8YCNR+/7zteh9DddrGi0FE7B25/sFuGrKO oLXcbrtVldcyKZseuqvykfFMlJXkMMxVr7hnUYW0SQOY8p1RIwngYmSMaYWUus7Jap8B vWCTpVuLHXU1HtcBBgKcjC977S8vSlBQ2mnrFvSd6/e0/O5EDfYRMRvMIbLH/myl+X7t QNHVlvf1jIuYLDfGz50RCVsvXg2cAj2f8VvRB7lJULdy2JgRH6I1ohF6VXJrkEfu/vlc NnEw== X-Gm-Message-State: AOAM533uzpHeLRwBLtG8poKCG91tcjOh/jSx7gAb/CvgkMkkEk+BU3FZ ZoOf1zVFBRk39+oWHCgzFQK7pVXWauwI58Mzw2Pxg2d1zlKOvvc70lnz8HFRV71Ar1XFWhXJrPD +Bx6odgNfiLvnp9B89noETr5MfIuibp8JrNQ3D9/rDw== X-Received: by 2002:a17:902:650d:b029:129:6334:8c4a with SMTP id b13-20020a170902650db029012963348c4amr9272374plk.20.1625461883503; Sun, 04 Jul 2021 22:11:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJCFGroygE7vEijZr/eaDJsT7meM9aLfG/XFfEYs3JYtEA2L8QESskXuh0Yg60Cy5TejmAqA== X-Received: by 2002:a17:902:650d:b029:129:6334:8c4a with SMTP id b13-20020a170902650db029012963348c4amr9272365plk.20.1625461883324; Sun, 04 Jul 2021 22:11:23 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id r10sm12442127pga.48.2021.07.04.22.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jul 2021 22:11:22 -0700 (PDT) Subject: Re: [RFC PATCH] vhost-vdpa: mark vhost device invalid to reflect vdpa device unregistration From: Jason Wang To: gautam.dawar@xilinx.com References: <20210704205205.6132-1-gdawar@xilinx.com> <3d02b8f5-0a6b-e8d1-533d-8503da3fcc4e@redhat.com> Message-ID: Date: Mon, 5 Jul 2021 13:11:18 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3d02b8f5-0a6b-e8d1-533d-8503da3fcc4e@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gdawar@xilinx.com, virtualization@lists.linux-foundation.org, martinh@xilinx.com, hanand@xilinx.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIxLzcvNSDkuIrljYgxMTo0OCwgSmFzb24gV2FuZyDlhpnpgZM6Cj4KPiDlnKggMjAy MS83LzUg5LiK5Y2INDo1MiwgZ2F1dGFtLmRhd2FyQHhpbGlueC5jb20g5YaZ6YGTOgo+PiDCoMKg wqDCoMKgIHZtYS0+dm1fcGFnZV9wcm90ID0gcGdwcm90X25vbmNhY2hlZCh2bWEtPnZtX3BhZ2Vf cHJvdCk7Cj4+IEBAIC0xMDkxLDExICsxMTIyLDEzIEBAIHN0YXRpYyB2b2lkIHZob3N0X3ZkcGFf cmVtb3ZlKHN0cnVjdCAKPj4gdmRwYV9kZXZpY2UgKnZkcGEpCj4+IMKgwqDCoMKgwqDCoMKgwqDC oCBvcGVuZWQgPSBhdG9taWNfY21weGNoZygmdi0+b3BlbmVkLCAwLCAxKTsKPj4gwqDCoMKgwqDC oMKgwqDCoMKgIGlmICghb3BlbmVkKQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBicmVh azsKPj4gLcKgwqDCoMKgwqDCoMKgIHdhaXRfZm9yX2NvbXBsZXRpb25fdGltZW91dCgmdi0+Y29t cGxldGlvbiwKPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgbXNlY3NfdG9famlmZmllcygxMDAwKSk7Cj4+IC3CoMKgwqDCoMKgwqDCoCBkZXZfd2Fybl9v bmNlKCZ2LT5kZXYsCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICIlcyB3 YWl0aW5nIGZvci9kZXYvJXMgdG8gYmUgY2xvc2VkXG4iLAo+PiAtwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBfX2Z1bmNfXywgZGV2X25hbWUoJnYtPmRldikpOwo+PiArwqDCoMKg wqDCoMKgwqAgaWYgKCF3YWl0X2Zvcl9jb21wbGV0aW9uX3RpbWVvdXQoJnYtPmNvbXBsZXRpb24s Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG1zZWNz X3RvX2ppZmZpZXMoMTAwMCkpKSB7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRldl93YXJu KCZ2LT5kZXYsCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiJXMvZGV2LyVz IGluIHVzZSwgY29udGludWUuLlxuIiwKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIF9fZnVuY19fLCBkZXZfbmFtZSgmdi0+ZGV2KSk7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGJyZWFrOwo+PiArwqDCoMKgwqDCoMKgwqAgfQo+PiDCoMKgwqDCoMKgIH0gd2hpbGUgKDEp Owo+PiDCoCDCoMKgwqDCoMKgIHB1dF9kZXZpY2UoJnYtPmRldik7Cj4+ICvCoMKgwqAgdi0+ZGV2 X2ludmFsaWQgPSB0cnVlOwo+Cj4KPiBCZXNpZGVzIHRoZSBtYXBwaW5nIGhhbmRsaW5nIG1lbnRp b25lZCBieSBNaWNoYWVsLiBJIHRoaW5rIHRoaXMgY2FuIAo+IGxlYWQgdXNlLWFmdGVyLWZyZWUu IHB1dF9kZXZpY2UgbWF5IHJlbGVhc2UgdGhlIG1lbW9yeS4KPgo+IEFub3RoZXIgZnVuZGFtZW50 YWwgaXNzdWUsIHZEUEEgaXMgdGhlIHBhcmVudCBvZiB2aG9zdC12RFBBIGRldmljZS4gCj4gSSdt IG5vdCBzdXJlIHRoZSBkZXZpY2UgY29yZSBjYW4gYWxsb3cgdGhlIHBhcmVudCB0byBnbyBhd2F5 IGZpcnN0LgoKCk9yIHRoaXMgcHJvYmFibHkgbWVhbnMgeW91IG5lZWQgY291cGxlIHRoZSBmZCBs b29zZWx5IHdpdGggdGhlIAp2aG9zdC12RFBBIGRldmljZS4KClRoYW5rcwoKCj4KPiBUaGFua3MK Pgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0 dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRh dGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGlu Zm8vdmlydHVhbGl6YXRpb24=