All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH] test-char: fix AddressSanitizer failure
Date: Mon, 9 Sep 2019 15:08:28 +0200	[thread overview]
Message-ID: <d3a4c936-89db-710f-7116-b1f5b77a205f@redhat.com> (raw)
In-Reply-To: <20190909130655.24495-1-pbonzini@redhat.com>

On 9/9/19 3:06 PM, Paolo Bonzini wrote:
> The CharSocketServerTestConfig and CharSocketClientTestConfig
> objects escape after they are passed to g_test_add_data_func,
> but they cease existing after the scope that defines them is
> closed.  Make them static to fix this issue.
> 
> Fixes: e7b6ba4186f243f149b0d8cddc129fe681ba3912
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  tests/test-char.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/test-char.c b/tests/test-char.c
> index f3ebdffd87..525a476b89 100644
> --- a/tests/test-char.c
> +++ b/tests/test-char.c
> @@ -1403,13 +1403,13 @@ int main(int argc, char **argv)
>  #endif
>  
>  #define SOCKET_SERVER_TEST(name, addr)                                  \
> -    CharSocketServerTestConfig server1 ## name =                        \
> +    static CharSocketServerTestConfig server1 ## name =                 \
>          { addr, false, false };                                         \
> -    CharSocketServerTestConfig server2 ## name =                        \
> +    static CharSocketServerTestConfig server2 ## name =                 \
>          { addr, true, false };                                          \
> -    CharSocketServerTestConfig server3 ## name =                        \
> +    static CharSocketServerTestConfig server3 ## name =                 \
>          { addr, false, true };                                          \
> -    CharSocketServerTestConfig server4 ## name =                        \
> +    static CharSocketServerTestConfig server4 ## name =                 \
>          { addr, true, true };                                           \
>      g_test_add_data_func("/char/socket/server/mainloop/" # name,        \
>                           &server1 ##name, char_socket_server_test);     \
> @@ -1421,17 +1421,17 @@ int main(int argc, char **argv)
>                           &server4 ##name, char_socket_server_test)
>  
>  #define SOCKET_CLIENT_TEST(name, addr)                                  \
> -    CharSocketClientTestConfig client1 ## name =                        \
> +    static CharSocketClientTestConfig client1 ## name =                 \
>          { addr, NULL, false, false };                                   \
> -    CharSocketClientTestConfig client2 ## name =                        \
> +    static CharSocketClientTestConfig client2 ## name =                 \
>          { addr, NULL, true, false };                                    \
> -    CharSocketClientTestConfig client3 ## name =                        \
> +    static CharSocketClientTestConfig client3 ## name =                 \
>          { addr, ",reconnect=1", false };                                \
> -    CharSocketClientTestConfig client4 ## name =                        \
> +    static CharSocketClientTestConfig client4 ## name =                 \
>          { addr, ",reconnect=1", true };                                 \
> -    CharSocketClientTestConfig client5 ## name =                        \
> +    static CharSocketClientTestConfig client5 ## name =                 \
>          { addr, NULL, false, true };                                    \
> -    CharSocketClientTestConfig client6 ## name =                        \
> +    static CharSocketClientTestConfig client6 ## name =                 \
>          { addr, NULL, true, true };                                     \
>      g_test_add_data_func("/char/socket/client/mainloop/" # name,        \
>                           &client1 ##name, char_socket_client_test);     \
> 


  reply	other threads:[~2019-09-09 13:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 13:06 [Qemu-devel] [PATCH] test-char: fix AddressSanitizer failure Paolo Bonzini
2019-09-09 13:08 ` Philippe Mathieu-Daudé [this message]
2019-09-09 13:22 ` Daniel P. Berrangé
2019-09-09 14:15 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3a4c936-89db-710f-7116-b1f5b77a205f@redhat.com \
    --to=philmd@redhat.com \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.