From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A152C433DB for ; Mon, 1 Feb 2021 11:01:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9704B64E97 for ; Mon, 1 Feb 2021 11:01:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9704B64E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6WxM-0003EI-9c for qemu-devel@archiver.kernel.org; Mon, 01 Feb 2021 06:01:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6Ww6-0002gB-Uw for qemu-devel@nongnu.org; Mon, 01 Feb 2021 06:00:04 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:55879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6Ww1-0003VX-EH for qemu-devel@nongnu.org; Mon, 01 Feb 2021 06:00:01 -0500 Received: by mail-wm1-x329.google.com with SMTP id f16so12234954wmq.5 for ; Mon, 01 Feb 2021 02:59:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KE6pn1XLuZ35zO3PqK0E652tTHU9fRPfHroHeNP+mqs=; b=k8M1PI5PBfrYYPekh/jrTDQwU/rOaxV2QKr0Hn6vWm+QG3GeFyY7H+sJuPhHsBw2wa wulgnY4lgkmywg979X9tkQveWnWgx4/Jt/qV+qMmZ1PsIoFXPINHPBTw/7m0rAnAMbMD T3ej0P6cCJYXUx9iIp5mCI3ID9Z8bI7r/t6BMgf2hxRoTtrCOF8Ng4IFTgHzylfKKBQO TRJllt+Ux3Fruw84BDcCZhFNvzDwKTQj3QkF3ahTxr+AHG+11xPZ4pW499AJ3AE9n8Mu HgS4B1h0wM1kGKL69Q/u3dzajqNgLUbGAsm7feYngoDKeSZ1cEHuuB38xbZp02SjJlvS PNIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KE6pn1XLuZ35zO3PqK0E652tTHU9fRPfHroHeNP+mqs=; b=etroDkaCRKp1HRm2b9/VwrLCEOUwGnwX9p0JqpSRYsGNUD8N+ABRNYFWhEZnIlgQ6S zsjCmsax3FC9WejTaR3LzOLv9EuDwCJOwWB7NW223bSxiq5hvgI63ZwKtkgSt7A9aHw6 MPMDbbesO4wnfCyl+ZZXyPPq/LLax3Qx1DB5J7lnZ+D++YAT4FmTUlGtggzFvetJF+OI ZiQkkwh+YG+Ci7DO+iv6yeu99/UM1KgUT6BG/gQEm1ckLEoUe990iJyusG9CEX3R5G8t CHAGVNlqX2oQ9Y4cpFcHwYFh1t1TsLwucs9PuHgF0mT0MU3dTQ/P8Tkw8gm1Wg75QH+K fNog== X-Gm-Message-State: AOAM533GrVwQ86oA3Qngc6pB2W24ZM3rndnMDj1ZKfMATz+RuGXLXdYP QQiJ1nsBpVnIdf1Bu0OdFHQ= X-Google-Smtp-Source: ABdhPJx1kGiUfZp6OECVM9HcEU2ro/EqkyZTE/nUfkUseg0RWzzAejKdnqSZZFYlYi0EmovqBovjXA== X-Received: by 2002:a05:600c:4f07:: with SMTP id l7mr9122348wmq.111.1612177195926; Mon, 01 Feb 2021 02:59:55 -0800 (PST) Received: from [192.168.1.36] (7.red-83-57-171.dynamicip.rima-tde.net. [83.57.171.7]) by smtp.gmail.com with ESMTPSA id o17sm26583745wrm.52.2021.02.01.02.59.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Feb 2021 02:59:55 -0800 (PST) Subject: Re: [PATCH v2 3/4] hw/xen/Kconfig: Introduce XEN_PV config To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org, Paolo Bonzini References: <20210131141810.293186-1-f4bug@amsat.org> <20210131141810.293186-4-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 1 Feb 2021 11:59:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210131141810.293186-4-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.079, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , Paul Durrant , Richard Henderson , Anthony Perard , xen-devel@lists.xenproject.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/31/21 3:18 PM, Philippe Mathieu-Daudé wrote: > xenpv machine requires USB, IDE_PIIX and PCI: > > /usr/bin/ld: > libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common': > hw/xen/xen-legacy-backend.c:757: undefined reference to `xen_usb_ops' > libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function `unplug_disks': > hw/i386/xen/xen_platform.c:153: undefined reference to `pci_piix3_xen_ide_unplug' > libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function `pci_unplug_nics': > hw/i386/xen/xen_platform.c:137: undefined reference to `pci_for_each_device' > libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function `xen_platform_realize': > hw/i386/xen/xen_platform.c:483: undefined reference to `pci_register_bar' > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/Kconfig | 1 + > hw/xen/Kconfig | 7 +++++++ > 2 files changed, 8 insertions(+) > create mode 100644 hw/xen/Kconfig > > diff --git a/hw/Kconfig b/hw/Kconfig > index 5ad3c6b5a4b..f2a95591d94 100644 > --- a/hw/Kconfig > +++ b/hw/Kconfig > @@ -39,6 +39,7 @@ source usb/Kconfig > source virtio/Kconfig > source vfio/Kconfig > source watchdog/Kconfig > +source xen/Kconfig > > # arch Kconfig > source arm/Kconfig > diff --git a/hw/xen/Kconfig b/hw/xen/Kconfig > new file mode 100644 > index 00000000000..0b8427d6bd1 > --- /dev/null > +++ b/hw/xen/Kconfig > @@ -0,0 +1,7 @@ > +config XEN_PV > + bool > + default y if XEN > + depends on XEN > + select PCI > + select USB > + select IDE_PIIX Well this is not enough, --without-default-devices fails: /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_physmem.c.o: in function `cpu_physical_memory_set_dirty_range': include/exec/ram_addr.h:333: undefined reference to `xen_hvm_modified_memory' /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_physmem.c.o: in function `ram_block_add': softmmu/physmem.c:1873: undefined reference to `xen_ram_alloc' /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_physmem.c.o: in function `cpu_physical_memory_set_dirty_range': include/exec/ram_addr.h:333: undefined reference to `xen_hvm_modified_memory' /usr/bin/ld: include/exec/ram_addr.h:333: undefined reference to `xen_hvm_modified_memory' /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_memory.c.o: in function `cpu_physical_memory_set_dirty_range': include/exec/ram_addr.h:333: undefined reference to `xen_hvm_modified_memory' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E949DC433DB for ; Mon, 1 Feb 2021 11:00:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ED8464E56 for ; Mon, 1 Feb 2021 11:00:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ED8464E56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.79746.145195 (Exim 4.92) (envelope-from ) id 1l6Ww3-0007Wj-9A; Mon, 01 Feb 2021 10:59:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 79746.145195; Mon, 01 Feb 2021 10:59:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6Ww3-0007Wc-55; Mon, 01 Feb 2021 10:59:59 +0000 Received: by outflank-mailman (input) for mailman id 79746; Mon, 01 Feb 2021 10:59:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6Ww2-0007WW-Jm for xen-devel@lists.xenproject.org; Mon, 01 Feb 2021 10:59:58 +0000 Received: from mail-wm1-x332.google.com (unknown [2a00:1450:4864:20::332]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 11be89a7-ad55-4b43-96e4-e83228935551; Mon, 01 Feb 2021 10:59:57 +0000 (UTC) Received: by mail-wm1-x332.google.com with SMTP id y187so12786279wmd.3 for ; Mon, 01 Feb 2021 02:59:56 -0800 (PST) Received: from [192.168.1.36] (7.red-83-57-171.dynamicip.rima-tde.net. [83.57.171.7]) by smtp.gmail.com with ESMTPSA id o17sm26583745wrm.52.2021.02.01.02.59.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Feb 2021 02:59:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 11be89a7-ad55-4b43-96e4-e83228935551 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KE6pn1XLuZ35zO3PqK0E652tTHU9fRPfHroHeNP+mqs=; b=k8M1PI5PBfrYYPekh/jrTDQwU/rOaxV2QKr0Hn6vWm+QG3GeFyY7H+sJuPhHsBw2wa wulgnY4lgkmywg979X9tkQveWnWgx4/Jt/qV+qMmZ1PsIoFXPINHPBTw/7m0rAnAMbMD T3ej0P6cCJYXUx9iIp5mCI3ID9Z8bI7r/t6BMgf2hxRoTtrCOF8Ng4IFTgHzylfKKBQO TRJllt+Ux3Fruw84BDcCZhFNvzDwKTQj3QkF3ahTxr+AHG+11xPZ4pW499AJ3AE9n8Mu HgS4B1h0wM1kGKL69Q/u3dzajqNgLUbGAsm7feYngoDKeSZ1cEHuuB38xbZp02SjJlvS PNIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KE6pn1XLuZ35zO3PqK0E652tTHU9fRPfHroHeNP+mqs=; b=hHHL9Olv0KSSgLe1nkoYgdSZzKQBJ0v4vOx/2hxezbgJE8ivrw3kyK0uI0VdvR2wvE 7RvK13WttQ9UtzOmFDmZHJf281krOzPmO34vfA7X3Rhy+oUfsYHCLLd7GneA3IprGcpE 3TectrBR1isFb1Fxcv0Ip8ZEanTWvIrTyM6PIWSRQi9QH0XGy9pX2+jEBWC3IPJ4Oy9l 0SEjgTSq3fYxW8wN9Xwssi+84rpW085RVEfNDzhWWxAeDPSsIiznoCs7uNmyYR3k1LmV 7D9dcU0qAey/NlQCFP0xxE8AHQi5yRDheU61xSvCie+sCGkQpr3kEKIzbm3oRcH+DJ7r 4NiQ== X-Gm-Message-State: AOAM5309lIKeMBLMC63t4n3oALeBQw5AFA9V+IORvuVG/bfkFmalIUpg 5cjfE5N8g5ikP9MIcT3fkAs= X-Google-Smtp-Source: ABdhPJx1kGiUfZp6OECVM9HcEU2ro/EqkyZTE/nUfkUseg0RWzzAejKdnqSZZFYlYi0EmovqBovjXA== X-Received: by 2002:a05:600c:4f07:: with SMTP id l7mr9122348wmq.111.1612177195926; Mon, 01 Feb 2021 02:59:55 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH v2 3/4] hw/xen/Kconfig: Introduce XEN_PV config To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org, Paolo Bonzini Cc: Stefano Stabellini , Eduardo Habkost , Paul Durrant , "Michael S. Tsirkin" , Richard Henderson , xen-devel@lists.xenproject.org, Anthony Perard References: <20210131141810.293186-1-f4bug@amsat.org> <20210131141810.293186-4-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 1 Feb 2021 11:59:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210131141810.293186-4-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 1/31/21 3:18 PM, Philippe Mathieu-Daudé wrote: > xenpv machine requires USB, IDE_PIIX and PCI: > > /usr/bin/ld: > libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common': > hw/xen/xen-legacy-backend.c:757: undefined reference to `xen_usb_ops' > libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function `unplug_disks': > hw/i386/xen/xen_platform.c:153: undefined reference to `pci_piix3_xen_ide_unplug' > libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function `pci_unplug_nics': > hw/i386/xen/xen_platform.c:137: undefined reference to `pci_for_each_device' > libqemu-i386-softmmu.fa.p/hw_i386_xen_xen_platform.c.o: in function `xen_platform_realize': > hw/i386/xen/xen_platform.c:483: undefined reference to `pci_register_bar' > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/Kconfig | 1 + > hw/xen/Kconfig | 7 +++++++ > 2 files changed, 8 insertions(+) > create mode 100644 hw/xen/Kconfig > > diff --git a/hw/Kconfig b/hw/Kconfig > index 5ad3c6b5a4b..f2a95591d94 100644 > --- a/hw/Kconfig > +++ b/hw/Kconfig > @@ -39,6 +39,7 @@ source usb/Kconfig > source virtio/Kconfig > source vfio/Kconfig > source watchdog/Kconfig > +source xen/Kconfig > > # arch Kconfig > source arm/Kconfig > diff --git a/hw/xen/Kconfig b/hw/xen/Kconfig > new file mode 100644 > index 00000000000..0b8427d6bd1 > --- /dev/null > +++ b/hw/xen/Kconfig > @@ -0,0 +1,7 @@ > +config XEN_PV > + bool > + default y if XEN > + depends on XEN > + select PCI > + select USB > + select IDE_PIIX Well this is not enough, --without-default-devices fails: /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_physmem.c.o: in function `cpu_physical_memory_set_dirty_range': include/exec/ram_addr.h:333: undefined reference to `xen_hvm_modified_memory' /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_physmem.c.o: in function `ram_block_add': softmmu/physmem.c:1873: undefined reference to `xen_ram_alloc' /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_physmem.c.o: in function `cpu_physical_memory_set_dirty_range': include/exec/ram_addr.h:333: undefined reference to `xen_hvm_modified_memory' /usr/bin/ld: include/exec/ram_addr.h:333: undefined reference to `xen_hvm_modified_memory' /usr/bin/ld: libqemu-x86_64-softmmu.fa.p/softmmu_memory.c.o: in function `cpu_physical_memory_set_dirty_range': include/exec/ram_addr.h:333: undefined reference to `xen_hvm_modified_memory' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed.