From: Eric Sandeen <esandeen@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>, sandeen@sandeen.net
Cc: linux-xfs@vger.kernel.org, allison.henderson@oracle.com
Subject: Re: [PATCH 1/2] xfs_scrub: fix xfrog_scrub_metadata error reporting
Date: Wed, 16 Mar 2022 12:50:20 -0500 [thread overview]
Message-ID: <d3be9080-3fca-9e4b-8eb5-4495df4c4040@redhat.com> (raw)
In-Reply-To: <164738659344.3191772.10477029754314882992.stgit@magnolia>
On 3/15/22 6:23 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Commit de5d20ec converted xfrog_scrub_metadata to return negative error
> codes directly, but forgot to fix up the str_errno calls to use
> str_liberror. This doesn't result in incorrect error reporting
> currently, but (a) the calls in the switch statement are inconsistent,
> and (b) this will matter in future patches where we can call library
> functions in between xfrog_scrub_metadata and str_liberror.
>
> Fixes: de5d20ec ("libfrog: convert scrub.c functions to negative error codes")
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
wow how could you possibly have forgotten the difference between
str_errno, str_liberror, and str_error? ;)
So the net effect here is sending our own error, not errno. Looks right.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
next prev parent reply other threads:[~2022-03-16 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 23:23 [PATCHSET 0/2] xfsprogs: various 5.15 fixes Darrick J. Wong
2022-03-15 23:23 ` [PATCH 1/2] xfs_scrub: fix xfrog_scrub_metadata error reporting Darrick J. Wong
2022-03-16 17:50 ` Eric Sandeen [this message]
2022-03-15 23:23 ` [PATCH 2/2] xfs_scrub: retry scrub (and repair) of items that are ok except for XFAIL Darrick J. Wong
2022-03-16 18:10 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3be9080-3fca-9e4b-8eb5-4495df4c4040@redhat.com \
--to=esandeen@redhat.com \
--cc=allison.henderson@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.