From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbdCQDXa (ORCPT ); Thu, 16 Mar 2017 23:23:30 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3898 "EHLO dggrg02-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750970AbdCQDX2 (ORCPT ); Thu, 16 Mar 2017 23:23:28 -0400 Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: don't allow atomic writes for not regular files To: Jaegeuk Kim , , , References: <20170317020906.28165-1-jaegeuk@kernel.org> <20170317020906.28165-2-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Fri, 17 Mar 2017 11:23:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170317020906.28165-2-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.58CB56A6.0282,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d275c0e918d688df512123bd7bd23627 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/3/17 10:09, Jaegeuk Kim wrote: > The atomic writes only supports regular files for database. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/file.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index da6d33d1bb34..d486e02b43c2 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -1522,6 +1522,9 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) > if (f2fs_is_atomic_file(inode)) > goto out; > > + if (!S_ISREG(inode->i_mode)) > + return -EINVAL; goto out; Thanks, > + > ret = f2fs_convert_inline_inode(inode); > if (ret) > goto out; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH 2/2] f2fs: don't allow atomic writes for not regular files Date: Fri, 17 Mar 2017 11:23:14 +0800 Message-ID: References: <20170317020906.28165-1-jaegeuk@kernel.org> <20170317020906.28165-2-jaegeuk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1coiUf-0002xF-HF for linux-f2fs-devel@lists.sourceforge.net; Fri, 17 Mar 2017 03:23:57 +0000 Received: from [45.249.212.188] (helo=dggrg02-dlp.huawei.com) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1coiUd-0006ze-U1 for linux-f2fs-devel@lists.sourceforge.net; Fri, 17 Mar 2017 03:23:57 +0000 In-Reply-To: <20170317020906.28165-2-jaegeuk@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net On 2017/3/17 10:09, Jaegeuk Kim wrote: > The atomic writes only supports regular files for database. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/file.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index da6d33d1bb34..d486e02b43c2 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -1522,6 +1522,9 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) > if (f2fs_is_atomic_file(inode)) > goto out; > > + if (!S_ISREG(inode->i_mode)) > + return -EINVAL; goto out; Thanks, > + > ret = f2fs_convert_inline_inode(inode); > if (ret) > goto out; > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot