From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23236C433EF for ; Fri, 15 Oct 2021 22:08:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B00561163 for ; Fri, 15 Oct 2021 22:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243278AbhJOWKn (ORCPT ); Fri, 15 Oct 2021 18:10:43 -0400 Received: from sibelius.xs4all.nl ([83.163.83.176]:63365 "EHLO sibelius.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243168AbhJOWKh (ORCPT ); Fri, 15 Oct 2021 18:10:37 -0400 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 1702a20a; Sat, 16 Oct 2021 00:08:25 +0200 (CEST) Date: Sat, 16 Oct 2021 00:08:25 +0200 (CEST) From: Mark Kettenis To: Stephen Boyd Cc: pali@kernel.org, gregkh@linuxfoundation.org, mturquette@baylibre.com, robh+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, vladimir.vid@sartura.hr, kabel@kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <163433494758.1688384.5994009027317282677@swboyd.mtv.corp.google.com> (message from Stephen Boyd on Fri, 15 Oct 2021 14:55:47 -0700) Subject: Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock References: <20210930095838.28145-1-pali@kernel.org> <20210930095838.28145-4-pali@kernel.org> <163425678347.1688384.10695189000353676651@swboyd.mtv.corp.google.com> <20211015090937.gnt66hgugrhwnkei@pali> <20211015093701.pfvkighxsndj4ujg@pali> <163433494758.1688384.5994009027317282677@swboyd.mtv.corp.google.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Stephen Boyd > Date: Fri, 15 Oct 2021 14:55:47 -0700 > > Quoting Pali Rohár (2021-10-15 02:37:01) > > On Friday 15 October 2021 11:09:37 Pali Rohár wrote: > > > On Thursday 14 October 2021 17:13:03 Stephen Boyd wrote: > > > > Quoting Pali Rohár (2021-09-30 02:58:35) > > > > > diff --git a/Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml b/Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml > > > > > new file mode 100644 > > > > > index 000000000000..175f5c8f2bc5 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml > > > > > @@ -0,0 +1,59 @@ > > > > [..] > > > > > + '#clock-cells': > > > > > + const: 1 > > > > > + > > > > > +required: > > > > > + - compatible > > > > > + - reg > > > > > + - clocks > > > > > + - clock-names > > > > > + - '#clock-cells' > > > > > + > > > > > +additionalProperties: false > > > > > + > > > > > +examples: > > > > > + - | > > > > > + uartclk: clock-controller@12010 { > > > > > > > > The uart device is at 0x12000 and the clock-controller is at 0x12010? > > > > This looks like a node is being put into DT to represent a clk driver. > > > > Why can't we register a clk from the uart device driver itself? I think > > > > we talked about this a month or two ago but it still isn't clear to me. > > > > > > We have already talked about it and I have already wrote reasons. UART > > > clk is shared for both UART1 and UART2. And UART clk regs are in both > > > address spaces of UART1 and UART2. UART1 or UART2 can be independently > > > disabled on particular board (as pins are MPP which may be configured to > > > different function). So you have a board only with UART2, you have to > > > disable UART1 node, but at the same time you have to access UART clk to > > > drive UART2. And UART clk bits are in UART1 address space. > > > > It is explained also in commit message of patch 2/6. > > Cool, thanks for the pointer. > > Why are the two uarts split into different device nodes? It looks like > it's one device that was split into two nodes because they're fairly > similar hardware blocks, and one or the other may not be used on the > board so we want to use status = "disabled" to indicate that. Sadly the > hardware team has delivered them as a single package into the SoC at > address 0x12000 and then stuck a common clk for both uarts into the same > uart wrapper. Here's a clk, job done! > > Is it a problem to map UART1 address space when it isn't used on the > board? I'm trying to understand why it can't work to register two uart > ports from one device node and driver. Separate nodes are needed because stdin-path and stdout-patch need to be able to point at a specific device node. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89808C433F5 for ; Fri, 15 Oct 2021 22:09:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B10C60C4B for ; Fri, 15 Oct 2021 22:09:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B10C60C4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:MIME-version:References: Subject:In-Reply-To:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0OJajBFPCPVewqUBOLF1ZicfQcikS+OZYGZJ+8NLWas=; b=OTp+AiVfhWpCN3 /r3c9PRECc5PGiLXO+XVXRt2CmMbFpKzC46jplexECZI/F02CnVYOCcRB6jGDpJ0nmV08+n7beSBd cJvzOhOMnSLrheec54fQu5ccUKbAwKb4jxS858VI7jnKQY68yPn63GzI1P5n5N+QiHAZynKrTHXdx RBuAZcO2GExgctYlVmgGGkkDyiMWI7CHkp2KmcUAKvCK20U4RrgM9u5i6PDIrTf7SWPQ79FQ54C+P foEj7QJrFw9OMaNVTzGvd8g/NXQakjNlWF9Bjcx5l5LTiI/8bN1Kr9hmuDfEdsqKIKyABNgLUZRwx WkBckofXXigXa4u7RJzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbVNX-008vPa-4G; Fri, 15 Oct 2021 22:08:39 +0000 Received: from sibelius.xs4all.nl ([83.163.83.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbVNS-008vLR-7Z for linux-arm-kernel@lists.infradead.org; Fri, 15 Oct 2021 22:08:36 +0000 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 1702a20a; Sat, 16 Oct 2021 00:08:25 +0200 (CEST) Date: Sat, 16 Oct 2021 00:08:25 +0200 (CEST) From: Mark Kettenis To: Stephen Boyd Cc: pali@kernel.org, gregkh@linuxfoundation.org, mturquette@baylibre.com, robh+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, vladimir.vid@sartura.hr, kabel@kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <163433494758.1688384.5994009027317282677@swboyd.mtv.corp.google.com> (message from Stephen Boyd on Fri, 15 Oct 2021 14:55:47 -0700) Subject: Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock References: <20210930095838.28145-1-pali@kernel.org> <20210930095838.28145-4-pali@kernel.org> <163425678347.1688384.10695189000353676651@swboyd.mtv.corp.google.com> <20211015090937.gnt66hgugrhwnkei@pali> <20211015093701.pfvkighxsndj4ujg@pali> <163433494758.1688384.5994009027317282677@swboyd.mtv.corp.google.com> MIME-version: 1.0 Message-ID: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_150834_621204_5D5D54EE X-CRM114-Status: GOOD ( 32.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PiBGcm9tOiBTdGVwaGVuIEJveWQgPHNib3lkQGtlcm5lbC5vcmc+Cj4gRGF0ZTogRnJpLCAxNSBP Y3QgMjAyMSAxNDo1NTo0NyAtMDcwMAo+IAo+IFF1b3RpbmcgUGFsaSBSb2jDoXIgKDIwMjEtMTAt MTUgMDI6Mzc6MDEpCj4gPiBPbiBGcmlkYXkgMTUgT2N0b2JlciAyMDIxIDExOjA5OjM3IFBhbGkg Um9ow6FyIHdyb3RlOgo+ID4gPiBPbiBUaHVyc2RheSAxNCBPY3RvYmVyIDIwMjEgMTc6MTM6MDMg U3RlcGhlbiBCb3lkIHdyb3RlOgo+ID4gPiA+IFF1b3RpbmcgUGFsaSBSb2jDoXIgKDIwMjEtMDkt MzAgMDI6NTg6MzUpCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL2Nsb2NrL21hcnZlbGwsYXJtYWRhLTM3MDAtdWFydC1jbG9jay55YW1sIGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2NrL21hcnZlbGwsYXJtYWRhLTM3 MDAtdWFydC1jbG9jay55YW1sCj4gPiA+ID4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gPiA+ ID4gaW5kZXggMDAwMDAwMDAwMDAwLi4xNzVmNWM4ZjJiYzUKPiA+ID4gPiA+IC0tLSAvZGV2L251 bGwKPiA+ID4gPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9j ay9tYXJ2ZWxsLGFybWFkYS0zNzAwLXVhcnQtY2xvY2sueWFtbAo+ID4gPiA+ID4gQEAgLTAsMCAr MSw1OSBAQAo+ID4gPiA+IFsuLl0KPiA+ID4gPiA+ICsgICcjY2xvY2stY2VsbHMnOgo+ID4gPiA+ ID4gKyAgICBjb25zdDogMQo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gK3JlcXVpcmVkOgo+ID4gPiA+ ID4gKyAgLSBjb21wYXRpYmxlCj4gPiA+ID4gPiArICAtIHJlZwo+ID4gPiA+ID4gKyAgLSBjbG9j a3MKPiA+ID4gPiA+ICsgIC0gY2xvY2stbmFtZXMKPiA+ID4gPiA+ICsgIC0gJyNjbG9jay1jZWxs cycKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICthZGRpdGlvbmFsUHJvcGVydGllczogZmFsc2UKPiA+ ID4gPiA+ICsKPiA+ID4gPiA+ICtleGFtcGxlczoKPiA+ID4gPiA+ICsgIC0gfAo+ID4gPiA+ID4g KyAgICB1YXJ0Y2xrOiBjbG9jay1jb250cm9sbGVyQDEyMDEwIHsKPiA+ID4gPiAKPiA+ID4gPiBU aGUgdWFydCBkZXZpY2UgaXMgYXQgMHgxMjAwMCBhbmQgdGhlIGNsb2NrLWNvbnRyb2xsZXIgaXMg YXQgMHgxMjAxMD8KPiA+ID4gPiBUaGlzIGxvb2tzIGxpa2UgYSBub2RlIGlzIGJlaW5nIHB1dCBp bnRvIERUIHRvIHJlcHJlc2VudCBhIGNsayBkcml2ZXIuCj4gPiA+ID4gV2h5IGNhbid0IHdlIHJl Z2lzdGVyIGEgY2xrIGZyb20gdGhlIHVhcnQgZGV2aWNlIGRyaXZlciBpdHNlbGY/IEkgdGhpbmsK PiA+ID4gPiB3ZSB0YWxrZWQgYWJvdXQgdGhpcyBhIG1vbnRoIG9yIHR3byBhZ28gYnV0IGl0IHN0 aWxsIGlzbid0IGNsZWFyIHRvIG1lLgo+ID4gPiAKPiA+ID4gV2UgaGF2ZSBhbHJlYWR5IHRhbGtl ZCBhYm91dCBpdCBhbmQgSSBoYXZlIGFscmVhZHkgd3JvdGUgcmVhc29ucy4gVUFSVAo+ID4gPiBj bGsgaXMgc2hhcmVkIGZvciBib3RoIFVBUlQxIGFuZCBVQVJUMi4gQW5kIFVBUlQgY2xrIHJlZ3Mg YXJlIGluIGJvdGgKPiA+ID4gYWRkcmVzcyBzcGFjZXMgb2YgVUFSVDEgYW5kIFVBUlQyLiBVQVJU MSBvciBVQVJUMiBjYW4gYmUgaW5kZXBlbmRlbnRseQo+ID4gPiBkaXNhYmxlZCBvbiBwYXJ0aWN1 bGFyIGJvYXJkIChhcyBwaW5zIGFyZSBNUFAgd2hpY2ggbWF5IGJlIGNvbmZpZ3VyZWQgdG8KPiA+ ID4gZGlmZmVyZW50IGZ1bmN0aW9uKS4gU28geW91IGhhdmUgYSBib2FyZCBvbmx5IHdpdGggVUFS VDIsIHlvdSBoYXZlIHRvCj4gPiA+IGRpc2FibGUgVUFSVDEgbm9kZSwgYnV0IGF0IHRoZSBzYW1l IHRpbWUgeW91IGhhdmUgdG8gYWNjZXNzIFVBUlQgY2xrIHRvCj4gPiA+IGRyaXZlIFVBUlQyLiBB bmQgVUFSVCBjbGsgYml0cyBhcmUgaW4gVUFSVDEgYWRkcmVzcyBzcGFjZS4KPiA+IAo+ID4gSXQg aXMgZXhwbGFpbmVkIGFsc28gaW4gY29tbWl0IG1lc3NhZ2Ugb2YgcGF0Y2ggMi82Lgo+IAo+IENv b2wsIHRoYW5rcyBmb3IgdGhlIHBvaW50ZXIuCj4gCj4gV2h5IGFyZSB0aGUgdHdvIHVhcnRzIHNw bGl0IGludG8gZGlmZmVyZW50IGRldmljZSBub2Rlcz8gSXQgbG9va3MgbGlrZQo+IGl0J3Mgb25l IGRldmljZSB0aGF0IHdhcyBzcGxpdCBpbnRvIHR3byBub2RlcyBiZWNhdXNlIHRoZXkncmUgZmFp cmx5Cj4gc2ltaWxhciBoYXJkd2FyZSBibG9ja3MsIGFuZCBvbmUgb3IgdGhlIG90aGVyIG1heSBu b3QgYmUgdXNlZCBvbiB0aGUKPiBib2FyZCBzbyB3ZSB3YW50IHRvIHVzZSBzdGF0dXMgPSAiZGlz YWJsZWQiIHRvIGluZGljYXRlIHRoYXQuIFNhZGx5IHRoZQo+IGhhcmR3YXJlIHRlYW0gaGFzIGRl bGl2ZXJlZCB0aGVtIGFzIGEgc2luZ2xlIHBhY2thZ2UgaW50byB0aGUgU29DIGF0Cj4gYWRkcmVz cyAweDEyMDAwIGFuZCB0aGVuIHN0dWNrIGEgY29tbW9uIGNsayBmb3IgYm90aCB1YXJ0cyBpbnRv IHRoZSBzYW1lCj4gdWFydCB3cmFwcGVyLiBIZXJlJ3MgYSBjbGssIGpvYiBkb25lIQo+IAo+IElz IGl0IGEgcHJvYmxlbSB0byBtYXAgVUFSVDEgYWRkcmVzcyBzcGFjZSB3aGVuIGl0IGlzbid0IHVz ZWQgb24gdGhlCj4gYm9hcmQ/IEknbSB0cnlpbmcgdG8gdW5kZXJzdGFuZCB3aHkgaXQgY2FuJ3Qg d29yayB0byByZWdpc3RlciB0d28gdWFydAo+IHBvcnRzIGZyb20gb25lIGRldmljZSBub2RlIGFu ZCBkcml2ZXIuCgpTZXBhcmF0ZSBub2RlcyBhcmUgbmVlZGVkIGJlY2F1c2Ugc3RkaW4tcGF0aCBh bmQgc3Rkb3V0LXBhdGNoIG5lZWQgdG8KYmUgYWJsZSB0byBwb2ludCBhdCBhIHNwZWNpZmljIGRl dmljZSBub2RlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=