From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65BE6C433EF for ; Sat, 20 Nov 2021 15:21:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6E80A82FC2; Sat, 20 Nov 2021 16:21:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 8F6F382FE0; Sat, 20 Nov 2021 16:21:22 +0100 (CET) Received: from sibelius.xs4all.nl (sibelius.xs4all.nl [83.163.83.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5DF2482F5A for ; Sat, 20 Nov 2021 16:21:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=mark.kettenis@xs4all.nl Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 1c2766a4; Sat, 20 Nov 2021 16:21:12 +0100 (CET) Date: Sat, 20 Nov 2021 16:21:12 +0100 (CET) From: Mark Kettenis To: Sean Anderson Cc: trini@konsulko.com, peng.fan@oss.nxp.com, peng.fan@nxp.com, lukma@denx.de, sjg@chromium.org, u-boot@lists.denx.de In-Reply-To: <3d3603ac-d949-ab9b-3045-6f8a6aa25127@gmail.com> (message from Sean Anderson on Sat, 20 Nov 2021 10:06:55 -0500) Subject: Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults References: <20211029012801.15193-1-peng.fan@oss.nxp.com> <20211120125711.GO24579@bill-the-cat> <3d3603ac-d949-ab9b-3045-6f8a6aa25127@gmail.com> Message-ID: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > From: Sean Anderson > Date: Sat, 20 Nov 2021 10:06:55 -0500 > > On 11/20/21 7:57 AM, Tom Rini wrote: > > On Sat, Nov 20, 2021 at 12:10:54PM +0000, Peng Fan (OSS) wrote: > >>> Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > >>> > >>> From: Peng Fan > >>> > >>> Current code has a force clk_set_defaults in multiple stages, U-Boot reuse the > >>> same device tree and Linux Kernel device tree, but we not register all the clks > >>> as Linux Kernel, so clk_set_defaults will fail and cause the clk provider > >>> registeration fail. > >>> > >>> So introduce a new property to ignore the default settings which could be > >>> used by any node that wanna ignore default settings. > >>> > >>> Reviewed-by: Simon Glass > >>> Signed-off-by: Peng Fan > >>> --- > >>> > >>> V2: > >>> Add R-b tag > >>> Tom, Simon > >>> After a thought, I think still put it as a u-boot thing. assigned-clock-x is > >>> actually Linux specific, however I could not add the new property to Linux, > >>> because we are supporting SystemReady-IR, we need the > >>> assigned-clock-x property > >>> in linux working and ignore it in U-Boot. > >> > >> Any more thoughts? > > > > Just my continued request that you treat this as generic and submit the > > binding upstream so it can be in the device tree for the platform. > > > > Hmm. > > Could we just do > > /delete-property/ assigned-clocks; > > in our u-boot dtsi? No! Those properties are needed by the OS loaded by U-Boot. The right answer is probably that U-Boot should use these properties to set up the clocks correctly. Paradoxically that means the OS would no longer have to worry about them and the properties could be deleted ;).