From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95137C433EF for ; Tue, 23 Nov 2021 18:16:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239781AbhKWST4 (ORCPT ); Tue, 23 Nov 2021 13:19:56 -0500 Received: from sibelius.xs4all.nl ([83.163.83.176]:65042 "EHLO sibelius.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234712AbhKWSTz (ORCPT ); Tue, 23 Nov 2021 13:19:55 -0500 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 97695463; Tue, 23 Nov 2021 19:16:45 +0100 (CET) Date: Tue, 23 Nov 2021 19:16:45 +0100 (CET) From: Mark Kettenis To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, pali@kernel.org, alyssa@rosenzweig.io, lorenzo.pieralisi@arm.com, bhelgaas@google.com, luca@lucaceresoli.net, kernel-team@android.com In-Reply-To: <20211123180636.80558-3-maz@kernel.org> (message from Marc Zyngier on Tue, 23 Nov 2021 18:06:35 +0000) Subject: Re: [PATCH v3 2/3] arm64: dts: apple: t8103: Fix PCIe #PERST polarity References: <20211123180636.80558-1-maz@kernel.org> <20211123180636.80558-3-maz@kernel.org> Message-ID: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Marc Zyngier > Date: Tue, 23 Nov 2021 18:06:35 +0000 > > As the name indicates, #PERST is active low. So fix the DT description > to match the HW behaviour. > > Fixes: ff2a8d91d80c ("arm64: apple: Add PCIe node") > Signed-off-by: Marc Zyngier Reviewed-by: Mark Kettenis > --- > arch/arm64/boot/dts/apple/t8103.dtsi | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi > index fc8b2bb06ffe..e22c9433d5e0 100644 > --- a/arch/arm64/boot/dts/apple/t8103.dtsi > +++ b/arch/arm64/boot/dts/apple/t8103.dtsi > @@ -7,6 +7,7 @@ > * Copyright The Asahi Linux Contributors > */ > > +#include > #include > #include > #include > @@ -281,7 +282,7 @@ pcie0: pcie@690000000 { > port00: pci@0,0 { > device_type = "pci"; > reg = <0x0 0x0 0x0 0x0 0x0>; > - reset-gpios = <&pinctrl_ap 152 0>; > + reset-gpios = <&pinctrl_ap 152 GPIO_ACTIVE_LOW>; > max-link-speed = <2>; > > #address-cells = <3>; > @@ -301,7 +302,7 @@ port00: pci@0,0 { > port01: pci@1,0 { > device_type = "pci"; > reg = <0x800 0x0 0x0 0x0 0x0>; > - reset-gpios = <&pinctrl_ap 153 0>; > + reset-gpios = <&pinctrl_ap 153 GPIO_ACTIVE_LOW>; > max-link-speed = <2>; > > #address-cells = <3>; > @@ -321,7 +322,7 @@ port01: pci@1,0 { > port02: pci@2,0 { > device_type = "pci"; > reg = <0x1000 0x0 0x0 0x0 0x0>; > - reset-gpios = <&pinctrl_ap 33 0>; > + reset-gpios = <&pinctrl_ap 33 GPIO_ACTIVE_LOW>; > max-link-speed = <1>; > > #address-cells = <3>; > -- > 2.30.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67934C433EF for ; Tue, 23 Nov 2021 18:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-ID:References:Subject :In-Reply-To:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FYpR7+d8nAsdKSK9mLAg/odJIwsfKDk6iDCD8nIAYpA=; b=XV6zL8wBgwTd1X e4+i0rnQXLbSBjlTvHq0DeW8PavMvlPpMNnTsG0vnR/7Uztc2ZUE5aLJSls7cyZtuROeUsDLIkhiN Chx16O4Q2BIpDUrgK5/pl7WjNsjBlj0OaAYhR2s0Cljh8F3BbWe3+Rf9mcFniAymf+nN58VVRUG2c jQqqJEGOVj1SLWXYYt8Hz7uvXUhKmQX2DH0qHAOSLj6wUhy/clnT2ehA7Cg+ovbX6+3zJGHmE6ps7 2C+7uo4CMbq03762zxY+N5wQpcZnYUrNxC3fj7gQRDEMs4wKldqgbacs0u4NqWtQHT0G8VAQ8J/oI k7BkYQUkYoUbqKzaqBfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpaLd-003B3b-NA; Tue, 23 Nov 2021 18:16:53 +0000 Received: from sibelius.xs4all.nl ([83.163.83.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpaLZ-003B1Z-6z for linux-arm-kernel@lists.infradead.org; Tue, 23 Nov 2021 18:16:51 +0000 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 97695463; Tue, 23 Nov 2021 19:16:45 +0100 (CET) Date: Tue, 23 Nov 2021 19:16:45 +0100 (CET) From: Mark Kettenis To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, pali@kernel.org, alyssa@rosenzweig.io, lorenzo.pieralisi@arm.com, bhelgaas@google.com, luca@lucaceresoli.net, kernel-team@android.com In-Reply-To: <20211123180636.80558-3-maz@kernel.org> (message from Marc Zyngier on Tue, 23 Nov 2021 18:06:35 +0000) Subject: Re: [PATCH v3 2/3] arm64: dts: apple: t8103: Fix PCIe #PERST polarity References: <20211123180636.80558-1-maz@kernel.org> <20211123180636.80558-3-maz@kernel.org> Message-ID: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211123_101649_588439_1CBBF0CE X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Marc Zyngier > Date: Tue, 23 Nov 2021 18:06:35 +0000 > > As the name indicates, #PERST is active low. So fix the DT description > to match the HW behaviour. > > Fixes: ff2a8d91d80c ("arm64: apple: Add PCIe node") > Signed-off-by: Marc Zyngier Reviewed-by: Mark Kettenis > --- > arch/arm64/boot/dts/apple/t8103.dtsi | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi > index fc8b2bb06ffe..e22c9433d5e0 100644 > --- a/arch/arm64/boot/dts/apple/t8103.dtsi > +++ b/arch/arm64/boot/dts/apple/t8103.dtsi > @@ -7,6 +7,7 @@ > * Copyright The Asahi Linux Contributors > */ > > +#include > #include > #include > #include > @@ -281,7 +282,7 @@ pcie0: pcie@690000000 { > port00: pci@0,0 { > device_type = "pci"; > reg = <0x0 0x0 0x0 0x0 0x0>; > - reset-gpios = <&pinctrl_ap 152 0>; > + reset-gpios = <&pinctrl_ap 152 GPIO_ACTIVE_LOW>; > max-link-speed = <2>; > > #address-cells = <3>; > @@ -301,7 +302,7 @@ port00: pci@0,0 { > port01: pci@1,0 { > device_type = "pci"; > reg = <0x800 0x0 0x0 0x0 0x0>; > - reset-gpios = <&pinctrl_ap 153 0>; > + reset-gpios = <&pinctrl_ap 153 GPIO_ACTIVE_LOW>; > max-link-speed = <2>; > > #address-cells = <3>; > @@ -321,7 +322,7 @@ port01: pci@1,0 { > port02: pci@2,0 { > device_type = "pci"; > reg = <0x1000 0x0 0x0 0x0 0x0>; > - reset-gpios = <&pinctrl_ap 33 0>; > + reset-gpios = <&pinctrl_ap 33 GPIO_ACTIVE_LOW>; > max-link-speed = <1>; > > #address-cells = <3>; > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel