From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 741A6C433F5 for ; Fri, 11 Feb 2022 20:50:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3315383BAA; Fri, 11 Feb 2022 21:50:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2300683BB3; Fri, 11 Feb 2022 21:50:37 +0100 (CET) Received: from sibelius.xs4all.nl (sibelius.xs4all.nl [83.163.83.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4E78283839 for ; Fri, 11 Feb 2022 21:50:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=mark.kettenis@xs4all.nl Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id bd176a9c; Fri, 11 Feb 2022 21:50:33 +0100 (CET) Date: Fri, 11 Feb 2022 21:50:33 +0100 (CET) From: Mark Kettenis To: Simon Glass Cc: kettenis@openbsd.org, u-boot@lists.denx.de, trini@konsulko.com In-Reply-To: (message from Simon Glass on Fri, 11 Feb 2022 13:29:15 -0700) Subject: Re: [PATCH] arm: apple: Disable debug UART References: <20220211200013.18947-1-kettenis@openbsd.org> Message-ID: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean > From: Simon Glass > Date: Fri, 11 Feb 2022 13:29:15 -0700 > > Hi Mark, > > On Fri, 11 Feb 2022 at 13:00, Mark Kettenis wrote: > > > > The address of the debug UART varies differs between the M1 and > > the M1 Pro/Max SoCs. So we have to disable it to make a single > > U-Boot binary that works on all SoC generations. Leave the > > settings for the base address and clock rate of the M1 in place > > to make it easier to re-enable the debug UART when needed. > > How about adding some docs about how to, and what the addresses are? Yes I can do that. A section at the end of doc/board/apple/m1.rst? Is it ok if I provide a single update to that file for the M1 Pro/Max support? > > Signed-off-by: Mark Kettenis > > --- > > configs/apple_m1_defconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig > > index ef5b7ffd1a..396fe63114 100644 > > --- a/configs/apple_m1_defconfig > > +++ b/configs/apple_m1_defconfig > > @@ -3,7 +3,6 @@ CONFIG_ARCH_APPLE=y > > CONFIG_DEFAULT_DEVICE_TREE="t8103-j274" > > CONFIG_DEBUG_UART_BASE=0x235200000 > > CONFIG_DEBUG_UART_CLOCK=24000000 > > -CONFIG_DEBUG_UART=y > > CONFIG_SYS_LOAD_ADDR=0x0 > > CONFIG_USE_PREBOOT=y > > # CONFIG_DISPLAY_CPUINFO is not set > > -- > > 2.35.1 > > > > Regards, > SImon >