From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753465AbdLHKea (ORCPT ); Fri, 8 Dec 2017 05:34:30 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:44756 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753450AbdLHKeT (ORCPT ); Fri, 8 Dec 2017 05:34:19 -0500 X-Google-Smtp-Source: AGs4zMYkYE6EEAtk3IJSRoeYTuPPTiqCM7MS4slZEJc08KEiHCuUlrgmMsfCFj9hlji/PybZ+JLKfw== Subject: Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations To: Roman Gushchin , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, ast@kernel.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, kafai@fb.com, David Ahern References: <20171207183909.16240-1-guro@fb.com> <20171207183909.16240-5-guro@fb.com> From: Quentin Monnet Message-ID: Date: Fri, 8 Dec 2017 10:34:16 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171207183909.16240-5-guro@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-12-07 18:39 UTC+0000 ~ Roman Gushchin > This patch adds basic cgroup bpf operations to bpftool: > cgroup list, attach and detach commands. > > Usage is described in the corresponding man pages, > and examples are provided. > > Syntax: > $ bpftool cgroup list CGROUP > $ bpftool cgroup attach CGROUP ATTACH_TYPE PROG [ATTACH_FLAGS] > $ bpftool cgroup detach CGROUP ATTACH_TYPE PROG > > Signed-off-by: Roman Gushchin > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: Jakub Kicinski > Cc: Martin KaFai Lau > Cc: Quentin Monnet > Cc: David Ahern > --- > tools/bpf/bpftool/Documentation/bpftool-cgroup.rst | 92 +++++++ > tools/bpf/bpftool/Documentation/bpftool-map.rst | 2 +- > tools/bpf/bpftool/Documentation/bpftool-prog.rst | 2 +- > tools/bpf/bpftool/Documentation/bpftool.rst | 6 +- > tools/bpf/bpftool/cgroup.c | 305 +++++++++++++++++++++ > tools/bpf/bpftool/main.c | 3 +- > tools/bpf/bpftool/main.h | 1 + > 7 files changed, 406 insertions(+), 5 deletions(-) > create mode 100644 tools/bpf/bpftool/Documentation/bpftool-cgroup.rst > create mode 100644 tools/bpf/bpftool/cgroup.c > > diff --git a/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst b/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst > new file mode 100644 > index 000000000000..61ded613aee1 > --- /dev/null > +++ b/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst > @@ -0,0 +1,92 @@ > +================ > +bpftool-cgroup > +================ > +------------------------------------------------------------------------------- > +tool for inspection and simple manipulation of eBPF progs > +------------------------------------------------------------------------------- > + > +:Manual section: 8 > + > +SYNOPSIS > +======== > + > + **bpftool** [*OPTIONS*] **cgroup** *COMMAND* > + > + *OPTIONS* := { { **-j** | **--json** } [{ **-p** | **--pretty** }] | { **-f** | **--bpffs** } } > + > + *COMMANDS* := > + { **list** | **attach** | **detach** | **help** } > + > +MAP COMMANDS > +============= > + > +| **bpftool** **cgroup list** *CGROUP* > +| **bpftool** **cgroup attach** *CGROUP* *ATTACH_TYPE* *PROG* [*ATTACH_FLAGS*] > +| **bpftool** **cgroup detach** *CGROUP* *ATTACH_TYPE* *PROG* > +| **bpftool** **cgroup help** > +| > +| *PROG* := { **id** *PROG_ID* | **pinned** *FILE* | **tag** *PROG_TAG* } Could you please give the different possible values for ATTACH_TYPE and ATTACH_FLAGS, and provide some documentation for the flags? > + > +DESCRIPTION > +=========== > + **bpftool cgroup list** *CGROUP* > + List all programs attached to the cgroup *CGROUP*. > + > + Output will start with program ID followed by attach type, > + attach flags and program name. > + > + **bpftool cgroup attach** *CGROUP* *ATTACH_TYPE* *PROG* [*ATTACH_FLAGS*] > + Attach program *PROG* to the cgroup *CGROUP* with attach type > + *ATTACH_TYPE* and optional *ATTACH_FLAGS*. > + > + **bpftool cgroup detach** *CGROUP* *ATTACH_TYPE* *PROG* > + Detach *PROG* from the cgroup *CGROUP* and attach type > + *ATTACH_TYPE*. > + > + **bpftool prog help** > + Print short help message. […] > diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c > new file mode 100644 > index 000000000000..88d67f74313f > --- /dev/null > +++ b/tools/bpf/bpftool/cgroup.c > @@ -0,0 +1,305 @@ > +/* > + * Copyright (C) 2017 Facebook > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version > + * 2 of the License, or (at your option) any later version. > + * > + * Author: Roman Gushchin > + */ > + […] > +static int do_detach(int argc, char **argv) > +{ > + int prog_fd, cgroup_fd; > + enum bpf_attach_type attach_type; > + int ret = -1; > + > + if (argc < 4) { > + p_err("too few parameters for cgroup detach\n"); > + goto exit; > + } > + > + cgroup_fd = open(argv[0], O_RDONLY); > + if (cgroup_fd < 0) { > + p_err("can't open cgroup %s\n", argv[1]); > + goto exit; > + } > + > + attach_type = parse_attach_type(argv[1]); > + if (attach_type == __MAX_BPF_ATTACH_TYPE) { > + p_err("invalid attach type"); > + goto exit_cgroup; > + } > + > + argc -= 2; > + argv = &argv[2]; > + prog_fd = prog_parse_fd(&argc, &argv); > + if (prog_fd < 0) > + goto exit_cgroup; > + > + if (bpf_prog_detach2(prog_fd, cgroup_fd, attach_type)) { > + p_err("failed to attach program"); Failed to *detach* instead of “attach”. > + goto exit_prog; > + } > + > + if (json_output) > + jsonw_null(json_wtr); > + > + ret = 0; > + > +exit_prog: > + close(prog_fd); > +exit_cgroup: > + close(cgroup_fd); > +exit: > + return ret; > +} […] Very nice work on this v2, thanks a lot! Quentin