From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14B7EC433EF for ; Wed, 20 Apr 2022 21:51:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 85E9B83E80; Wed, 20 Apr 2022 23:51:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 9A5C883EB1; Wed, 20 Apr 2022 23:51:48 +0200 (CEST) Received: from sibelius.xs4all.nl (80-61-163-207.fixed.kpn.net [80.61.163.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 64FAF83EBB for ; Wed, 20 Apr 2022 23:51:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=mark.kettenis@xs4all.nl Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id d7c81c86; Wed, 20 Apr 2022 23:51:44 +0200 (CEST) Date: Wed, 20 Apr 2022 23:51:44 +0200 (CEST) From: Mark Kettenis To: Francesco Dolcini Cc: trini@konsulko.com, u-boot@lists.denx.de, sjg@chromium.org, robh@kernel.org In-Reply-To: <20220420170143.GA208136@francesco-nb.int.toradex.com> (message from Francesco Dolcini on Wed, 20 Apr 2022 19:01:43 +0200) Subject: Re: RFC: Adding U-Boot version in FDT chosen node References: <20220411181755.GB20890@francesco-nb.int.toradex.com> <20220420170143.GA208136@francesco-nb.int.toradex.com> Message-ID: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean > Date: Wed, 20 Apr 2022 19:01:43 +0200 > From: Francesco Dolcini > > +Tom > > On Mon, Apr 11, 2022 at 08:17:55PM +0200, Francesco Dolcini wrote: > > Hello all, > > I have a need to pass the u-boot version string to the operating > > system and I'm thinking at adding `u-boot,version` property storing > > `version_string` in it in the FDT `chosen` node. > > > > Is this something that would be generally useful? Would be a patch like > > that acceptable in upstream u-boot? Is there any other obvious way to > > achieve something like that already implemented (using the cmdline would > > work without any code change, but probably not the nicest solution). > > Any concern on this Tom? I'm asking you directly since you recently > acknowledged another change [0] related to the chosen node. > > [0] https://lore.kernel.org/all/20220412201444.GN14282@bill-the-cat/ To be honest, putting this in the "chosen" node feels odd. Traditionally device trees have a node dedicated to the firmware. For example Sun OpenFirmware systems had a "openprom" node with a "version" property. And OpenPOWER systems have an "ibm,firmware-versions" node.