From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <u-boot-bounces@lists.denx.de>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from phobos.denx.de (phobos.denx.de [85.214.62.61])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id 99E7BC433EF
	for <u-boot@archiver.kernel.org>; Tue, 26 Apr 2022 18:22:06 +0000 (UTC)
Received: from h2850616.stratoserver.net (localhost [IPv6:::1])
	by phobos.denx.de (Postfix) with ESMTP id 2A05783C96;
	Tue, 26 Apr 2022 20:22:04 +0200 (CEST)
Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl
Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de
Received: by phobos.denx.de (Postfix, from userid 109)
 id 9E2A683DBA; Tue, 26 Apr 2022 20:22:02 +0200 (CEST)
Received: from sibelius.xs4all.nl (80-61-163-207.fixed.kpn.net [80.61.163.207])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (No client certificate requested)
 by phobos.denx.de (Postfix) with ESMTPS id C4F5F83B74
 for <u-boot@lists.denx.de>; Tue, 26 Apr 2022 20:21:59 +0200 (CEST)
Authentication-Results: phobos.denx.de;
 dmarc=fail (p=none dis=none) header.from=xs4all.nl
Authentication-Results: phobos.denx.de;
 spf=fail smtp.mailfrom=mark.kettenis@xs4all.nl
Received: from localhost (bloch.sibelius.xs4all.nl [local])
 by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 4d47e1f7;
 Tue, 26 Apr 2022 20:21:58 +0200 (CEST)
Date: Tue, 26 Apr 2022 20:21:58 +0200 (CEST)
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Marek Vasut <marex@denx.de>
Cc: kettenis@openbsd.org, u-boot@lists.denx.de,
 patrick.delaunay@foss.st.com, sjg@chromium.org
In-Reply-To: <6cd5d5c8-a61e-a5e3-b9e1-85213333466e@denx.de> (message from
 Marek Vasut on Tue, 26 Apr 2022 20:04:19 +0200)
Subject: Re: [PATCH] power: domain: apple: Restore reset ops that return 0
References: <20220426171409.58716-1-kettenis@openbsd.org>
 <6cd5d5c8-a61e-a5e3-b9e1-85213333466e@denx.de>
Message-ID: <d3cd24bf517d9d6e@bloch.sibelius.xs4all.nl>
X-BeenThere: u-boot@lists.denx.de
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: U-Boot discussion <u-boot.lists.denx.de>
List-Unsubscribe: <https://lists.denx.de/options/u-boot>,
 <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>
List-Archive: <https://lists.denx.de/pipermail/u-boot/>
List-Post: <mailto:u-boot@lists.denx.de>
List-Help: <mailto:u-boot-request@lists.denx.de?subject=help>
List-Subscribe: <https://lists.denx.de/listinfo/u-boot>,
 <mailto:u-boot-request@lists.denx.de?subject=subscribe>
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de
X-Virus-Status: Clean

> Date: Tue, 26 Apr 2022 20:04:19 +0200
> From: Marek Vasut <marex@denx.de>
> 
> On 4/26/22 19:14, Mark Kettenis wrote:
> > These were removed inadvertently in commit 20874a60722b.
> > Fixes a crash on Apple M1 systems.
> 
> The drivers/power/domain/power-domain-uclass.c should handle empty 
> implementation of request/rfree callback in exactly the commit you 
> reference above.

Yes, but drivers/reset/reset-uclass.c doesn't and you also removed the
request/rfree callbacks for that part of the apple_pmgr driver.