From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9472FC3F68F for ; Wed, 15 Jan 2020 16:44:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B0322081E for ; Wed, 15 Jan 2020 16:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729016AbgAOQob (ORCPT ); Wed, 15 Jan 2020 11:44:31 -0500 Received: from foss.arm.com ([217.140.110.172]:39868 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728896AbgAOQob (ORCPT ); Wed, 15 Jan 2020 11:44:31 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E9EB6328; Wed, 15 Jan 2020 08:44:30 -0800 (PST) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B5AC3F718; Wed, 15 Jan 2020 08:44:30 -0800 (PST) Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible To: Greg KH Cc: Sasha Levin , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org References: <20200108110541.318672-1-suzuki.poulose@arm.com> <20200109143537.GE1706@sasha-vm> <20200115151118.GC3740793@kroah.com> From: Suzuki Kuruppassery Poulose Message-ID: Date: Wed, 15 Jan 2020 16:44:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200115151118.GC3740793@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On 15/01/2020 15:11, Greg KH wrote: > On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote: >> On 09/01/2020 14:35, Sasha Levin wrote: >>> On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: >>>> [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] >>>> >>>> During a perf session we try to allocate buffers on the "node" associated >>>> with the CPU the event is bound to. If it is not bound to a CPU, we >>>> use the current CPU node, using smp_processor_id(). However this is >>>> unsafe >>>> in a pre-emptible context and could generate the splats as below : >>>> >>>> BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 >>>> >>>> Use NUMA_NO_NODE hint instead of using the current node for events >>>> not bound to CPUs. >>>> >>>> Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") >>>> Cc: Mathieu Poirier >>>> Signed-off-by: Suzuki K Poulose >>>> Cc: stable # v4.9 to v4.19 >>>> Signed-off-by: Mathieu Poirier >>>> Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org >>>> >>> >>> I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which >>> also had to be resolved. >>> >> >> >> Thanks Sasha ! > > Note, these had to all be dropped as they broke the build :( > > So can you please send us patches that at least build? :) > Do you have a build failure log ? I did build test it before sending it over. I tried it again on 4.9, 4.14 and 4.19. I don't hit any build failures here. Please could you share the log if you have it handy ? Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D705C32771 for ; Wed, 15 Jan 2020 16:44:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11A8F2081E for ; Wed, 15 Jan 2020 16:44:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bzU8pSQO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11A8F2081E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0dkDUjh1ZisYYdRDcV6D3ZUs9gFILOXvSo+3mPJIQ8c=; b=bzU8pSQOAYxo/DtQtUV4npFxn wEtFKs/z0hLCCA5SyvwlpyuO4EF01phGqHqH0t9m801mcatAE9f5AeRNF0zE0zJ+o27zdvkswQ1al z0EoV078Q9zUZtjcZrjv0glkPasmKfU69mHMj4eXFxg9fApSRbuGccrOshjwj7OglOEoB4FQl+h5g yn5+ldSmlObTyGB2QUtR8kTSdLkSbXHjz7qBf9cP37vg1+rx/qfyTHfK1do5Ubp7NbKrPJ9So/P1u kj0wuBiGMUPDHZRRLc+ieOBXnOmDAZgS9uqcYhoiWQ1dI3z1UjDndA+kGWxET/5qtJtPKFFtdVdNv OpLfBcIgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irlmU-0003f6-Bs; Wed, 15 Jan 2020 16:44:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irlmR-0003eX-KI for linux-arm-kernel@lists.infradead.org; Wed, 15 Jan 2020 16:44:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E9EB6328; Wed, 15 Jan 2020 08:44:30 -0800 (PST) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B5AC3F718; Wed, 15 Jan 2020 08:44:30 -0800 (PST) Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible To: Greg KH References: <20200108110541.318672-1-suzuki.poulose@arm.com> <20200109143537.GE1706@sasha-vm> <20200115151118.GC3740793@kroah.com> From: Suzuki Kuruppassery Poulose Message-ID: Date: Wed, 15 Jan 2020 16:44:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200115151118.GC3740793@kroah.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200115_084431_705474_A7BDF4AA X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Greg, On 15/01/2020 15:11, Greg KH wrote: > On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote: >> On 09/01/2020 14:35, Sasha Levin wrote: >>> On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: >>>> [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] >>>> >>>> During a perf session we try to allocate buffers on the "node" associated >>>> with the CPU the event is bound to. If it is not bound to a CPU, we >>>> use the current CPU node, using smp_processor_id(). However this is >>>> unsafe >>>> in a pre-emptible context and could generate the splats as below : >>>> >>>> BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 >>>> >>>> Use NUMA_NO_NODE hint instead of using the current node for events >>>> not bound to CPUs. >>>> >>>> Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") >>>> Cc: Mathieu Poirier >>>> Signed-off-by: Suzuki K Poulose >>>> Cc: stable # v4.9 to v4.19 >>>> Signed-off-by: Mathieu Poirier >>>> Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org >>>> >>> >>> I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which >>> also had to be resolved. >>> >> >> >> Thanks Sasha ! > > Note, these had to all be dropped as they broke the build :( > > So can you please send us patches that at least build? :) > Do you have a build failure log ? I did build test it before sending it over. I tried it again on 4.9, 4.14 and 4.19. I don't hit any build failures here. Please could you share the log if you have it handy ? Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel