From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A68A1C432BE for ; Fri, 20 Aug 2021 13:53:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79218610CC for ; Fri, 20 Aug 2021 13:53:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240777AbhHTNyV (ORCPT ); Fri, 20 Aug 2021 09:54:21 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:57536 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231854AbhHTNyT (ORCPT ); Fri, 20 Aug 2021 09:54:19 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1A9773F31C for ; Fri, 20 Aug 2021 13:53:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629467621; bh=L6n8EwvoF0TqxFnTQHNETcblmy409V9jfAs/6ldvq4k=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=FeilRYNz1W5Jqhafz4g+znI3Wce/mZtgWiB5qSiU1qXQjTAPqV/4iZAC+NkC34/Cs s6HCXvkhXMj1qUQi4FWYqCCU+puaYyVjbAO6323gUIjDPodAX7Zt/e6d7Rgs1hjT+y hz/e6bh9m6xsVKrLGhh2secEtD8qZqJ3MsFBuG+/611tYI84PqxC9nwqNas7o+INF1 VYdOVgT4VntJN1uYfWiQZBRG07uCo0frxtg7pDh5Xc1WxAUcRBPdxvJmKbOj+ZpAF7 njLMHRvQRk0G1Tw/MB2iNi9pmxvCiWzjyi530b6+TmL5Tewc6/bVlPF6pgp9+AJ82P hQL1KCArKSDYg== Received: by mail-ed1-f70.google.com with SMTP id b25-20020a05640202d9b02903be7281a80cso4587316edx.3 for ; Fri, 20 Aug 2021 06:53:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L6n8EwvoF0TqxFnTQHNETcblmy409V9jfAs/6ldvq4k=; b=YRQfZmYf/trpprpZWAl1rIPhjrJy3gnJKx0KkSTkmkdglvKcAsl7IzgOatZ26dOqtZ OZsX0jEuwwq4/8AV2Q4HUBXrwfOzavagBofLG+eg5HjUEIf7iSAJOLOY220RdVFZatEd 1vT6FJj3eyLSOZ1Nv42/bEtKjlrsR9UGJadOvzGW2rSI6QohkN4tCfit58dHRh/MGWHR k1A+o53U5WjlrVQ0cpyYY3SCU4HX1xScaO5kQ6chfqQmB6qTm+a30KnCePxmkY29Ik8T MGqGsHnx/w7mDp+/14crq3jYZ/vjSRJJZ2k45lxmurPsIwlI4F47tEyRIzWAjwUjYVws K2Nw== X-Gm-Message-State: AOAM533uMu+mTGeNAK0O+BOtpk0vQOq8pUOOtNKmDzfRlAOjqGpsAuEt Ivem/2FdbmF6lwoiBU3AeNfO8FBEYkTqlA2CVVqbvxI498yum7E4nkYlPXmkExSApf4mGocgZna Ho4bihllFUIqq7xcflvt4C6Kd9ovjmcMqGbEe+S6PRw== X-Received: by 2002:a17:907:2168:: with SMTP id rl8mr1189846ejb.42.1629467620849; Fri, 20 Aug 2021 06:53:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRnazCb0WSvIZUIOXuiwlWppcOzwDCP8XkmoOFIi4wo1QoT4XNNQeCS37G86Ssi7hlQsUy1w== X-Received: by 2002:a17:907:2168:: with SMTP id rl8mr1189834ejb.42.1629467620713; Fri, 20 Aug 2021 06:53:40 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id bm26sm2914357ejb.16.2021.08.20.06.53.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 06:53:40 -0700 (PDT) Subject: Re: [PATCH] dt-bindings: memory: convert Samsung Exynos DMC to dtschema To: Rob Herring Cc: Lukasz Luba , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, linux-arm-kernel , linux-samsung-soc , "open list:THERMAL" References: <20210813125414.104467-1-krzysztof.kozlowski@canonical.com> <73eebe7b-46da-137b-1938-09a5b453320a@arm.com> <0ec05a0b-9499-3bf4-a231-ea53b1cf99ed@canonical.com> From: Krzysztof Kozlowski Message-ID: Date: Fri, 20 Aug 2021 15:53:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/08/2021 15:31, Rob Herring wrote: > On Wed, Aug 18, 2021 at 9:43 AM Krzysztof Kozlowski > wrote: >> >> On 18/08/2021 16:31, Rob Herring wrote: >>> On Mon, Aug 16, 2021 at 3:32 AM Krzysztof Kozlowski >>> wrote: >>>> >>>> On 16/08/2021 09:53, Lukasz Luba wrote: >>>>> Hi Krzysztof, >>>>> >>>>> On 8/13/21 1:54 PM, Krzysztof Kozlowski wrote: >>>>>> Convert Samsung Exynos5422 SoC frequency and voltage scaling for >>>>>> Dynamic Memory Controller to DT schema format using json-schema. >>>>>> >>>>>> Signed-off-by: Krzysztof Kozlowski >>>>>> --- >>>>>> .../memory-controllers/exynos5422-dmc.txt | 84 ----------- >>>>>> .../samsung,exynos5422-dmc.yaml | 137 ++++++++++++++++++ >>>>>> MAINTAINERS | 2 +- >>>>> >>>>> I'm not an expert in this DT scripts and why it complains. Maybe it >>>>> complains because the "samsung,exynos-ppmu" is defined in the .txt >>>>> file... (?) >>>>> Although, in general looks OK. >>>>> >>>>> Acked-by: Lukasz Luba >>>> >>>> I think the warning (triggered by DT_CHECKER_FLAGS=-m) can be ignored >>>> because it complains about compatible in example which is not present in >>>> the bindings. Usually it means someone wrote example not matching the >>>> bindings (e.g. a typo in compatible) but here it is on purpose. >>> >>> Ultimately, it will mean the binding is undocumented (or a typo). But >>> right now, it means the binding is undocumented with a schema. It's >>> off by default because there's still about 80 warnings. It's turned on >>> for the bot so we don't add more. So please don't ignore it. >>> >> >> By "Ignore" I meant here that it is a false positive, so it can be >> ignored. The warning is about compatible "samsung,exynos-ppmu" used in >> the example. However this exynos-ppmu is not part of this bindings and >> is documented elsewhere: >> Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt > > Yes, I understood all that. Let me be clear. I don't want examples > which don't have a schema. So drop the node or convert > exynos-ppmu.txt. > > First, when we do add a schema, then we likely have to go fix the > examples. It happens a lot and is not caught with folks using > DT_SCHEMA_FILES. Second, I don't like reporting errors that users > should have gotten by default. We can't turn this check on by default > until the 80 or so cases we already have in the binding examples are > fixed. Understood, I'll send both of these bindings. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C0DCC4338F for ; Fri, 20 Aug 2021 13:55:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17F3C604AC for ; Fri, 20 Aug 2021 13:55:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 17F3C604AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=c6BadgDQTDB1tGdKotK1TR7AKFKNK0JX9jAHkVyuJdk=; b=z0I2p/wbKXV3z3CgM73oEn8ay8 TNgd7jIOtUwJRHeC4EURG50KSJUw/QaqhGSioeUi1zowtPaTTk66aRoC/cM75nWRppQremCePSXbc 1RZNX6wyPlYEKlz2dYD7EkK0g+yHBNePlNbpfMTkVu1TsfR2ZgcMUGVIMwFUELcqXUsiat+/gyqfB 2q5RBN2NGQgzv2k50xt22s5h98lj+wUaoASr81L/T8r6RNN5KQYsdSQUc9yl84unbPa7QnSc1KPc2 1w1FXPf4EShTMkNmlXUzFxV+2kd7HekRQXI+KDMrcNNm3jwuk+1i3X0MfJGm57Dv88p1Ow07H/hfd +oQlgWXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH4y4-00BKxx-Dq; Fri, 20 Aug 2021 13:53:56 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH4xx-00BKx4-Ud for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 13:53:53 +0000 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 1EF0240622 for ; Fri, 20 Aug 2021 13:53:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629467621; bh=L6n8EwvoF0TqxFnTQHNETcblmy409V9jfAs/6ldvq4k=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=FeilRYNz1W5Jqhafz4g+znI3Wce/mZtgWiB5qSiU1qXQjTAPqV/4iZAC+NkC34/Cs s6HCXvkhXMj1qUQi4FWYqCCU+puaYyVjbAO6323gUIjDPodAX7Zt/e6d7Rgs1hjT+y hz/e6bh9m6xsVKrLGhh2secEtD8qZqJ3MsFBuG+/611tYI84PqxC9nwqNas7o+INF1 VYdOVgT4VntJN1uYfWiQZBRG07uCo0frxtg7pDh5Xc1WxAUcRBPdxvJmKbOj+ZpAF7 njLMHRvQRk0G1Tw/MB2iNi9pmxvCiWzjyi530b6+TmL5Tewc6/bVlPF6pgp9+AJ82P hQL1KCArKSDYg== Received: by mail-ed1-f72.google.com with SMTP id k13-20020aa7c04d000000b003bf04c03fc4so4591118edo.22 for ; Fri, 20 Aug 2021 06:53:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L6n8EwvoF0TqxFnTQHNETcblmy409V9jfAs/6ldvq4k=; b=c1nnszzan55ivisJBMJzJQeDewJPt6RsKGEsnQ9mwfktlxDMPWfRs/vfInkvdorxrM efRA/lgzb3d7Or+booP+18u2YU92zEujntnxCIvgYB5obSRUITykO2zwd3rTeeGJQXKi H6LlYm3/7e1jbs7x4MNzFYJX8xG36LTtfzVTo8yz5OINIVi/BsY0DKOKkSquPErJn8X7 /q0cZSXpXoR0/HrtA041Tqg/V0yvHeGrZmhsQXXM1tDolsE+vt8vyCFbrhmNx2KOyXWf 6oxZt1I5rSFvp+HVr4CBNKTXwWh6yLnTbbbB0QTc/7IxQTV3qkaNrhcM/nInZ7WOlgEH 7yZA== X-Gm-Message-State: AOAM531yjxW6STvpR/7hI16EywvJWXZyp3SePqaNZtC88f7zaA1YIR1e zDqUNPKqt1iivsSfNtCID9xzxDwOPr4+wXfcBiat5iWBBG5sdcqSGN+HGT3vxg2gpuXN34PYJAz MiYJhqmjI/R1jTCExO9XvN7lxlLsXox4PzLu7gdI2lEOChGln8kbD X-Received: by 2002:a17:907:2168:: with SMTP id rl8mr1189844ejb.42.1629467620849; Fri, 20 Aug 2021 06:53:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRnazCb0WSvIZUIOXuiwlWppcOzwDCP8XkmoOFIi4wo1QoT4XNNQeCS37G86Ssi7hlQsUy1w== X-Received: by 2002:a17:907:2168:: with SMTP id rl8mr1189834ejb.42.1629467620713; Fri, 20 Aug 2021 06:53:40 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id bm26sm2914357ejb.16.2021.08.20.06.53.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 06:53:40 -0700 (PDT) Subject: Re: [PATCH] dt-bindings: memory: convert Samsung Exynos DMC to dtschema To: Rob Herring Cc: Lukasz Luba , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, linux-arm-kernel , linux-samsung-soc , "open list:THERMAL" References: <20210813125414.104467-1-krzysztof.kozlowski@canonical.com> <73eebe7b-46da-137b-1938-09a5b453320a@arm.com> <0ec05a0b-9499-3bf4-a231-ea53b1cf99ed@canonical.com> From: Krzysztof Kozlowski Message-ID: Date: Fri, 20 Aug 2021 15:53:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_065350_175436_89B6FF75 X-CRM114-Status: GOOD ( 25.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/08/2021 15:31, Rob Herring wrote: > On Wed, Aug 18, 2021 at 9:43 AM Krzysztof Kozlowski > wrote: >> >> On 18/08/2021 16:31, Rob Herring wrote: >>> On Mon, Aug 16, 2021 at 3:32 AM Krzysztof Kozlowski >>> wrote: >>>> >>>> On 16/08/2021 09:53, Lukasz Luba wrote: >>>>> Hi Krzysztof, >>>>> >>>>> On 8/13/21 1:54 PM, Krzysztof Kozlowski wrote: >>>>>> Convert Samsung Exynos5422 SoC frequency and voltage scaling for >>>>>> Dynamic Memory Controller to DT schema format using json-schema. >>>>>> >>>>>> Signed-off-by: Krzysztof Kozlowski >>>>>> --- >>>>>> .../memory-controllers/exynos5422-dmc.txt | 84 ----------- >>>>>> .../samsung,exynos5422-dmc.yaml | 137 ++++++++++++++++++ >>>>>> MAINTAINERS | 2 +- >>>>> >>>>> I'm not an expert in this DT scripts and why it complains. Maybe it >>>>> complains because the "samsung,exynos-ppmu" is defined in the .txt >>>>> file... (?) >>>>> Although, in general looks OK. >>>>> >>>>> Acked-by: Lukasz Luba >>>> >>>> I think the warning (triggered by DT_CHECKER_FLAGS=-m) can be ignored >>>> because it complains about compatible in example which is not present in >>>> the bindings. Usually it means someone wrote example not matching the >>>> bindings (e.g. a typo in compatible) but here it is on purpose. >>> >>> Ultimately, it will mean the binding is undocumented (or a typo). But >>> right now, it means the binding is undocumented with a schema. It's >>> off by default because there's still about 80 warnings. It's turned on >>> for the bot so we don't add more. So please don't ignore it. >>> >> >> By "Ignore" I meant here that it is a false positive, so it can be >> ignored. The warning is about compatible "samsung,exynos-ppmu" used in >> the example. However this exynos-ppmu is not part of this bindings and >> is documented elsewhere: >> Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt > > Yes, I understood all that. Let me be clear. I don't want examples > which don't have a schema. So drop the node or convert > exynos-ppmu.txt. > > First, when we do add a schema, then we likely have to go fix the > examples. It happens a lot and is not caught with folks using > DT_SCHEMA_FILES. Second, I don't like reporting errors that users > should have gotten by default. We can't turn this check on by default > until the 80 or so cases we already have in the binding examples are > fixed. Understood, I'll send both of these bindings. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel