From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431F9C54EB4 for ; Tue, 24 Jan 2023 10:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233689AbjAXKIM (ORCPT ); Tue, 24 Jan 2023 05:08:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233318AbjAXKIK (ORCPT ); Tue, 24 Jan 2023 05:08:10 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55CAE55AC for ; Tue, 24 Jan 2023 02:08:08 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id f25-20020a1c6a19000000b003da221fbf48so10514527wmc.1 for ; Tue, 24 Jan 2023 02:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=BFAsoCM7lTTy8pzMkhBP/3Y7R7BLbBDpiacpk1e+svk=; b=zbc1Kh29haSWpTL482axZTwaQ+BCuuBVWHm9Wm9CefPtdVb2/WcPKQtJBGwMv8h1Xa Uu3j/8TozWnXngaG9EMppKbhb+OEJAx2cDFrbg/7y9Apf3rS0ImEdwsm/sQ2qEPKbPY/ g5VdPz5btDNmrLcJsNN39oIPiUWQWPqMqR4HmfMtKZVrUEsJNAYyYB7VPDWlA4RZyGlj RSOf1frU64pubP9yex7qfz6s5oKkc9G36D/M/6370N4aSnqEDDbxsgwFeDlpXeMHcZ1t tMSzZcOvNm6JIKGPVWLu2QTY8+TQV51tFYQV2t4z7lyzacaDeZmajykwGoSJkI8DBgYD lRvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BFAsoCM7lTTy8pzMkhBP/3Y7R7BLbBDpiacpk1e+svk=; b=cQJ4x5AZpTo8ZY4t/WSDUqlCphnhs9fSD+6dambYcUiWhsE8f0XdKUwYrrevtP9ti1 HYnuGPfM2ieK1vACaKSY9QKkk0J65H21xOug8K4atjKcOyff4iEU+hWtpEi4TnSWggLu kQjtr8N544qwLrLSlugcjRLwrLaN9OQnZmxLb3V+XSyUKdy0OIKHpm1JM7gJZVqTqFJB rTDoFpFSfNiqfxn4hs+zjYIuIQFtVRwezZCM1w22O80uxzfrqiytZ1+pYG8vDkITIIEW HB6r3jsOMxCv78VPpVhMDnhH18aw5atZWWB0Oh4wOtRDlOslfX+3X6ouZQwZnCB1AOpP zbCg== X-Gm-Message-State: AFqh2kpmQpocf3Oeqq4euizuvNeEupSFS9x5cdR3yxzzYqZfqYVYV3y7 dKOIj9gk/poKWLngIqnCTAOe5w== X-Google-Smtp-Source: AMrXdXtnSVR3GOqGkK+I/1saZYRYhFvhUquzJUpk3lftfHhjGUEtOPza9mC7F8QU6s/MYeXc3UoNng== X-Received: by 2002:a05:600c:3556:b0:3db:331b:bd2d with SMTP id i22-20020a05600c355600b003db331bbd2dmr15705410wmq.18.1674554886768; Tue, 24 Jan 2023 02:08:06 -0800 (PST) Received: from [192.168.99.137] ([95.178.111.30]) by smtp.gmail.com with ESMTPSA id az41-20020a05600c602900b003dab77aa911sm13183099wmb.23.2023.01.24.02.08.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 02:08:06 -0800 (PST) Message-ID: Date: Tue, 24 Jan 2023 11:08:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v7 4/4] thermal: mediatek: add another get_temp ops for thermal sensors From: Amjad Ouled-Ameur To: Daniel Lezcano , "Rafael J. Wysocki" , Amit Kucheria , Rob Herring , Krzysztof Kozlowski , Zhang Rui Cc: AngeloGioacchino Del Regno , Fabien Parent , Matthias Brugger , Markus Schneider-Pargmann , linux-pm@vger.kernel.org, Rob Herring , Michael Kao , linux-kernel@vger.kernel.org, Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <20221018-up-i350-thermal-bringup-v7-0-ebf08ff2eddb@baylibre.com> <20221018-up-i350-thermal-bringup-v7-4-ebf08ff2eddb@baylibre.com> <4121bb6b-30db-7a23-f4c8-40afdda7a0b5@linaro.org> <0644aede-c281-3919-50e0-4466f6587d81@linaro.org> <187b0fe1-1f14-d8b8-c827-1e824da0b1d3@baylibre.com> Content-Language: en-US In-Reply-To: <187b0fe1-1f14-d8b8-c827-1e824da0b1d3@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On 1/19/23 18:03, Amjad Ouled-Ameur wrote: > Hi Daniel, > > On 12/29/22 16:49, Daniel Lezcano wrote: >> On 06/12/2022 10:18, Amjad Ouled-Ameur wrote: >>> Hi Daniel, >>> On Mon Dec 5, 2022 at 8:39 PM CET, Daniel Lezcano wrote: >>>> >>>> Hi Amjad, >>>> >>>> >>>> On 05/12/2022 11:41, Amjad Ouled-Ameur wrote: >>>> >>>> [ ... ] >>>> >>>>>>> @@ -1161,11 +1197,24 @@ static int mtk_thermal_probe(struct platform_device *pdev) >>>>>>>             platform_set_drvdata(pdev, mt); >>>>>>>     -    tzdev = devm_thermal_of_zone_register(&pdev->dev, 0, mt, >>>>>>> -                          &mtk_thermal_ops); >>>>>>> -    if (IS_ERR(tzdev)) { >>>>>>> -        ret = PTR_ERR(tzdev); >>>>>>> -        goto err_disable_clk_peri_therm; >>>>>>> +    for (i = 0; i < mt->conf->num_sensors + 1; i++) { >>>>>>> +        tz = devm_kmalloc(&pdev->dev, sizeof(*tz), GFP_KERNEL); >>>>>>> +        if (!tz) >>>>>>> +            return -ENOMEM; >>>>>>> + >>>>>>> +        tz->mt = mt; >>>>>>> +        tz->id = i; >>>>>>> + >>>>>>> +        tzdev = devm_thermal_of_zone_register(&pdev->dev, i, tz, (i == 0) ? >>>>>>> +                                 &mtk_thermal_ops : >>>>>>> + &mtk_thermal_sensor_ops); >>>>>> >>>>>> Here you use again the aggregation >>>>> I addressed this concern in V6, could you please take a look and let me >>>>> know what you think [0]. >>>>> >>>>> [0]: https://lore.kernel.org/all/5eb0cdc2-e9f9-dd42-bf80-b7dcd8bcc196@baylibre.com/ >>>> >>>> May I misunderstanding but AFAICS, this patch is setting the >>>> mtk_thermal_ops if the sensor id is zero. The get_temp is computing the >>>> max temperature in this ops which is what we don't want to do. >>> >>> Correct, but I think that is out of scope of this patchset, as the current >>> driver already uses mtk_thermal_ops for sensor 0. The focus of this patchset >>> is to add support for the other sensors. >>> >>> Besides, what do you suggest as a clean implementation if the current one >>> no longer meets thermal core requirements ? >> >> IIUC, there is a sensor per couple of cores. 1 x 2Bigs, 1 x 2Bigs, 1 x 4 Little, right ? > > MT8365 SoC has 4 x A53 CPUs. The SoC has 4 thermal zones per sensor. Thermal zone 0 corresponds > > to all 4 x A53 CPUs, the other thermal zones (1, 2 and 3) has nothing to do with CPUs. The cooling device type > > used for CPUs is passive. FYI, thermal zones 1, 2 and 3 are present in the SoC for debug-purpose only, they are not supposed > > to be used for production. > After reconsidering the fact that zones 1, 2 and 3 are only used for dev/debug, it might be best to avoid aggregation as you suggested, and keep only support for zone 0 in this driver. Thus I suggest I send a V8 where I keep only below fixes for this patch if that's okay with you: - Define "raw_to_mcelsius" function pointer for "struct thermal_bank_cfg". - Fix "mtk_thermal" variable in mtk_read_temp(). - Set "mt->raw_to_mcelsius" in probe(). For zones 1, 2 and 3 we can later add a different driver specific for dev/debug to probe them to avoid confusion. Regards, Amjad > > Regards, > > Amjad > >> >> If it is the case, then a thermal zone per sensor with the trip points and a cooling device for each of them. >> >> The two thermal zones for the big will share the same cooling device. The little thermal zone will have its own cooling device. >> >> If there is the GPU, then its own cooling device also with devfreq. >> >> >>>> Linaro.org │ Open source software for ARM SoCs >>>> >>>> Follow Linaro:  Facebook | >>>> Twitter | >>>> Blog >>> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE5D3C25B4E for ; Tue, 24 Jan 2023 10:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nkhixHCCHNagadkBe1pI83g7rIUBfqJ34+g4oB/qCvg=; b=G7zfgWFIXpPGZB z+7K+9Zo4njh/VViBu1DD0i1iGDJgdVukjqIB4kWczufm15/oIZNAwd6ygxMBel3m4ypbrYg6/A7Y JOQ/LZSR+J5cuC3e9pJY79KTMkltGvfKg+NKbrTe8k0h/naZDJZd0X99fLfo4vNLoMn21vhJIdkPS /hPGZfECXMftgtf6hyvkBDWXdjs9mUdUeWSgYz2zi2FJFmpnDVmxtRDewLZGSHRXsCPc68uqvlB9b igHxGnTdq5kovcK2ivzpny31u3370KrH/5rATCoBD9J/K4uwqW7x15tQthNB0XUNq0B4m3NsPREdO +H06miWANpbonxdr+YSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKGDu-0032OE-1k; Tue, 24 Jan 2023 10:08:14 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKGDp-0032MD-4L for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 10:08:11 +0000 Received: by mail-wm1-x331.google.com with SMTP id q10-20020a1cf30a000000b003db0edfdb74so631140wmq.1 for ; Tue, 24 Jan 2023 02:08:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=BFAsoCM7lTTy8pzMkhBP/3Y7R7BLbBDpiacpk1e+svk=; b=zbc1Kh29haSWpTL482axZTwaQ+BCuuBVWHm9Wm9CefPtdVb2/WcPKQtJBGwMv8h1Xa Uu3j/8TozWnXngaG9EMppKbhb+OEJAx2cDFrbg/7y9Apf3rS0ImEdwsm/sQ2qEPKbPY/ g5VdPz5btDNmrLcJsNN39oIPiUWQWPqMqR4HmfMtKZVrUEsJNAYyYB7VPDWlA4RZyGlj RSOf1frU64pubP9yex7qfz6s5oKkc9G36D/M/6370N4aSnqEDDbxsgwFeDlpXeMHcZ1t tMSzZcOvNm6JIKGPVWLu2QTY8+TQV51tFYQV2t4z7lyzacaDeZmajykwGoSJkI8DBgYD lRvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BFAsoCM7lTTy8pzMkhBP/3Y7R7BLbBDpiacpk1e+svk=; b=BVzNDuXaLoY4OOEWJOBwXpH8mi1T/mIyIpg8QukWUtmBC4M93nGZuaud2uNEZ+ycdv wsFuYI4hVjlGyhnXw4B0j7QCLk7gS1AOvJMYJhaTONikIga+0KtI6/17QAQMdpCzqg6P fbBlu+T9MXgMJysG9ZQQl8op3OviM6yBBcIKuZK+Ayu1u9c4jB3/uLc18lwK52x23oD0 MUzRxlM7lKwQQLeYK+5Ha6+a7h9U5yoKAsnICm+34ISfze/CpEckiL2bowxXrRB/CNCu bFVSNErUJdW9EacD2mZWcyr49H2cD2DEUrsrS7SpJOh4CqIHY4w811g504XKoGsEeFmA /RzQ== X-Gm-Message-State: AFqh2krmO834ZOe6TQWjUrKDIUYlYxtFVEjamNr2m+0XMIzMxRhZPFL9 +L1vWUNSJaTpM6OjAGwVg6aV0A== X-Google-Smtp-Source: AMrXdXtnSVR3GOqGkK+I/1saZYRYhFvhUquzJUpk3lftfHhjGUEtOPza9mC7F8QU6s/MYeXc3UoNng== X-Received: by 2002:a05:600c:3556:b0:3db:331b:bd2d with SMTP id i22-20020a05600c355600b003db331bbd2dmr15705410wmq.18.1674554886768; Tue, 24 Jan 2023 02:08:06 -0800 (PST) Received: from [192.168.99.137] ([95.178.111.30]) by smtp.gmail.com with ESMTPSA id az41-20020a05600c602900b003dab77aa911sm13183099wmb.23.2023.01.24.02.08.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 02:08:06 -0800 (PST) Message-ID: Date: Tue, 24 Jan 2023 11:08:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v7 4/4] thermal: mediatek: add another get_temp ops for thermal sensors From: Amjad Ouled-Ameur To: Daniel Lezcano , "Rafael J. Wysocki" , Amit Kucheria , Rob Herring , Krzysztof Kozlowski , Zhang Rui Cc: AngeloGioacchino Del Regno , Fabien Parent , Matthias Brugger , Markus Schneider-Pargmann , linux-pm@vger.kernel.org, Rob Herring , Michael Kao , linux-kernel@vger.kernel.org, Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <20221018-up-i350-thermal-bringup-v7-0-ebf08ff2eddb@baylibre.com> <20221018-up-i350-thermal-bringup-v7-4-ebf08ff2eddb@baylibre.com> <4121bb6b-30db-7a23-f4c8-40afdda7a0b5@linaro.org> <0644aede-c281-3919-50e0-4466f6587d81@linaro.org> <187b0fe1-1f14-d8b8-c827-1e824da0b1d3@baylibre.com> Content-Language: en-US In-Reply-To: <187b0fe1-1f14-d8b8-c827-1e824da0b1d3@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230124_020809_206298_36FADF56 X-CRM114-Status: GOOD ( 28.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsLAoKT24gMS8xOS8yMyAxODowMywgQW1qYWQgT3VsZWQtQW1ldXIgd3JvdGU6Cj4g SGkgRGFuaWVsLAo+Cj4gT24gMTIvMjkvMjIgMTY6NDksIERhbmllbCBMZXpjYW5vIHdyb3RlOgo+ PiBPbiAwNi8xMi8yMDIyIDEwOjE4LCBBbWphZCBPdWxlZC1BbWV1ciB3cm90ZToKPj4+IEhpIERh bmllbCwKPj4+IE9uIE1vbiBEZWMgNSwgMjAyMiBhdCA4OjM5IFBNIENFVCwgRGFuaWVsIExlemNh bm8gd3JvdGU6Cj4+Pj4KPj4+PiBIaSBBbWphZCwKPj4+Pgo+Pj4+Cj4+Pj4gT24gMDUvMTIvMjAy MiAxMTo0MSwgQW1qYWQgT3VsZWQtQW1ldXIgd3JvdGU6Cj4+Pj4KPj4+PiBbIC4uLiBdCj4+Pj4K Pj4+Pj4+PiBAQCAtMTE2MSwxMSArMTE5NywyNCBAQCBzdGF0aWMgaW50IG10a190aGVybWFsX3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+Pj4+Pj4gwqDCoMKgIMKgwqDCoMKg wqDCoMKgIHBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIG10KTsKPj4+Pj4+PiDCoMKgwqAgLcKg wqDCoCB0emRldiA9IGRldm1fdGhlcm1hbF9vZl96b25lX3JlZ2lzdGVyKCZwZGV2LT5kZXYsIDAs IG10LAo+Pj4+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAmbXRrX3RoZXJtYWxfb3BzKTsKPj4+Pj4+PiAtwqDCoMKgIGlmIChJU19FUlIodHpk ZXYpKSB7Cj4+Pj4+Pj4gLcKgwqDCoMKgwqDCoMKgIHJldCA9IFBUUl9FUlIodHpkZXYpOwo+Pj4+ Pj4+IC3CoMKgwqDCoMKgwqDCoCBnb3RvIGVycl9kaXNhYmxlX2Nsa19wZXJpX3RoZXJtOwo+Pj4+ Pj4+ICvCoMKgwqAgZm9yIChpID0gMDsgaSA8IG10LT5jb25mLT5udW1fc2Vuc29ycyArIDE7IGkr Kykgewo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCB0eiA9IGRldm1fa21hbGxvYygmcGRldi0+ZGV2 LCBzaXplb2YoKnR6KSwgR0ZQX0tFUk5FTCk7Cj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICgh dHopCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FTk9NRU07Cj4+Pj4+ Pj4gKwo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCB0ei0+bXQgPSBtdDsKPj4+Pj4+PiArwqDCoMKg wqDCoMKgwqAgdHotPmlkID0gaTsKPj4+Pj4+PiArCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHR6 ZGV2ID0gZGV2bV90aGVybWFsX29mX3pvbmVfcmVnaXN0ZXIoJnBkZXYtPmRldiwgaSwgdHosIChp ID09IDApID8KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAmbXRrX3RoZXJtYWxfb3BzIDoKPj4+Pj4+PiArICZt dGtfdGhlcm1hbF9zZW5zb3Jfb3BzKTsKPj4+Pj4+Cj4+Pj4+PiBIZXJlIHlvdSB1c2UgYWdhaW4g dGhlIGFnZ3JlZ2F0aW9uCj4+Pj4+IEkgYWRkcmVzc2VkIHRoaXMgY29uY2VybiBpbiBWNiwgY291 bGQgeW91IHBsZWFzZSB0YWtlIGEgbG9vayBhbmQgbGV0IG1lCj4+Pj4+IGtub3cgd2hhdCB5b3Ug dGhpbmsgWzBdLgo+Pj4+Pgo+Pj4+PiBbMF06IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC81 ZWIwY2RjMi1lOWY5LWRkNDItYmY4MC1iN2RjZDhiY2MxOTZAYmF5bGlicmUuY29tLwo+Pj4+Cj4+ Pj4gTWF5IEkgbWlzdW5kZXJzdGFuZGluZyBidXQgQUZBSUNTLCB0aGlzIHBhdGNoIGlzIHNldHRp bmcgdGhlCj4+Pj4gbXRrX3RoZXJtYWxfb3BzIGlmIHRoZSBzZW5zb3IgaWQgaXMgemVyby4gVGhl IGdldF90ZW1wIGlzIGNvbXB1dGluZyB0aGUKPj4+PiBtYXggdGVtcGVyYXR1cmUgaW4gdGhpcyBv cHMgd2hpY2ggaXMgd2hhdCB3ZSBkb24ndCB3YW50IHRvIGRvLgo+Pj4KPj4+IENvcnJlY3QsIGJ1 dCBJIHRoaW5rIHRoYXQgaXMgb3V0IG9mIHNjb3BlIG9mIHRoaXMgcGF0Y2hzZXQsIGFzIHRoZSBj dXJyZW50Cj4+PiBkcml2ZXIgYWxyZWFkeSB1c2VzIG10a190aGVybWFsX29wcyBmb3Igc2Vuc29y IDAuIFRoZSBmb2N1cyBvZiB0aGlzIHBhdGNoc2V0Cj4+PiBpcyB0byBhZGQgc3VwcG9ydCBmb3Ig dGhlIG90aGVyIHNlbnNvcnMuCj4+Pgo+Pj4gQmVzaWRlcywgd2hhdCBkbyB5b3Ugc3VnZ2VzdCBh cyBhIGNsZWFuIGltcGxlbWVudGF0aW9uIGlmIHRoZSBjdXJyZW50IG9uZQo+Pj4gbm8gbG9uZ2Vy IG1lZXRzIHRoZXJtYWwgY29yZSByZXF1aXJlbWVudHMgPwo+Pgo+PiBJSVVDLCB0aGVyZSBpcyBh IHNlbnNvciBwZXIgY291cGxlIG9mIGNvcmVzLiAxIHggMkJpZ3MsIDEgeCAyQmlncywgMSB4IDQg TGl0dGxlLCByaWdodCA/Cj4KPiBNVDgzNjUgU29DIGhhcyA0IHggQTUzIENQVXMuIFRoZSBTb0Mg aGFzIDQgdGhlcm1hbCB6b25lcyBwZXIgc2Vuc29yLiBUaGVybWFsIHpvbmUgMCBjb3JyZXNwb25k cwo+Cj4gdG8gYWxsIDQgeCBBNTMgQ1BVcywgdGhlIG90aGVyIHRoZXJtYWwgem9uZXMgKDEsIDIg YW5kIDMpIGhhcyBub3RoaW5nIHRvIGRvIHdpdGggQ1BVcy4gVGhlIGNvb2xpbmcgZGV2aWNlIHR5 cGUKPgo+IHVzZWQgZm9yIENQVXMgaXMgcGFzc2l2ZS4gRllJLCB0aGVybWFsIHpvbmVzIDEsIDIg YW5kIDMgYXJlIHByZXNlbnQgaW4gdGhlIFNvQyBmb3IgZGVidWctcHVycG9zZSBvbmx5LCB0aGV5 IGFyZSBub3Qgc3VwcG9zZWQKPgo+IHRvIGJlIHVzZWQgZm9yIHByb2R1Y3Rpb24uCj4KQWZ0ZXIg cmVjb25zaWRlcmluZyB0aGUgZmFjdCB0aGF0IHpvbmVzIDEsIDIgYW5kIDMgYXJlIG9ubHkgdXNl ZCBmb3IgZGV2L2RlYnVnLCBpdCBtaWdodCBiZSBiZXN0IHRvIGF2b2lkCgphZ2dyZWdhdGlvbiBh cyB5b3Ugc3VnZ2VzdGVkLCBhbmQga2VlcCBvbmx5IHN1cHBvcnQgZm9yIHpvbmUgMCBpbiB0aGlz IGRyaXZlci4gVGh1cyBJIHN1Z2dlc3QgSSBzZW5kIGEgVjgKCndoZXJlIEkga2VlcCBvbmx5IGJl bG93IGZpeGVzIGZvciB0aGlzIHBhdGNoIGlmIHRoYXQncyBva2F5IHdpdGggeW91OgoKLSBEZWZp bmUgInJhd190b19tY2Vsc2l1cyIgZnVuY3Rpb24gcG9pbnRlciBmb3IgInN0cnVjdCB0aGVybWFs X2JhbmtfY2ZnIi4KCi0gRml4ICJtdGtfdGhlcm1hbCIgdmFyaWFibGUgaW4gbXRrX3JlYWRfdGVt cCgpLgoKLSBTZXQgIm10LT5yYXdfdG9fbWNlbHNpdXMiIGluIHByb2JlKCkuCgoKRm9yIHpvbmVz IDEsIDIgYW5kIDMgd2UgY2FuIGxhdGVyIGFkZCBhIGRpZmZlcmVudCBkcml2ZXIgc3BlY2lmaWMg Zm9yIGRldi9kZWJ1ZyB0byBwcm9iZSB0aGVtIHRvCgphdm9pZCBjb25mdXNpb24uCgoKUmVnYXJk cywKCkFtamFkCgo+Cj4gUmVnYXJkcywKPgo+IEFtamFkCj4KPj4KPj4gSWYgaXQgaXMgdGhlIGNh c2UsIHRoZW4gYSB0aGVybWFsIHpvbmUgcGVyIHNlbnNvciB3aXRoIHRoZSB0cmlwIHBvaW50cyBh bmQgYSBjb29saW5nIGRldmljZSBmb3IgZWFjaCBvZiB0aGVtLgo+Pgo+PiBUaGUgdHdvIHRoZXJt YWwgem9uZXMgZm9yIHRoZSBiaWcgd2lsbCBzaGFyZSB0aGUgc2FtZSBjb29saW5nIGRldmljZS4g VGhlIGxpdHRsZSB0aGVybWFsIHpvbmUgd2lsbCBoYXZlIGl0cyBvd24gY29vbGluZyBkZXZpY2Uu Cj4+Cj4+IElmIHRoZXJlIGlzIHRoZSBHUFUsIHRoZW4gaXRzIG93biBjb29saW5nIGRldmljZSBh bHNvIHdpdGggZGV2ZnJlcS4KPj4KPj4KPj4+PiA8aHR0cDovL3d3dy5saW5hcm8ub3JnLz4gTGlu YXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCj4+Pj4KPj4+PiBG b2xsb3cgTGluYXJvOsKgIDxodHRwOi8vd3d3LmZhY2Vib29rLmNvbS9wYWdlcy9MaW5hcm8+IEZh Y2Vib29rIHwKPj4+PiA8aHR0cDovL3R3aXR0ZXIuY29tLyMhL2xpbmFyb29yZz4gVHdpdHRlciB8 Cj4+Pj4gPGh0dHA6Ly93d3cubGluYXJvLm9yZy9saW5hcm8tYmxvZy8+IEJsb2cKPj4+Cj4+Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==