From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB5AC43381 for ; Fri, 8 Jan 2021 09:57:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3091623716 for ; Fri, 8 Jan 2021 09:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728191AbhAHJ5j (ORCPT ); Fri, 8 Jan 2021 04:57:39 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:40199 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727898AbhAHJ5i (ORCPT ); Fri, 8 Jan 2021 04:57:38 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610099842; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=rGYMlvx+81LgALQ6E4x5ySpL+k2I8nl0X8pOs7NL20U=; b=MwiKTNFWRRYlCX3V1OgX4bDhFXMSW4+OQCXzhB0lxgKFclb/ZzBZhAsL8oM9SFCMcw2QGpP4 AjTFgeInWcSiyDM6WvHAMf1y6GTof9v/77YwAyosdcjQnIRhO4LeD01NI8U1g25vha14TI1M +//eAJA8qQ1WuFYY0lq4IYHsPAk= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5ff82c5f922ae55531d57c12 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 08 Jan 2021 09:56:47 GMT Sender: rojay=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 23B17C43463; Fri, 8 Jan 2021 09:56:47 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rojay) by smtp.codeaurora.org (Postfix) with ESMTPSA id 96026C433C6; Fri, 8 Jan 2021 09:56:46 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 08 Jan 2021 15:26:46 +0530 From: rojay@codeaurora.org To: Wolfram Sang Cc: swboyd@chromium.org, dianders@chromium.org, saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org, mka@chromium.org, akashast@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org, pyarlaga@codeaurora.org, rnayak@codeaurora.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org Subject: Re: [PATCH V7 2/2] i2c: i2c-qcom-geni: Add shutdown callback for i2c In-Reply-To: <20210105152747.GB1842@ninjato> References: <20201221123801.26643-1-rojay@codeaurora.org> <20201221123801.26643-3-rojay@codeaurora.org> <20210105152747.GB1842@ninjato> Message-ID: X-Sender: rojay@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Wolfram, On 2021-01-05 20:57, Wolfram Sang wrote: >> + geni_status = readl_relaxed(gi2c->se.base + SE_GENI_STATUS); >> + if (!(geni_status & M_GENI_CMD_ACTIVE)) >> + goto out; >> + >> + cur = gi2c->cur; >> + geni_i2c_abort_xfer(gi2c); >> + if (cur->flags & I2C_M_RD) >> + geni_i2c_rx_msg_cleanup(gi2c, cur); >> + else >> + geni_i2c_tx_msg_cleanup(gi2c, cur); >> +out: >> + pm_runtime_put_sync_suspend(gi2c->se.dev); >> +} > > The use of 'goto' is not needed here IMHO. I think: > > if (geni_status & M_GENI_CMD_ACTIVE) { > do_the_stuff > } > > pm_runtime_put_sync_suspend(...); > > is more readable, in fact. > In context to the previous comment [1], I have implemented this way. But, yeah anything is fine for me. > Also, I don't think we really need the 'cur' > variable and just use 'gi2c->cur' but that's very minor and you can > keep > it if you like it. > In geni_i2c_abort_xfer() function gi2c->cur will be made NULL, so copying it before to "cur" is needed here. > Reset looks good! [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/20200820103522.26242-3-rojay@codeaurora.org/#23560541 Thanks, Roja