Re: [PATCH v16 4/9] x86: add multiboot2 protocol support for EFI platforms

From: Doug Goldstein <cardoe@cardoe.com>
To: Daniel Kiper <daniel.kiper@oracle.com>, Jan Beulich <JBeulich@suse.com>
Cc: Juergen Gross <JGross@suse.com>,
	sstabellini@kernel.org, andrew.cooper3@citrix.com,
	pgnet.dev@gmail.com, ning.sun@intel.com, julien.grall@arm.com,
	xen-devel@lists.xenproject.org, qiaowei.ren@intel.com,
	gang.wei@intel.com, fu.wei@linaro.org
Subject: Re: [PATCH v16 4/9] x86: add multiboot2 protocol support for EFI platforms
Date: Wed, 22 Feb 2017 09:04:17 -0800	[thread overview]
Message-ID: <d3ed6337-c78f-7fb6-35d3-9e5f6f82812a@cardoe.com> (raw)
In-Reply-To: <20170222153421.GD3484@olila.local.net-space.pl>

[-- Attachment #1.1.1: Type: text/plain, Size: 2499 bytes --]

On 2/22/17 7:34 AM, Daniel Kiper wrote:
> On Wed, Feb 22, 2017 at 06:42:40AM -0700, Jan Beulich wrote:
>>>>> On 21.02.17 at 20:24, <daniel.kiper@oracle.com> wrote:
>>> On Tue, Feb 21, 2017 at 08:19:53PM +0100, Daniel Kiper wrote:
>>>> This way Xen can be loaded on EFI platforms using GRUB2 and
>>>> other boot loaders which support multiboot2 protocol.
>>>>
>>>> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
>>>> ---
>>>> v16 - suggestions/fixes:
>>>>     - improve comments in error handling
>>>>       (suggested by Jan Beulich).
>>>
>>> Diff between v15 and v16:
>>
>> While I'm still not really happy with the changes done, and the VGA
>> (or not) handling in general, after discussing this yet another time
>> with Andrew we've decided to put in at least the first 4 patches. The
> 
> Thanks a lot!
> 
>> rest of the series will need to have the reported regression (by
>> Doug) taken care of to become a candidate for committing.
> 
> I tried to reproduce this on my machines and some guys from my team
> did also some tests. We were not able to reproduce anything reported
> by Doug. Recently I repeated the tests on QEMU 2.8.0 with OVMF from
> https://www.kraxel.org/repos/jenkins/edk2/ (20170213.b2458.g5b97eb4).
> Without any issues too. I need more details about tests environments
> (exact host kernel version and config, QEMU and OVMF versions and config,
> exact Xen and dom0 kernel versions and config, etc.). It would be nice
> to get access to one of these physical machines on which issues are
> surfacing too.
> 
> Daniel
> 

I'm currently at ELC and then on vacation so I don't have access to any
of the machines currently myself. However the machine I most use to test
is a NUC5i5MYHE and a NUC5i3MYHE if you want to ask around if someone
has one internally. But that's why I gave QEMU as an example.

I was using qemu master from a few weeks ago. I'll have to find the
revision for you. But the command line I use is:

-enable-kvm -M pc-q35-2.8 -device intel-iommu -cpu host -m 2048 -smp 2
-drive if=pflash,format=raw,file=/tmp/tmp.EiR6ixmYzV -global
isa-debugcon.iobase=0x402 -debugcon file:/tmp/tmp.nuvEXUWfnA -monitor
stdio -chardev socket,host=127.0.0.1,port=25914,id=S0,server,nowait
-device isa-serial,chardev=S0 -device piix3-usb-uhci -device usb-tablet
-netdev id=net0,type=tap -device
virtio-net-pci,netdev=net0,mac=52:54:00:12:34:56 -boot order=n -device
qxl-vga -gdb tcp::14952

-- 
Doug Goldstein

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel