From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E77C28CBC for ; Sat, 9 May 2020 15:54:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EF0124955 for ; Sat, 9 May 2020 15:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728171AbgEIPyb (ORCPT ); Sat, 9 May 2020 11:54:31 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:38197 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727105AbgEIPyb (ORCPT ); Sat, 9 May 2020 11:54:31 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 49KBb73l86z9v0Zm; Sat, 9 May 2020 17:54:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id hhT93JtYMSPR; Sat, 9 May 2020 17:54:27 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 49KBb72sdxz9v2CW; Sat, 9 May 2020 17:54:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 91C698B775; Sat, 9 May 2020 17:54:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id QdzKxSQXGUVx; Sat, 9 May 2020 17:54:29 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 6232E8B75F; Sat, 9 May 2020 17:54:28 +0200 (CEST) Subject: Re: [PATCH v8 8/8] powerpc/vdso: Provide __kernel_clock_gettime64() on vdso32 To: Arnd Bergmann Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Nathan Lynch , "linux-kernel@vger.kernel.org" , linuxppc-dev , Thomas Gleixner , Vincenzo Frascino , Andy Lutomirski , linux-arch References: From: Christophe Leroy Message-ID: Date: Sat, 9 May 2020 17:54:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 28/04/2020 à 18:05, Arnd Bergmann a écrit : > On Tue, Apr 28, 2020 at 3:16 PM Christophe Leroy > wrote: >> >> Provides __kernel_clock_gettime64() on vdso32. This is the >> 64 bits version of __kernel_clock_gettime() which is >> y2038 compliant. >> >> Signed-off-by: Christophe Leroy > > Looks good to me > > Reviewed-by: Arnd Bergmann > > There was a bug on ARM for the corresponding function, so far it is unclear > if this was a problem related to particular hardware, the 32-bit kernel code, > or the common implementation of clock_gettime64 in the vdso library, > see https://github.com/richfelker/musl-cross-make/issues/96 > > Just to be sure that powerpc is not affected by the same issue, can you > confirm that repeatedly calling clock_gettime64 on powerpc32, alternating > between vdso and syscall, results in monotically increasing times? > I think that's one of the things vdsotest checks, so yes that's ok I think. Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F69AC28CBC for ; Sat, 9 May 2020 15:56:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83F1520CC7 for ; Sat, 9 May 2020 15:56:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83F1520CC7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49KBdL2jk6zDr4h for ; Sun, 10 May 2020 01:56:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49KBbD65dSzDqj1 for ; Sun, 10 May 2020 01:54:32 +1000 (AEST) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 49KBb73l86z9v0Zm; Sat, 9 May 2020 17:54:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id hhT93JtYMSPR; Sat, 9 May 2020 17:54:27 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 49KBb72sdxz9v2CW; Sat, 9 May 2020 17:54:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 91C698B775; Sat, 9 May 2020 17:54:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id QdzKxSQXGUVx; Sat, 9 May 2020 17:54:29 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 6232E8B75F; Sat, 9 May 2020 17:54:28 +0200 (CEST) Subject: Re: [PATCH v8 8/8] powerpc/vdso: Provide __kernel_clock_gettime64() on vdso32 To: Arnd Bergmann References: From: Christophe Leroy Message-ID: Date: Sat, 9 May 2020 17:54:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathan Lynch , linux-arch , "linux-kernel@vger.kernel.org" , Paul Mackerras , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 28/04/2020 à 18:05, Arnd Bergmann a écrit : > On Tue, Apr 28, 2020 at 3:16 PM Christophe Leroy > wrote: >> >> Provides __kernel_clock_gettime64() on vdso32. This is the >> 64 bits version of __kernel_clock_gettime() which is >> y2038 compliant. >> >> Signed-off-by: Christophe Leroy > > Looks good to me > > Reviewed-by: Arnd Bergmann > > There was a bug on ARM for the corresponding function, so far it is unclear > if this was a problem related to particular hardware, the 32-bit kernel code, > or the common implementation of clock_gettime64 in the vdso library, > see https://github.com/richfelker/musl-cross-make/issues/96 > > Just to be sure that powerpc is not affected by the same issue, can you > confirm that repeatedly calling clock_gettime64 on powerpc32, alternating > between vdso and syscall, results in monotically increasing times? > I think that's one of the things vdsotest checks, so yes that's ok I think. Christophe