From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 01/28] drm: omapdrm: Remove duplicate error messages when mapping memory Date: Mon, 8 May 2017 15:52:07 +0300 Message-ID: References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-2-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1857114709==" Return-path: Received: from lelnx194.ext.ti.com (lelnx194.ext.ti.com [198.47.27.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99EFC6E1D2 for ; Mon, 8 May 2017 12:52:13 +0000 (UTC) In-Reply-To: <20170508113303.27521-2-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1857114709== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fbvXXRn20edP6MBfQhTRpivVKjLCsjvCT" --fbvXXRn20edP6MBfQhTRpivVKjLCsjvCT Content-Type: multipart/mixed; boundary="PbDPhI5wA1JncSCA7nDfU1Ea72sD4sjmS"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Message-ID: Subject: Re: [PATCH v2 01/28] drm: omapdrm: Remove duplicate error messages when mapping memory References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-2-laurent.pinchart@ideasonboard.com> In-Reply-To: <20170508113303.27521-2-laurent.pinchart@ideasonboard.com> --PbDPhI5wA1JncSCA7nDfU1Ea72sD4sjmS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/05/17 14:32, Laurent Pinchart wrote: > The devm_ioremap_resource() call can handle being given a NULL resource= , > and prints an error message when mapping fails. Switch the remaining > devm_ioremap() calls to devm_ioremap_resource() and remove all > extraneous resource NULL checks and error messages printed manually by > the driver. Looks like in some places we check for "!ret" and in some "IS_ERR(ret)"..= =2E Tomi --PbDPhI5wA1JncSCA7nDfU1Ea72sD4sjmS-- --fbvXXRn20edP6MBfQhTRpivVKjLCsjvCT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZEGn3AAoJEPo9qoy8lh71eUQP/jiMoKttxK9MfbNSPnuDWxC0 u9ltlKzCpgoolX/gFuXFA+lIYHMk8+AlkRKrrfXxx208qoFZc/LoPx32olyrV2vg g5ZvxIY0h7P/arFfITbNpHvonZW88LAhiJ3PhrCEQPcPcs3pq/MKYj4V9781A/yh crIMahHWEI/IkdXX1AwPYyz1gWuGmc/dLlfhufms6qAJIwaF/3hBzAZGy9XdS2nc BvfU0rsHnJCZlnTyeovPNTqx5nr0BY34RjA1hYNvlyMH4AYs8APdMc3n9cU/v5eE muPcXu/xLu/TU82/r5OQtZwn2/kRJReSvw7nxx6xJc2XYIrz5wbdIaxz5ANyfreZ lV5IkN7PEfXrMJUgVoKyqIsd0SvKLxstbZksM9naB3nVnQqm0Cf5vHDjRlUyc2XP S+YSp0nDfz2CUawky7mMJN2xoYp0C+31AwgY2ZEtRCxSjcQMMkTG2EwNiNlTntjR yTb4pExoUUZsQLRDs2yGI2lCUEX8A6uOjOp4ryVvB7FBxSaSZsP0NHAjEBIDYwvC MphDFe7tZkkcBI8dfer1yfPRerlfLqAM4q1zM6fgKKOL/kCNv0kFh6m69DseaN89 vDb5nkmwokeop6HGF5PRDgbdG6TMSXdWRd+CzG0WXqWTnUluABdFbsmwJ1XOWFef hvUrnH6XiY1Uj4hCdxU1 =yx5s -----END PGP SIGNATURE----- --fbvXXRn20edP6MBfQhTRpivVKjLCsjvCT-- --===============1857114709== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1857114709==--