From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 189FCC63797 for ; Tue, 17 Jan 2023 12:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1hvax7ZvyvGut2OnKJoE7Dxho/r6vYUgaqQ/AasCuOs=; b=Ws1/5i0gJPmCUT u/2rY2mIG5mt6df6UOYayqJrcEcaV0wRt+L4HPu003k1lww5+OAuuoNPA5PKW/cWY9Du1FIZ9+e0F cTyhpO249CiRaEJT79QXgUezAy+8J/xL1uDK4SrOS4oWuOkmkbWucod0aKAxepiGAs3uQkfnNawuc Hy02aEpG1m7bSLl2dmUt4Xl3OQXwtyjCb5usSjC4l7yPKPgd3rg5GlBhjA3kwHZKAtQrhtUpVs4Iw UbBmg3KdZpJshMHQIJKBKoaN+Pwpz3m0THA911pbsDDFwP6Y/6fyyqCyLp1TZaRRUGKAwpJfjrZcq ni2g2+/RBoZbCNvfwb+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHl7t-00EB1a-79; Tue, 17 Jan 2023 12:31:41 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHl7p-00EB0O-Av for linux-arm-kernel@lists.infradead.org; Tue, 17 Jan 2023 12:31:39 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 536028555D; Tue, 17 Jan 2023 13:31:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1673958694; bh=b+QU2hjw/qRgVcvx6+o+SBchNzfMQNzFB5n3M4G1TQk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YJloXwxVZsoZtkH6h/ZpzQc1xAK6f3czK6B7rcDUmGSi5QvZhL0sX2HpD1ysxmsov 4U8gNU0EYcixU8o/SHh4cfYCvwW0N+IZo6i91ukTgfXK+XaJNXs8+7HBN/8v44p+oe UxyZDVF4H26QByYLa+s4slPLiWmgWo5ypaDB5p+TPhNrDtJashZrZZnb//PEH9Lv8h bY5ntRbMnFJgXclS+LPVRx66rPxpVhzsUmiNl25SOerL2d57rulnQqoli9XtsW5KWE 48VqJ6jt5XPuUJwsS71XpiuaFS7Eq6eGHeEsqfWudBZLY2AsOy2wJl4/ESXTmCzjNf /QzXLcF+D2H4g== Message-ID: Date: Tue, 17 Jan 2023 13:31:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mq: Deduplicate PCIe clock-names property Content-Language: en-US To: Hongxing Zhu , "linux-arm-kernel@lists.infradead.org" Cc: Alexander Stein , Fabio Estevam , Peng Fan , Shawn Guo , dl-linux-imx References: <20230116101422.46257-1-marex@denx.de> <20230116101422.46257-2-marex@denx.de> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230117_043137_638167_78B490DF X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/17/23 05:00, Hongxing Zhu wrote: Hi, [...] >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> index faed28e3ffa17..98fbba4c99a99 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> @@ -1542,6 +1542,11 @@ pcie0: pcie@33800000 { >> <0 0 0 4 &gic GIC_SPI 122 >> IRQ_TYPE_LEVEL_HIGH>; >> fsl,max-link-speed = <2>; >> linux,pci-domain = <0>; >> + clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>, >> + <&clk IMX8MQ_CLK_PCIE1_PHY>, >> + <&clk IMX8MQ_CLK_PCIE1_PHY>, > Why there are two PHY clocks? > Do you want to define IMX8MQ_CLK_PCIE1_PHY clock as "pcie_bus" clock here, > and then change "pcie_bus" clock to "pcie0_refclk" in the evk board dts later? Yes > How about to set the "pcie_bus" clock as " pcie#_refclk " directly in i.MX8MQ > dtsi file? > Thus, it can avoid more duplicated codes in boards dts files further. I can do that, but is that really the right approach ? Consider a board which supplies 'pcie_bus' from some I2C PCIe clock generator, such board would now have a useless /pcie#-clock {} node in DT , right ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel