From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7777C43387 for ; Tue, 15 Jan 2019 11:43:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E9E020656 for ; Tue, 15 Jan 2019 11:43:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729251AbfAOLng (ORCPT ); Tue, 15 Jan 2019 06:43:36 -0500 Received: from mx2.suse.de ([195.135.220.15]:52284 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727985AbfAOLnf (ORCPT ); Tue, 15 Jan 2019 06:43:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9F239ACD0; Tue, 15 Jan 2019 11:43:34 +0000 (UTC) Subject: Re: [PATCH 04/25] mm, compaction: Remove unnecessary zone parameter in some instances To: Mel Gorman , Linux-MM Cc: David Rientjes , Andrea Arcangeli , ying.huang@intel.com, kirill@shutemov.name, Andrew Morton , Linux List Kernel Mailing References: <20190104125011.16071-1-mgorman@techsingularity.net> <20190104125011.16071-5-mgorman@techsingularity.net> From: Vlastimil Babka Openpgp: preference=signencrypt Message-ID: Date: Tue, 15 Jan 2019 12:43:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <20190104125011.16071-5-mgorman@techsingularity.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/4/19 1:49 PM, Mel Gorman wrote: > A zone parameter is passed into a number of top-level compaction functions > despite the fact that it's already in cache_control. This is harmless but ^ compact_control > it did need an audit to check if zone actually ever changes meaningfully. Tried changing the field to "struct zone * const zone;" and it only flagged compact_node() and kcompactd_do_work() which look ok. > This patches removes the parameter in a number of top-level functions. The > change could be much deeper but this was enough to briefly clarify the > flow. > > No functional change. > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka