All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Philipson <ross.philipson@oracle.com>
To: Daniel Kiper <daniel.kiper@oracle.com>, grub-devel@gnu.org
Cc: alexander.burmashev@oracle.com, eric.snowberg@oracle.com,
	leif.lindholm@linaro.org, phcoder@gmail.com
Subject: Re: [PATCH 0/5] Various GRUB build fixes
Date: Tue, 19 Mar 2019 11:16:52 -0400	[thread overview]
Message-ID: <d42f7d83-dc18-1003-61ef-39fceb769e1c@oracle.com> (raw)
In-Reply-To: <20190319123918.19267-1-daniel.kiper@oracle.com>

On 03/19/2019 08:39 AM, Daniel Kiper wrote:
> Hey,
> 
> As in subject... I am CC-ing folks who were somehow involved in
> doing/reviewing patches touching broken files. If I missed somebody
> then sorry about that. Anyway, please take a look.
> 
> There are still broken builds which I am going to fix soon. However,
> fortunately most of our targets build without any issue right now.
> 
> Daniel
> 
>  grub-core/kern/compiler-rt.c              | 5 +++--
>  grub-core/loader/ia64/efi/linux.c         | 3 +--
>  grub-core/loader/mips/linux.c             | 2 +-
>  grub-core/loader/powerpc/ieee1275/linux.c | 4 ++--
>  include/grub/compiler-rt.h                | 4 +++-
>  5 files changed, 10 insertions(+), 8 deletions(-)
> 
> Daniel Kiper (5):
>       verifiers: IA-64 fallout cleanup

It seems like the things fixed in these two would have prevented
compiling. I guess it was not tried on these platforms?

>       verifiers: PowerPC fallout cleanup
>       verifiers: MIPS fallout cleanup>       mips: Enable __clzsi2()
>       sparc: Enable __clzsi2() and __clzdi2()
> 

Anyway, LGTM

Reviewed-by: Ross Philipson <ross.philipson@oracle.com>


  parent reply	other threads:[~2019-03-19 15:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 12:39 [PATCH 0/5] Various GRUB build fixes Daniel Kiper
2019-03-19 12:39 ` [PATCH 1/5] verifiers: IA-64 fallout cleanup Daniel Kiper
2019-03-19 12:39 ` [PATCH 2/5] verifiers: PowerPC " Daniel Kiper
2019-03-19 12:39 ` [PATCH 3/5] verifiers: MIPS " Daniel Kiper
2019-03-19 12:39 ` [PATCH 4/5] mips: Enable __clzsi2() Daniel Kiper
2019-03-19 12:39 ` [PATCH 5/5] sparc: Enable __clzsi2() and __clzdi2() Daniel Kiper
2019-03-19 15:16 ` Ross Philipson [this message]
2019-03-20 12:02   ` [PATCH 0/5] Various GRUB build fixes Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d42f7d83-dc18-1003-61ef-39fceb769e1c@oracle.com \
    --to=ross.philipson@oracle.com \
    --cc=alexander.burmashev@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=eric.snowberg@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=leif.lindholm@linaro.org \
    --cc=phcoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.